[Discover] Flyout in Fullscreen mode needs to be full-height

[snide]

Discover's data grid when in full screen mode does not account for the header being missing when the flyout for each row is invoked.

[elasticmachine]

Pinging @elastic/kibana-design (Team:Kibana-Design)

[elasticmachine]

Pinging @elastic/kibana-app (Team:KibanaApp)

[MichaelMarcialis]

@snide: I took a quick peek at this, and I believe this issue may be caused by the EUI mixin euiHeaderAffordForFixed in src/global_styling/mixins/_header.scss. This EUI mixin is being called in Kibana on line 39 of src/core/public/rendering/_base.scss.

Currently the mixin is applying a top offset to account for the headers, but doesn't currently account for situations where the EuiDataGrid component is in full screen mode. It seems like EuiDataGrid applies a body class of euiDataGrid__restrictBody when in full screen mode. As such, I imagine an easy fix would be to add a :not(. euiDataGrid__restrictBody) selector to the styles in question.

Do you come to the same conclusion? If so, I'd be happy to cut a PR with those changes to the EUI mixin.

[ryankeairns]

Lazy Ryan wonders how we handle this in Maps. They don't use a flyout but they do have a sidebar and full screen mode.

Also, I've added this to the DataGrid errata issue as something to address before setting as default.

[snide]

@MichaelMarcialis Yep. I think it's a good idea to solve it globally. If you do end up taking it on, make sure to close out #108896 which is essentially the same issue, but in security. My guess is applying the selector broadly based upon the body will work.

[MichaelMarcialis]

@MichaelMarcialis Yep. I think it's a good idea to solve it globally. If you do end up taking it on, make sure to close out #108896 which is essentially the same issue, but in security. My guess is applying the selector broadly based upon the body will work.

Sounds good. Will cut a PR for this today.