Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Allow switching height of rows in data grid #109107

Closed
timroes opened this issue Aug 18, 2021 · 4 comments · Fixed by #122087
Closed

[Discover] Allow switching height of rows in data grid #109107

timroes opened this issue Aug 18, 2021 · 4 comments · Fixed by #122087
Assignees
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@timroes
Copy link
Contributor

timroes commented Aug 18, 2021

We want to give the user a choice about their row heights in data grid. They should be able to chose between 1 line, 3 lines, 5 lines, auto height.

The default should be 1 line. This setting should be stored with the saved search saved object.

display-dg

Blocked on elastic/eui#5080

Auto height will require elastic/eui#4634.

@timroes timroes added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ryankeairns
Copy link
Contributor

ryankeairns commented Aug 24, 2021

@timroes Is the plan to add this piece of UI even before the auto-height PR is completed?
One benefit to doing this earlier is that we can put it in front of some users, including some of whom Shaun discussed this solution with and expressed interest.

cc:/ @shaunmcgough

@timroes timroes added blocked Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 25, 2021
@timroes
Copy link
Contributor Author

timroes commented Sep 14, 2021

@ryankeairns Sorry I missed this. After one of the meetings, we came to the conclusion that this switcher should be in the EUI component itself (tracked via elastic/eui#5080). We currently assume we could roll out as long as that switcher is available, even if auto-height is not yet in the switcher. Thus we'd appreciate if work on the switcher in EUI is already started potentially before the auto height PR is closed. I'll also discuss this with Chandler in our regular sync tomorrow.

@kertal kertal removed the blocked label Dec 22, 2021
@Mekk
Copy link

Mekk commented Dec 28, 2021

Small reminder that formatted multiline logs happen (and are reasonably supported by „old” discover - once truncate.maxHeight is increased):
https://discuss.elastic.co/t/dec-12th-2021-en-new-document-explorer-in-discover/290446/2?u=mekk

Please, don't remove such a possibility…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants