Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Accessibility audit Data Grid in Discover #109110

Closed
timroes opened this issue Aug 18, 2021 · 8 comments
Closed

[Discover] Accessibility audit Data Grid in Discover #109110

timroes opened this issue Aug 18, 2021 · 8 comments
Assignees
@1Copenut @zuhairmahd
Labels
Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@timroes
Copy link
Contributor

timroes commented Aug 18, 2021 •
edited by ryankeairns
Loading

We should do a full accessibility audit of the data grid implementation in Discover.

Open EUI a11y issues for data grid
@timroes timroes added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 18, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes mentioned this issue Aug 18, 2021
Closed
41 tasks
@ryankeairns ryankeairns changed the title Accessibility audit Data Grid in Discover [Discover] Accessibility audit Data Grid in Discover Aug 18, 2021
@timroes timroes added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@zuhairmahd zuhairmahd self-assigned this Nov 10, 2021
@zuhairmahd
Copy link

zuhairmahd commented Nov 10, 2021 •
edited
Loading

Added myself along with @1Copenut now that I have access to the repo.

@kertal
Copy link
Member

kertal commented Mar 2, 2022

dear @1Copenut & @zuhairmahd , what's the current state of this? many thx!

@1Copenut
Copy link
Contributor

1Copenut commented Mar 2, 2022

Hello @kertal. My tests for automation, color contrast, and keyboard/zoom have all been logged in the meta issue #85965. I've been slowly adding components to the axe-core automated tests in EUI on a feature branch, and this includes the data grid now that a lot of the issues have been closed.

@kertal
Copy link
Member

kertal commented Jun 28, 2022

@1Copenut this is finished, right? so we can close this

@1Copenut
Copy link
Contributor

@kertal I believe so, yes.

cc/ @zuhairmahd

@zuhairmahd
Copy link

Yes. We are all good to go.

@kertal
Copy link
Member

kertal commented Jun 29, 2022

thank you @1Copenut & @zuhairmahd , @davismcphee already took care of lots of a11y issues in Discover!

@kertal kertal closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@1Copenut 1Copenut

@zuhairmahd zuhairmahd

Labels
Feature:Discover Discover Application Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kertal @timroes @1Copenut @elasticmachine @zuhairmahd