Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable aliases when an object is deleted or unshared #116235

Closed
jportner opened this issue Oct 26, 2021 · 1 comment · Fixed by #117056
Closed

Disable aliases when an object is deleted or unshared #116235

jportner opened this issue Oct 26, 2021 · 1 comment · Fixed by #117056
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@jportner
Copy link
Contributor

Kibana version: master (pre-8.0 release)

Describe the bug:

Legacy URL aliases should only exist when they have a valid target to point to.
Today, if an object is deleted, or if it is unshared from a space, the alias will be unaffected. This doesn't affect users in 7.16 but it can in 8.0.

Scenario:

  1. Space X has an alias "foo:123" that points to object "foo:456"
  2. User deletes "foo:456"
  3. User attempts to create "foo:123", this will result in an alias conflict error, even though that operation is not actually problematic because the alias has no valid target

Expected behavior:

When an object is removed from a space in any way, if it has an alias pointing to it, that alias should be deleted or disabled.
Disabling it would be the safer bet in case users want to revert to their previous state, but that would mean the only way users could fully delete aliases organically by using the Kibana UI would be to delete an entire space. Maybe that's acceptable and we can add some sort of alias cleanup task in the upgrade assistant or an alias management UI in the future to allow users to remove stale/disabled aliases.

@jportner jportner added bug Fixes for quality problems that affect the customer experience Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Oct 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 27, 2021
@jportner jportner added the Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature label Oct 27, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Oct 27, 2021
@jportner jportner self-assigned this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Security/Sharing Saved Objects Platform Security - Sharing Saved Objects feature impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants