Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiDataGrid][KEYBOARD]: Could we consider adding a shortcut key or chord to skip to the data grid from anywhere in the page? #121453

Open
Tracked by #85965
1Copenut opened this issue Dec 16, 2021 · 5 comments
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Project:Accessibility Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@1Copenut
Copy link
Contributor

Summary
@zuhairmahd and @1Copenut have been auditing the Discover data grid for accessibility the last few week. Zuhair mentioned there are a lot of keypresses to move from the top of the page, through the column controls, to the data grid. We'd like to explore a shortcut key or chord that would allow users to jump to the data grid quickly from anywhere on the page.

Zuhair also mentioned he has some ideas about key chord shortcuts. He identified some patterns coalescing in services like GitHub and Gmail.

Describe a specific use case for the feature:
Giving users a way to navigate quickly to the data grid, and perform common tasks within it like expanding a row or data.

@cchaos
Copy link
Contributor

cchaos commented Dec 16, 2021

What would happen if there are multiple data grids on a page?

@cee-chen
Copy link
Member

I'm not super convinced this should be a baseline EuiDataGrid feature vs. a per-application feature that gets added at the Kibana level - I think it makes more sense that way just personally as each individual plugin/app is going to have a better sense of its page hierarchy than we possibly could.

@1Copenut
Copy link
Contributor Author

Thanks y'all. I almost filed this in the Kibana repo, then talked myself out of it. 😆

I'll transfer it so to keep the comment thread.

@1Copenut 1Copenut transferred this issue from elastic/eui Dec 16, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 16, 2021
@1Copenut 1Copenut added Feature:Discover Discover Application Project:Accessibility Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) labels Dec 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 16, 2021
@kertal kertal added the enhancement New value added to drive a business result label Dec 20, 2021
@KOTungseth KOTungseth added loe:needs-research This issue requires some research before it can be worked on or estimated impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Project:Accessibility Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Development

No branches or pull requests

6 participants