Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dashboard] Overlapping resize icons when using documents explorer full screen mode #123196

Closed
kertal opened this issue Jan 18, 2022 · 4 comments
Closed

[Dashboard] Overlapping resize icons when using documents explorer full screen mode #123196

kertal opened this issue Jan 18, 2022 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@kertal
Copy link
Member

kertal commented Jan 18, 2022 •
edited
Loading

Kibana version:
8.1

Describe the bug:
When using Discover's document explorer's full screen mode on a dashboard in edit mode, the resize icons of the embeddables are visible.

Steps to reproduce:

  1. Enable Document explorer in Advanced settings
  2. Open a Dashboard like "[Flights] Global Flight Dashboard" or any dashboard that contains a saved search embeddable
  3. Click on the Full screen button of the saved search embeddable

Expected behavior:
You should not see the resize icons in full screen mode

Screenshots (if relevant):

Bildschirmfoto 2022-01-18 um 09 53 41

discover-dashboard-fullscreen.mp4
@kertal kertal added the bug Fixes for quality problems that affect the customer experience label Jan 18, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 18, 2022
@kertal kertal added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed needs-team Issues missing a team label labels Jan 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kertal kertal added Feature:Dashboard Dashboard related features triage_needed labels Jan 18, 2022
@kibanamachine kibanamachine added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated labels Jan 18, 2022
@kertal kertal mentioned this issue Jan 18, 2022
Closed
@ThomThomson ThomThomson added good first issue low hanging fruit impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort and removed loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jan 18, 2022
@ThomThomson
Copy link
Contributor

I wonder if this is an issue with z-index? If so, this should be a fairly easy fix.

Dashboard panels have their own maximized mode, which doesn't suffer from this problem, I think because that mode hides all the other panels, rather than just relying on z-index to draw overtop.

@kertal
Copy link
Member Author

kertal commented Jan 18, 2022

yes, it's z-index, however, when removing the z-index, this causes another issue, there are visualizations where the resize icon is no longer visible

@ThomThomson ThomThomson added loe:medium Medium Level of Effort and removed good first issue low hanging fruit loe:small Small Level of Effort labels Jan 18, 2022
@ThomThomson
Copy link
Contributor

Closing this in favour of #134032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kertal @ThomThomson @elasticmachine @kibanamachine