Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Data] Move the rest of the datatable utility functions to the related service #133541

Closed
dokmic opened this issue Jun 3, 2022 · 1 comment · Fixed by #134562
Closed

[Data] Move the rest of the datatable utility functions to the related service #133541

dokmic opened this issue Jun 3, 2022 · 1 comment · Fixed by #134562
Labels
enhancement New value added to drive a business result Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@dokmic
Copy link
Contributor

dokmic commented Jun 3, 2022

In continuation of #126572 work, we can move the remaining utility functions to the service:

  • getDateHistogramMetaDataByDatatableColumn;
  • getNumberHistogramIntervalByDatatableColumn;
  • checkColumnForPrecisionError.

After moving those functions, all the references should be updated accordingly.
@dokmic dokmic added Feature:Search Querying infrastructure in Kibana Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) loe:small Small Level of Effort Team:AppServicesSv impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jun 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@dokmic dokmic changed the title [Data] Move the rest of the datatable utility function to the related service [Data] Move the rest of the datatable utility functions to the related service Jun 3, 2022
@dokmic dokmic added EnableJiraSync enhancement New value added to drive a business result labels Jun 3, 2022
@dokmic dokmic mentioned this issue Jun 16, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New value added to drive a business result Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Feature:Search Querying infrastructure in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Data] Move the rest of the datatable utility functions to the related service dokmic/kibana
2 participants
@dokmic @elasticmachine