Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Remove maps-telemetry SO registration #139347

Closed
afharo opened this issue Aug 24, 2022 · 4 comments
Closed

[Maps] Remove maps-telemetry SO registration #139347

afharo opened this issue Aug 24, 2022 · 4 comments
Labels
Feature:Maps Feature:Migrations Feature:Saved Objects Feature:Telemetry impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. migration-resilience Issues related to migration resilience in terms of scale, performance & backwards compatibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@afharo
Copy link
Member

afharo commented Aug 24, 2022

Maps added a temporary workaround to be able to remove the maps-telemetry SOs while #67086 was completed:

/*
* The maps-telemetry saved object type isn't used, but in order to remove these fields from
* the mappings we register this type with `type: 'object', enabled: true` to remove all
* previous fields from the mappings until https://github.com/elastic/kibana/issues/67086 is
* solved.
*/
core.savedObjects.registerType({
name: 'maps-telemetry',
hidden: false,
namespaceType: 'agnostic',
mappings: {
// @ts-ignore Core types don't support this since it's only really valid when removing a previously registered type
type: 'object',
enabled: false,
},
});

Since the referred issue is already complete. We should remove this bit.

Additional context: we may also want to remove it from 7.17: https://github.com/elastic/kibana/blob/7.17/x-pack/plugins/maps/server/saved_objects/maps_telemetry.ts

@afharo afharo added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Telemetry Feature:Saved Objects Feature:Migrations migration-resilience Issues related to migration resilience in terms of scale, performance & backwards compatibility labels Aug 24, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@petrklapka petrklapka added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese
Copy link
Contributor

nreese commented Jan 18, 2023

Resolved in #149102

@nreese nreese added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jan 26, 2023
@nreese
Copy link
Contributor

nreese commented Feb 9, 2023

closing, #149102 has merged.

@nreese nreese closed this as completed Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Maps Feature:Migrations Feature:Saved Objects Feature:Telemetry impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. migration-resilience Issues related to migration resilience in terms of scale, performance & backwards compatibility Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants