-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release @kbn/handlebars to npm #150522
Comments
Pinging @elastic/kibana-security (Team:Security) |
I would also be interested in seeing if Handlebars would accept these improvements upstream as a runtime option: handlebars-lang/handlebars.js#1934 |
Any update on this? |
Thank you so much for doing this. We use this in our MV3 extension yomitan (no eval is allowed). It'd be great if you could package this, as it'd make our build process much cleaner. (FWIW, I think it's more ideal for us as a fork, as the eval is clearly eliminated from the codebase that way.) |
@elastic/kibana-operations what is the best way for us to proceed? Changing the namespace to One-off publishing may be easy enough to accomplish, but having a dedicated workflow to follow would be best for long-term sustainability & security. |
We don't, it's not supported under the current packaging workflow. The remaining elastic namespace packages were removed in #138957. The recommendation is to split the package out into a new repository. |
For those looking, I created a kibana fork to publish |
I think it would be a great idea to release our version of the
handlebars
(currently named@kbn/handlebars
) to npm under the name@elastic/handlebars
.The reasons are:
I often hear that we don't want to release a piece of code to npm because it gives us an extra maintenance burden. However, I think this is completely wrong because:
So as I see it, the upsides of releasing this to npm far outweighs the theoretical downsides.
The text was updated successfully, but these errors were encountered: