Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tag cloud visualization test #16383

Closed
cjcenizal opened this issue Jan 30, 2018 · 4 comments
Closed

Flaky tag cloud visualization test #16383

cjcenizal opened this issue Jan 30, 2018 · 4 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Tagcloud Tag cloud visualization feature Feature:Visualizations Generic visualization features (in case no more specific feature label is available) test

Comments

@cjcenizal
Copy link
Contributor

I commented out a flaky tag cloud visualization test here: https://github.com/elastic/kibana/pull/16375/files#diff-ff18d990982d2404d8d04c0bc1b022a7R64.

This is passing for me locally but on a couple occasions it would fail on the CI. Stacktrace:

        { Error: expected [ '',
  '21,474,836,480',
  '20,401,094,656',
  '19,327,352,832',
  '18,253,611,008' ] to sort of equal [ '32,212,254,720',
  '21,474,836,480',
  '20,401,094,656',
  '19,327,352,832',
  '18,253,611,008' ]
    at Assertion.assert (node_modules/expect.js/index.js:96:13)
    at Assertion.eql (node_modules/expect.js/index.js:230:10)
    at Context.<anonymous> (test/functional/apps/visualize/_tag_cloud.js:62:40)
    at undefined.next (native)
    at step (test/functional/apps/visualize/_tag_cloud.js:181:191)
    at test/functional/apps/visualize/_tag_cloud.js:181:361
    at process._tickDomainCallback (internal/process/next_tick.js:135:7)

  actual: '[\n  ""\n  "21,474,836,480"\n  "20,401,094,656"\n  "19,327,352,832"\n  "18,253,611,008"\n]',
  expected: '[\n  "32,212,254,720"\n  "21,474,836,480"\n  "20,401,094,656"\n  "19,327,352,832"\n  "18,253,611,008"\n]',
  showDiff: true }

CC @elastic/kibana-visualizations

@cjcenizal cjcenizal added bug Fixes for quality problems that affect the customer experience test Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Tagcloud Tag cloud visualization feature labels Jan 30, 2018
@ppisljar
Copy link
Member

i am guessing it has to do with screen size and one tag not being displayed ?

@thomasneirynck
Copy link
Contributor

Seems to not occur. We also have new screenshot comparison tests now iso comparing individual svg-properties (cf. #15779)

@LeeDr
Copy link
Contributor

LeeDr commented Jul 2, 2018

@thomasneirynck I think you closed this PR but left the test skipped? Was that your intention? I have another PR to update the syntax of these tests and I'm un-skipping it there (we'll see if it passes for me).

@thomasneirynck
Copy link
Contributor

@LeeDr I believe https://github.com/elastic/kibana/pull/15779/files replaced the test with screenshot comparisons iso. reading the SVG contents.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Tagcloud Tag cloud visualization feature Feature:Visualizations Generic visualization features (in case no more specific feature label is available) test
Projects
None yet
Development

No branches or pull requests

4 participants