Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: simple syntax highlighting for timelion #17112

Closed
SolomonShorser-OICR opened this issue Mar 12, 2018 · 2 comments
Closed

Feature Request: simple syntax highlighting for timelion #17112

SolomonShorser-OICR opened this issue Mar 12, 2018 · 2 comments
Labels
Feature:Timelion Timelion app and visualization release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@SolomonShorser-OICR
Copy link

Feature Request

Sometimes working with Timelion can involve several series that have some complex queries. After a while, complex queries get hard to read.

It would be nice if there were some sort of simple syntax highlighting to make it easier for the eye to pick out different parts of a Timelion query. There's a Timelion tutorial here: https://www.timroes.de/2017/08/02/timelion-tutorial-from-zero-to-hero/ that has syntax highlighting, although I think it's a more generic highlighter. Timelion could benefit from more specific highlighting (in addition to more generic highlighting that would help distinguish strings from numbers from keywords...). Timelion-specific highlighting I was thinking of could be different classes of functions highlighted in different colours.
Example: functions that calculate derivative could highlight differently than functions that affect the visual display such as colour, bars/lines, etc...

@timroes timroes added release_note:enhancement Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Mar 13, 2018
@timroes
Copy link
Contributor

timroes commented Mar 13, 2018

Actually a duplicate of #12075, but since you added a better description (and of course linked to my blog ;D) I will leave this one open.

The syntax highlighting for timelion is actually a timelion "specific" one I wrote for highlight.js (https://github.com/timroes/www.timroes.de/blob/master/gulp/rendering/languages/timelion.js).
Though highlight.js cannot be used for input fields. I still find the general idea nice, to have a specific syntax highlighter. I think since we have a long running effort to maybe have a better code editor in EUI (elastic/eui#499) I would wait for any progress or outlook there, before we look into writing some syntax highlighting.

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Sep 16, 2018
@stratoula
Copy link
Contributor

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Timelion Timelion app and visualization release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants