Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSVB] Add markdown CSS tests #180074

Open
markov00 opened this issue Apr 4, 2024 · 1 comment
Open

[TSVB] Add markdown CSS tests #180074

markov00 opened this issue Apr 4, 2024 · 1 comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@markov00
Copy link
Member

markov00 commented Apr 4, 2024 •
edited
Loading

After some regressions resulting from the following PR (that tries to get rid of multiple markdown implementations in Kibana) I believe we should add some minimal smoke tests to catch possible changes in the markdown capabilities that TSVB currently have.

What should tested in FT is:

  • open links in new tabs
  • application of various CSS styles
  • check the DOM elements used to rendered MD elements (because CSS selectors can be tied to specific tags is better to check if the same markdown heading 1 renders as h1, heading 2 as h2 etc. Not an exhaustive list, but general things could be tested
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 4, 2024
@markov00 markov00 added Feature:TSVB TSVB (Time Series Visual Builder) and removed needs-team Issues missing a team label labels Apr 4, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 4, 2024
@markov00 markov00 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Apr 4, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Apr 4, 2024
@markov00 markov00 added technical debt Improvement of the software architecture and operational architecture impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:TSVB TSVB (Time Series Visual Builder) impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markov00 @elasticmachine