Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add saved object tags to SLOs to enable consistent filtering #180727

Open
rayafratkina opened this issue Apr 12, 2024 · 9 comments
Open

Add saved object tags to SLOs to enable consistent filtering #180727

rayafratkina opened this issue Apr 12, 2024 · 9 comments
Assignees
Labels
Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@rayafratkina
Copy link
Contributor

Describe the feature:
Saved object tagging has been available for a while and is proving to be useful as a way to filter objects created to make related objects easier to find.

In the course of working with Serverless observability, we found that it's really hard to find SLOs that our team has created without the tags. Can we please add tags to SLOs?

See #85741 for tagging rollout stragglers

@botelastic botelastic bot added the needs-team Issues missing a team label label Apr 12, 2024
@rayafratkina rayafratkina added Team:Observability Team label for Observability Team (for things that are handled across all of observability) and removed needs-team Issues missing a team label labels Apr 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/unified-observability (Team:Observability)

@rayafratkina rayafratkina added the Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) label Apr 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@rayafratkina
Copy link
Contributor Author

cc @smith

@vadimkibana
Copy link
Contributor

@elastic/unified-observability are SLOs in Kibana saved objects? If yes, then the tagging should work for them, it would be only a UI work to expose it to the end users.

@kdelemme
Copy link
Contributor

we found that it's really hard to find SLOs that our team has created without the tags.

Are you searching for the SLO in the saved object management page directly? Why?

@afharo
Copy link
Member

afharo commented Apr 18, 2024

@rayafratkina, don't SLOs have tags already?

https://overview.elastic-cloud.com/app/observability/slos?search=(filters:!(),groupBy:ungrouped,kqlQuery:%27slo.tags%20:%20%22kibana%22%20%27,lastRefresh:1713450453156,page:0,perPage:25,sort:(by:status,direction:desc),view:cardView)

Are you talking about anything else?

It's worth highlighting that they are internal tags (not the core-native tags).

@kdelemme
Copy link
Contributor

I'd like to understand better the need for surfacing the tags on the SO directly.

They are currently internal because we should not attempt to find SLO through the saved objects directly. We have an API that abstract the internal storage model (SO) for anyone to use. If something is missing on the API, we could improve it instead of accessing directly the internal storage model. If you want to find this from backend, we might need to introduce a client from our slo plugin.
But I might have some missing information as to why we wants to have the SLO SavedObjects searchable. Happy to chat :)

@rayafratkina
Copy link
Contributor Author

The issue is consistency for the end users - as we use SLOs, we want to tag them along with other artifacts (saved searches, dashboards, etc) and today we have to create a second parallel set of tags.
There are also small discrepancies in how the SO vs custom tags work, which makes it a bad user experience overall.

@kdelemme
Copy link
Contributor

It would help me understand the need if you can give me an example of what we are trying to achieve by tagging the SLO saved objects.

Do we want to use the Kibana Tags in order to show the SLO saved objects under the Stack Management > Tags UI knowing that we cannot export/import/edit a SLO saved object?

image

Let's chat next week if you are available, so we can go through it. I'll send you an invite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Observability Team label for Observability Team (for things that are handled across all of observability) Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Development

No branches or pull requests

5 participants