Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ES|QL] Use references instead of global variables in the editor #189029

Closed
stratoula opened this issue Jul 24, 2024 · 1 comment · Fixed by #188898
Closed

[ES|QL] Use references instead of global variables in the editor #189029

stratoula opened this issue Jul 24, 2024 · 1 comment · Fixed by #188898
Labels
Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana technical debt Improvement of the software architecture and operational architecture

Comments

@stratoula
Copy link
Contributor

Describe the feature:

This is a tech dept task. We could use references instead of global variables in the editor https://github.com/elastic/kibana/blob/main/packages/kbn-text-based-editor/src/text_based_languages_editor.tsx#L142

The UI refactoring #188898 is going to make the code simpler so we can do this as a follow up task.
@stratoula stratoula added Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Jul 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@stratoula stratoula added technical debt Improvement of the software architecture and operational architecture impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jul 24, 2024
This was referenced Jul 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:ES|QL ES|QL related features in Kibana impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:ESQL ES|QL related features in Kibana technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ES|QL] Increase discoverability stratoula/kibana
2 participants
@elasticmachine @stratoula