Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports cannot be generated using ultra long urls #20037

Closed
stacey-gammon opened this issue Jun 19, 2018 · 3 comments · Fixed by #45603
Closed

Reports cannot be generated using ultra long urls #20037

stacey-gammon opened this issue Jun 19, 2018 · 3 comments · Fixed by #45603
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead

Comments

@stacey-gammon
Copy link
Contributor

You can use Kibana with super long URLs using the storeStateInSessionStorage but reports won't work because they use the fully qualified url in order to pass all the information to the server.

If we implemented #14455 then we'd have a work around and it should work for reports generated in view mode (reporting should arguably only be available in view mode anyway, since the object has to be saved and it shows up as it would in view mode).

@stacey-gammon stacey-gammon added bug Fixes for quality problems that affect the customer experience :Sharing (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Jun 19, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure PR sent :Sharing labels Sep 13, 2018
@timroes timroes added Team:Stack Services and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 18, 2019
@tsullivan
Copy link
Member

You can use Kibana with super long URLs using the storeStateInSessionStorage but reports won't work because they use the fully qualified url in order to pass all the information to the server.

We're going to take this on as a short term task. The plan will be to use the same jobParams data and include it in a POST payload rather than the query string. The API will be able to work either way, but the UI will always include the jobParams as a field of POST payload data.

@stacey-gammon @kobelb Do either of you have recollection of any reasons why the POST URL for report generation has worked by including jobParams in the query string, rather than POST payload? Was it a Watcher limitation?

My thinking is that it happened accidentally because it wouldn't have been a problem with the original implementation, that parsed SavedObject data from Type and ID.

@kobelb
Copy link
Contributor

kobelb commented Sep 13, 2019

Do either of you have recollection of any reasons why the POST URL for report generation has worked by including jobParams in the query string, rather than POST payload?

It was mostly precedent... It always bothered me, and I really wanted to change it, but I never got around to it.

@tsullivan
Copy link
Member

We had some difficulty tracking various issues on this that are actually all the same problem.

I'm closing this as a duplicate of the more-visible #27728

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants