Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactify & Redesign Account Management Screen #30844

Closed
legrego opened this issue Feb 12, 2019 · 6 comments · Fixed by #30977
Closed

Reactify & Redesign Account Management Screen #30844

legrego opened this issue Feb 12, 2019 · 6 comments · Fixed by #30977
Assignees
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@legrego
Copy link
Member

legrego commented Feb 12, 2019

The account management page should be converted from angular to React/EUI. As part of this effort, the new page should support:

  • Optionally showing "Change Password" functionality if the current account supports this.
  • Optionally showing "Token Management" functionality if the Token service is enabled in Elasticsearch.
  • Optionally showing "API Key Management" functionality if the API Key feature is enabled in Elasticsearch. (see also, API Key Management #25729)
  • Should be designed in a way to support user preferences, which aren't available yet, but could be in the future.

To start the conversation, here's a quick mockup I did:
image

image

Code for mockup above is here: https://github.com/legrego/kibana/tree/security/reactify-account-screen

Once it gets closer and we agree an an overall approach, I'll open a PR from that branch.

Design team, I pinged you so you were aware of this. I welcome as much involvement as you're willing to give, but don't want to force any of this on you. There's no rush on my end, this is just a "downtime" side project of mine.

@legrego legrego added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! labels Feb 12, 2019
@legrego legrego self-assigned this Feb 12, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@cchaos
Copy link
Contributor

cchaos commented Feb 12, 2019

I'm so glad someone finally recognized this page needs help 😄

I think you have a good start, but I think we can combine the two areas into one panel and just always display the change password form even if they don't use it. There's no real necessity to hiding it.

Here's an idea:

account mgmt

@legrego
Copy link
Member Author

legrego commented Feb 13, 2019

I like it!

Here's an updated sample:
image

What do you think we should do for accounts where password change isn't an option? The old form shows a message explaining that password change is not available for this account. This was a recent enhancement...before, we would always show the change password form, even if the account didn't support it. I copied the message over from the old form, but it's repetitive with the description at the moment:

image

@cchaos
Copy link
Contributor

cchaos commented Feb 13, 2019

I would honestly just leave the right column empty and let the left column describe that it cannot be changed.

@legrego
Copy link
Member Author

legrego commented Feb 13, 2019

That works for me!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants