Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollups] Support selection of calendar or fixed interval in date histogram agg #36306

Closed
Tracked by #179200
jen-huang opened this issue May 8, 2019 · 5 comments
Closed
Tracked by #179200
Labels
enhancement New value added to drive a business result Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@jen-huang
Copy link
Contributor

Describe the feature:

Support changes in elastic/elasticsearch#33727, specifically for rollups.

ES UI tasks

  • In Rollup Jobs wizard, allow users to choose calendar or fixed for their date histogram configuration.
    • This selection should only appear if their input would otherwise be treated as calendar.
    • For example, 1h would have previously been treated as a calendar unit, so ask the user if they want to treat it as a calendar or fixed interval, and write it to calendar_interval or fixed_interval based on their choice.
    • On the other hand, 2h is always treated as a fixed interval, so do not offer user the choice between units and just write it to fixed_interval.

Examples of resulting rollup job date histogram configurations:

Calendar:

delay: "1d"
calendar_interval: "1h"
time_zone: "UTC"

Fixed:

delay: "1d"
fixed_interval: "1h"
time_zone: "UTC"

Coerced (user didn't specify an interval type, so 1h is treated as calendar). We should continue supporting this for BWC, but new rollup jobs created with the revised Rollup Jobs Wizard should not have this format:

delay: "1d"
interval: "1h"
time_zone: "UTC"

Kibana App tasks

  • Make sure that rollup index patterns created from a rollup index that has calendar_interval or fixed_interval in date histo aggs has the same information written to its typeMeta field
  • Branch the logic of related visualization date histgram interval input based on the existence of either calendar_interval, fixed_interval, or interval. Some relevant files:
  • Consider matching query with the field specified on the rollup job. For example, if the configuration is fixed_interval: "1h" and user inputs 1d, send fixed_interval: "1d" to the rollup search endpoint (instead of interval: "1d").
    • Some investigation should be done before implementing this. Per @polyfractal, sending mixed inputs (interval: "1d" in this case) should work, but we should think about what the user is going to want/expect when they query rollup docs.
@jen-huang jen-huang added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Rollups labels May 8, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@cjcenizal
Copy link
Contributor

Relates to #27410

@cjcenizal
Copy link
Contributor

cjcenizal commented May 8, 2019

Note that when we make this change we'll also have to update the Rollup API integration tests so that they use rollup job payloads that mirror those produced by the UI.

@timductive
Copy link
Member

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@timductive timductive closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants