Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Accessibility) - ES Management (high-level multiple issues) #43842

Closed
barlowm opened this issue Aug 23, 2019 · 4 comments · Fixed by #45024
Closed

(Accessibility) - ES Management (high-level multiple issues) #43842

barlowm opened this issue Aug 23, 2019 · 4 comments · Fixed by #45024
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@barlowm
Copy link
Collaborator

barlowm commented Aug 23, 2019

ES Management

Index management

  1. The only table on the page is missing a caption -

    1.3.1 Info and Relationships - Level A
    Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text

Index_Management_Table

  1. Rows are missing scope to identify individual cells while navigating randomly through the table with screen reader

Index_Management_Table_Scope_Row

  1. Checkboxes missing labels (no label, aria-label, or aria-describedby)

CheckboxMissingLabel-1

CheckboxMissingLabel-2

CheckboxMissingLabel-3

1.3.1 Info and Relationships - Level A
Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text
3.3.2 Labels or Instructions - Level A
Labels or instructions are provided when content requires user input.

  1. "Lifecycle status" button could use additional screen-reader assistance (SC reads it as just as "Lifecycle status button" but doesn't explain that clicking it can be used as a filter to change to show "Managed" and/or "Unmanaged" items in the table ). The control is a "button" but acts like a "select"
    3.2.4 Consistent Identification - Level AA

Combo-BadExample-1

Combo-BadExample-2

Combo-WorkingExample-1

Combo-WorkingExample-2

  1. "Lifecycle phase" button could use additional screen-reader assistance (SC reads it as just as "Lifecycle phase button" but doesn't explain that clicking it can be used as a filter to change to show "Hot", "Warm", "Cold", "Delete" items in the table ). The control is a "button" but acts like a "select"

  2. Clicking an item brings the item detail fly-out with invalid list (Show phase definition is a non list item button, displayed as a link). The "Show phase definition" XXX is a direct child of the list but is not a list element

InvalidList-3

InvalidList-1a

InvalidList-2

1.3.1 Info and Relationships - Level A
H40: Using Definition Lists
H48: Using ol, ul and dl for lists or groups of links

Index lifecycle policies

  1. Table missing caption - 1.3.1 Info and Relationships - Level A
    Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text

Index_Policies_Table

  1. Rows missing scope to identify individual cells while navigating with screen reader

Index_Policies_Table_Scope_Row

Rollup jobs

  1. Select fields are missing labels

RollupMissingLabel_1

There is a label for the div that contains the 2 select fields but not for the individual fields themselves

RollupMissingLabel_4

  [3.3.2 Labels or Instructions](https://www.w3.org/WAI/WCAG21/quickref/?versions=2.0#labels-or-instructions) - Level A

Labels or instructions are provided when content requires user input.

  1. The
    "Terms (Optional)" table in step 3
    "Histogram (optional)" table of step 4
    "Metrics (optional)" table of step 5

    of creating a rollup job are missing captions -

Terms_Table

Histogram_Table

Metrics_Table

1.3.1 Info and Relationships - Level A
Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text

  1. Rows are missing scope to identify individual cells while navigating randomly through the table with screen reader

    "Terms (Optional)" table in step 3

Terms_Table_Scope_Row

"Histogram (optional)" table of step 4

Histogram_Table_Scope_Row

"Metrics (optional)" table of step 5

Metrics_Table_Scope_Row

  1. "Review Details for..." Rollup Job has an invalid list
    RollupList_3

RollupList_1

RollupList_2

-1.3.1 Info and Relationships - Level A
Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text

@jen-huang
Copy link
Contributor

@barlowm Thank you for filing such a comprehensive report! I was trying to label this with all the teams and features that are affected, but the list was getting extremely crowded as it's not one team that owns everything under Management. Would you mind creating separate issues for each area that have issues? That way the issues are assignable and actionable on a per-team basis. Thank you!

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Meta labels Aug 30, 2019
@rayafratkina
Copy link
Contributor

rayafratkina commented Aug 30, 2019

Split off

This issues covers just ES management findings

@rayafratkina rayafratkina added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Aug 30, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@rayafratkina rayafratkina changed the title (Accessibility) - Management (high-level multiple issues) (Accessibility) - ES Management (high-level multiple issues) Aug 30, 2019
@cjcenizal cjcenizal removed the Meta label Aug 30, 2019
@alisonelizabeth alisonelizabeth self-assigned this Sep 5, 2019
@alisonelizabeth
Copy link
Contributor

@barlowm thanks for opening this! I'm working through these issues now.

I had a couple questions/comments regarding your notes:

The
"Terms (Optional)" table in step 3
"Histogram (optional)" table of step 4
"Metrics (optional)" table of step 5

of creating a rollup job are missing captions -

These tables all appear to have caption elements. Is there something else I'm missing?

Screen Shot 2019-09-06 at 11 52 56 AM

Screen Shot 2019-09-06 at 11 53 38 AM

Screen Shot 2019-09-06 at 11 54 02 AM

"Lifecycle status" button could use additional screen-reader assistance (SC reads it as just as "Lifecycle status button" but doesn't explain that clicking it can be used as a filter to change to show "Managed" and/or "Unmanaged" items in the table ). The control is a "button" but acts like a "select"

"Lifecycle phase" button could use additional screen-reader assistance (SC reads it as just as "Lifecycle phase button" but doesn't explain that clicking it can be used as a filter to change to show "Hot", "Warm", "Cold", "Delete" items in the table ). The control is a "button" but acts like a "select"

Both of these use the <EuiContextMenu/> component from the EUI framework and I think any accessibility concerns would be best addressed within the component itself. I see there is already an issue opened regarding this as well: elastic/eui#1585.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:Accessibility Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants