Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] logging.events doesn't appear in reference documentation #46204

Closed
matschaffer opened this issue Sep 20, 2019 · 8 comments
Closed

[DOCS] logging.events doesn't appear in reference documentation #46204

matschaffer opened this issue Sep 20, 2019 · 8 comments
Labels
Team:Docs Team:Operations Team label for Operations Team

Comments

@matschaffer
Copy link
Contributor

matschaffer commented Sep 20, 2019

https://github.com/elastic/kibana/blob/master/docs/migration/migrate_8_0.asciidoc#responses-are-never-logged-by-default mentions using logging.events.response to ensure all responses get logged, but it doesn't appear in https://github.com/elastic/kibana/blob/master/docs/setup/settings.asciidoc

Would be good to add detail about how that config value should be set to ensure it's being used it correctly.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs

@tylersmalley tylersmalley added the Team:Operations Team label for Operations Team label Sep 20, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@spalger
Copy link
Contributor

spalger commented Sep 20, 2019

I wonder if this isn't an @elastic/kibana-platform concern. The logging infrastructure is in the platform and we have a new config format for logging that I think we still plan to implement when the new platform is primarily in charge of things server-side.

I've personally always seen logging.events as an implementation detail of good, and is not a user friendly interface by any definition, but is exposed for people who need fine control over what is/isn't logged.

Perhaps it would be better to add a new config option to enable response logging which would modify the logging.events config created by settings like logging.quiet.

@jbudz
Copy link
Member

jbudz commented Sep 20, 2019

+1 to spalger, I'd push for a log level abstraction

@mshustov
Copy link
Contributor

Perhaps it would be better to add a new config option to enable response logging which would modify the logging.events config created by settings like logging.quiet.

as a side note: when we migrate to NP logging config
https://github.com/elastic/kibana/blob/master/src/core/server/logging/README.md in #41956
and should be able to achieve the same without adding new CLI / config options

loggers:
  - context: httpService.response // just an example, not sure about path correctness 
    level: trace

@spalger
Copy link
Contributor

spalger commented Sep 23, 2019

when we migrate to NP logging config and should be able to achieve the same without adding new CLI / config options

That's what I was hoping to hear, thanks!

@KOTungseth
Copy link
Contributor

@spalger could you clarify on what setting needs to be added to the docs? I can work on this next week, I just need some more details.

@KOTungseth
Copy link
Contributor

Since logging.events is an internal implementation detail that we expose for last resort stuff, we are not going to document it. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Docs Team:Operations Team label for Operations Team
Projects
None yet
Development

No branches or pull requests

7 participants