Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ops metrics to New Platform #46563

Closed
mshustov opened this issue Sep 25, 2019 · 5 comments · Fixed by #58623
Closed

Migrate ops metrics to New Platform #46563

mshustov opened this issue Sep 25, 2019 · 5 comments · Fixed by #58623
Assignees
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

Being consumed by legacy platform and monitoring plugin. Move to a separate NP plugin or to the core service

@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Sep 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@chrisronline
Copy link
Contributor

This is the exact data we need from a combination of getOSInfo() and the stats collector:

{
  "concurrent_connections": 0,
  "os": {
    "load": {
      "1m": 3.69140625,
      "5m": 3.794921875,
      "15m": 3.390625
    },
    "memory": {
      "total_in_bytes": 34359738368,
      "free_in_bytes": 359890944,
      "used_in_bytes": 33999847424
    },
    "uptime_in_millis": 1133261000,
    "platform": "darwin",
    "platformRelease": "darwin-19.3.0"
  },
  "process": {
    "event_loop_delay": 0.630875825881958,
    "memory": {
      "heap": {
        "total_in_bytes": 447537152,
        "used_in_bytes": 309079552,
        "size_limit": 8564343922
      },
      "resident_set_size_in_bytes": 765067264
    },
    "uptime_in_millis": 100870
  },
  "requests": {
    "disconnects": 0,
    "total": 0
  },
  "response_times": {
    "average": 0,
    "max": 0
  }
}

@pgayvallet
Copy link
Contributor

pgayvallet commented Feb 26, 2020

@chrisronline On which extends the data structure must remains exactly the same as what we had before?

I would really like to take this NP migration as an opportunity to cleanup / restructure the raw output format a little bit.

More specifically, I was thinking on merging the response_times, requests and concurrent_connections root properties under a new server global section, to be more consistent with the os and process sections (which also simplifies the per-section gatherer we might develop to stop using oppsy).

Would that be acceptable to you / would you be able to convert back to the stats endpoint expected format, or would that be really bothersome to you? Note that we will now have TS typings to back us up, so this would be easier to convert than the current untyped TS implementation.

@chrisronline
Copy link
Contributor

I don't have a strong opinion either way I guess, but if we're changing the structure within the monitoring document itself, that would be a breaking change and we'd have to wait for a major to do that. We should probably keep it consistent for now, and work on changing the structure for 8.0. WDYT?

@pgayvallet
Copy link
Contributor

I'll keep it that way in #58623 for now then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants