Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/core/server vs kibana/server #58712

Closed
jloleysens opened this issue Feb 27, 2020 · 1 comment
Closed

src/core/server vs kibana/server #58712

jloleysens opened this issue Feb 27, 2020 · 1 comment

Comments

@jloleysens
Copy link
Contributor

The same as 👆🏻works for src/core/public and kibana/public. In both cases we are able to import types only. If something like the kibanaResponseFactory is imported that path needs to specify the full relative prefix to the location of the server or public folder otherwise a module not found error prevents Kibana from starting.

  1. Are we planning on collapsing these aliases into one? (why have two ways of doing the same thing)
  2. Should we be importing "concerete" things like kibanaResponseFactory from core as described above?
@lizozom
Copy link
Contributor

lizozom commented Feb 27, 2020

There's an ongoing discussion about this here and work ongoing here.

At the moment, indeed, importing from absolute paths is supported for types only, but the answer to both of your questions is yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants