Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type vis event so we can safely use it in embeddable and render functions #62972

Closed
Dosant opened this issue Apr 8, 2020 · 2 comments
Closed

Type vis event so we can safely use it in embeddable and render functions #62972

Dosant opened this issue Apr 8, 2020 · 2 comments
Labels
Feature:Embedding Embedding content via iFrame Feature:Visualizations Generic visualization features (in case no more specific feature label is available) technical debt Improvement of the software architecture and operational architecture

Comments

@Dosant
Copy link
Contributor

Dosant commented Apr 8, 2020 •
edited
Loading

Make sure that the event function is properly types. Since we (at least for now) know all the events coming through, we'll create full typings for the event parameter so we can in the render functions and inside the embeddable and other consuming places have full type safeness for them.

https://github.com/elastic/kibana/blob/master/src/plugins/embeddable/public/lib/triggers/triggers.ts#L32

#62214 (comment)
@Dosant Dosant added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) technical debt Improvement of the software architecture and operational architecture Team:AppArch labels Apr 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant added the Feature:Embedding Embedding content via iFrame label Apr 8, 2020
@Dosant Dosant mentioned this issue Apr 8, 2020
Merged
7 tasks
@Dosant
Copy link
Contributor Author

Dosant commented Oct 8, 2020

This was done in multiple iterations.
as of 7.10 original link is pointing to typed code :D https://github.com/elastic/kibana/blob/master/src/plugins/embeddable/public/lib/triggers/triggers.ts#L32

@Dosant Dosant closed this as completed Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Embedding Embedding content via iFrame Feature:Visualizations Generic visualization features (in case no more specific feature label is available) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Dosant @elasticmachine