Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KP] Remove deprecated CoreSetup API #68747

Closed
mshustov opened this issue Jun 10, 2020 · 3 comments
Closed

[KP] Remove deprecated CoreSetup API #68747

mshustov opened this issue Jun 10, 2020 · 3 comments
Labels
Meta Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

There are different reasons why the Kibana platform provides deprecated API: to alleviate migration process, legacy API leftovers, experimental API sunsetting, etc.
We are targeting v8.0 release to stabilize the KP API, so it can be considered as a soft deadline to remove deprecated API usage to reduce maintenance burden.
List of plugins using deprecated API in table format

As a part of #66366
I added to deprecated in favour of start contact counterparts:

  • savedObjects.getImportExportObjectLimit
  • uuid.getInstanceUuid
  • status
  • metrics

I will mark them as deprecated in a dedicated PR. Any objections?

Other services that we might deprecate in favour of start contract counterparts (should be investigated in #66366):

  • HTTP service API:
    • client-side: fetch, delete, get, head, options, patch, post, put, addLoadingCountSource, getLoadingCount$
    • server: auth
  • Notifications.toasts
  • UiSettings client side
@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Meta labels Jun 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor

uuid.getInstanceUuid

I feel like it could make sense to need to access this one during the setup phase?

Other services that we might deprecate in favour of start contract counterparts

I think the list makes sense.

@mshustov mshustov changed the title [KP] Remove deprecated API [KP] Remove deprecated CoreSetup API Nov 3, 2020
@pgayvallet
Copy link
Contributor

Most of those deprecated setup APIs were taken care of, the few remaining are listed in more recent "remove deprecations" issues.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Meta Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
Status: Done (7.13)
Development

No branches or pull requests

3 participants