Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] [Code Coverage] Fail build on code coverage ingestion error #69168

Closed
wayneseymour opened this issue Jun 15, 2020 · 0 comments · Fixed by #69198
Closed

[QA] [Code Coverage] Fail build on code coverage ingestion error #69168

wayneseymour opened this issue Jun 15, 2020 · 0 comments · Fixed by #69198
Assignees
@wayneseymour
Labels
release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.0.0

Comments

@wayneseymour
Copy link
Member

Describe the feature:
Fail the build on coverage ingestion and slack notify the qa team
Describe a specific use case for the feature:
Currently we have a case in ci, where given a failed ingestion marks the build as unstable, but we want it to be red, so that we know to fix it.
@wayneseymour wayneseymour added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage labels Jun 15, 2020
@wayneseymour wayneseymour self-assigned this Jun 15, 2020
@wayneseymour wayneseymour mentioned this issue Jun 15, 2020
Merged
@wayneseymour wayneseymour linked a pull request Jun 15, 2020 that will close this issue
[QA][Code Coverage] Drop catchError and use try / catch instead, #69198
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wayneseymour wayneseymour

Labels
release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[QA][Code Coverage] Drop catchError and use try / catch instead, elastic/kibana
1 participant
@wayneseymour