Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Can't delete columns with long unbroken labels #69452

Closed
wylieconlon opened this issue Jun 17, 2020 · 2 comments · Fixed by #69495
Closed

[Lens] Can't delete columns with long unbroken labels #69452

wylieconlon opened this issue Jun 17, 2020 · 2 comments · Fixed by #69495
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

This bug can be reproduced using any long label, such as this field name from the .monitoring index:

Screenshot 2020-06-17 16 56 46

The fix for this bug is either to:

  • Set a max-width on the dimension trigger component, so that the delete button is visible
  • Put the delete button on top of the dimension trigger component
  • Use a more aggressive breaking style in CSS, such as break-word.
  • Handle dotted paths with a special case that inserts <wbr> tags which are soft-breaks.

I don't actually have a strong preference on these, but maybe @cchaos does?

@wylieconlon wylieconlon added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@cchaos
Copy link
Contributor

cchaos commented Jun 17, 2020

We simply need to add a max-width to the popover anchor that takes into account the size of the delete icon. It can just let long field names get cutoff and we should be sure to add the whole configuration name into the title property.

Screen Shot 2020-06-17 at 17 19 32 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants