Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] No horizontal spacing in layer settings panel #70123

Closed
thomasneirynck opened this issue Jun 26, 2020 · 2 comments · Fixed by #70188
Closed

[Maps] No horizontal spacing in layer settings panel #70123

thomasneirynck opened this issue Jun 26, 2020 · 2 comments · Fixed by #70188
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.9.0 v8.0.0

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Jun 26, 2020 •
edited
Loading

Spacing is missing between rows

image
@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.9.0 labels Jun 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@nreese
Copy link
Contributor

nreese commented Jun 29, 2020

Regression caused by #64018. That PR changed ValidatedDualRange component from returning EuiFormRow to returning <div><EuiFormRow></EuiFormRow></div>. This messed up the spacing since EuiFormRow are no longer siblings in the form

Screen Shot 2020-06-28 at 8 37 54 PM

@nreese nreese self-assigned this Jun 29, 2020
@nreese nreese mentioned this issue Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove no longer required div wrapper around ValidatedDualRange nreese/kibana
3 participants
@nreese @thomasneirynck @elasticmachine