Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Filters] Warning filters in non default index pattern dashboard #72601

Closed
majagrubic opened this issue Jul 21, 2020 · 14 comments · Fixed by #72899
Closed

[Dashboard][Filters] Warning filters in non default index pattern dashboard #72601

majagrubic opened this issue Jul 21, 2020 · 14 comments · Fixed by #72899
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Filters impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@majagrubic
Copy link
Contributor

majagrubic commented Jul 21, 2020

Kibana version:
7.9 BC2

Can't reproduce in master.

Original install method (e.g. download page, yum, from source, etc.):
Cloud and docker OSS

Describe the bug:

Non default index pattern dashboard shows filters in "warning" state, when navigated to it without full page reload.

Narrowed down to this steps:

  1. Go to dashboard with non default index pattern
  2. Add any filter and pin it
  3. go away from a dashboard, e.g. listing page
  4. go back

Current behaviour : filter is in warning state and not applied

Expected behaviour: filter shouldn't be in warning state and should be applied

Additional context:

  • For some reason filter bar thinks that current index pattern is Kibana's default one, but not the one from dashboard.
  • This happens not only to pinned filtes, but also to local filters saved with dashboard. Or local filter coming from URL
  • New warning state was added it Add error if filter index pattern is missing #66979
  • Can't reproduce in master, In master first "warning" state is shown, but then it changes to active filter.

Screenshots (if relevant):

Screenshot 2020-07-22 at 10 17 12

@majagrubic majagrubic added Team:Visualizations Visualization editors, elastic-charts and infrastructure bug Fixes for quality problems that affect the customer experience labels Jul 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@majagrubic majagrubic added Feature:SharingURLs Short URLs and Share URL features Feature:Dashboard Dashboard related features labels Jul 21, 2020
@flash1293
Copy link
Contributor

flash1293 commented Jul 21, 2020

@majagrubic Are you sure this is related to sharing? I can't reproduce this via your description, but I noticed the filter pill in your example is a pinned one - if there is no visualization associated with the index pattern of the filter pill in the dashboard, it shows the same "warning" filter pill for me like this:

  • Create a filter based on some index pattern somewhere
  • Pin it
  • Go to dashboard where no visualization is related to the index pattern
  • Filter is shown as Warning

@flash1293
Copy link
Contributor

flash1293 commented Jul 21, 2020

I also get into this state like this:

  • Save a dashboard (dashboard A) with a local filter pill using the index pattern associated with visualizations on the dashboard
  • Go to another dashboard using exclusively another index pattern
  • Create a filter pill and pin it
  • Go back to dashboard A
  • The pinned filter pill works, but the local one (using the "right" index pattern used in visualizations as well) is broken

Almost as if the filter bar is only ever working with a single index pattern at a time and all filter pills using other index patterns break.

@Dosant do you have an idea here? Seems at least partially filter bar related.

@Dosant
Copy link
Contributor

Dosant commented Jul 21, 2020

@flash1293, there was this change #66979

Almost as if the filter bar is only ever working with a single index pattern at a time and all filter pills using other index patterns break.

This doesn't sound right to me...

@flash1293
Copy link
Contributor

@Dosant Thanks for that, wasn't aware the warning is shown if the filter is not applicable. Still, the second example I posted shouldn't happen, right?

@Dosant
Copy link
Contributor

Dosant commented Jul 21, 2020

@flash1293,

Still, the second example I posted shouldn't happen, right?

Right, doesn't sound right to me.
I'll also do some testing on this

The pinned filter pill works, but the local one (using the "right" index pattern used in visualizations as well) is broken

By local you mean unpinned filter on a dashboard? Or inside visualization? Or inside embeddable panel?

@flash1293
Copy link
Contributor

flash1293 commented Jul 21, 2020

@Dosant Unpinned filter on dashboard, sorry.

A better description - it only seems to happen on second load:

  • Install flight and logs data
  • Go to logs dashboard
  • Add filter geo.src: IN
  • Save logs dashboard
  • Go to dashboard listing
  • Go to flight dashboard
  • Add filter FlightDelay: true
  • Pin FlightDelay filter
  • Go to dashboard listing
  • Go to logs dashboard
  • Both the FlightDelay and the geo.src filter pill are shown in warning state, geo.src switches to regular display after a split-second
  • Go back
  • Go forward
  • Both the FlightDelay and the geo.src filter pill are shown in warning state, geo.src does not switch to regular

Expected:

  • Only FlightDelay is shown in warning state

Couldn't reproduce on master, reloading the page fixes the problem, but navigating away from the dashboard and back to it breaks it again.

Even stranger: This only happens on the logs dashboard, on eCommerce it always works fine. No idea what the difference is

@Dosant
Copy link
Contributor

Dosant commented Jul 22, 2020

@flash1293,
I think it doesn't happen for you on eCommerce, because that is default index pattern for you. Is this the case?

@Dosant
Copy link
Contributor

Dosant commented Jul 22, 2020

Narrowed down to this steps:

  1. Go to dashboard with non default index pattern
  2. Add any filter and pin it
  3. go away from a dashboard, e.g. listing page
  4. go back

Current behaviour : filter is in warning state and not applied

Expected behaviour: filter shouldn't be in warning state and should be applied


For some reason filter bar thinks that current index pattern is Kibana's default one, but not the one from dashboard.

@Dosant Dosant added Feature:Filters impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant added Team:Visualizations Visualization editors, elastic-charts and infrastructure and removed Feature:SharingURLs Short URLs and Share URL features labels Jul 22, 2020
@Dosant Dosant changed the title [Dashboard] Sharing an embedded Dashboard destroys the filter [Dashboard][Filters] Warning filters in non default index pattern dashboard Jul 22, 2020
@flash1293
Copy link
Contributor

@Dosant I wiped that instance already, but it's very likely

@lizozom
Copy link
Contributor

lizozom commented Jul 22, 2020

@Dosant on 7.9 latest branch, I get the same behavior of seeing the warning, but it immediately switches to a normal state.

@flash1293
Copy link
Contributor

@lizozom Try going back to the listing page and then access the same dashboard again. Sometimes I had the same thing of the Warning label just flickering, but the second time it always stayed for me.

@Dosant
Copy link
Contributor

Dosant commented Jul 28, 2020

Created a follow up issue to address initial flickering: #73286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Feature:Filters impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants