Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint violations for ES UI JSON editor #73971

Closed
cjcenizal opened this issue Jul 31, 2020 · 1 comment · Fixed by #76392
Closed

Fix eslint violations for ES UI JSON editor #73971

cjcenizal opened this issue Jul 31, 2020 · 1 comment · Fixed by #76392
Assignees
Labels
chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cjcenizal
Copy link
Contributor

Supports #49554

kibana/src/plugins/es_ui_shared/public/components/json_editor/json_editor.tsx
  55:33  error  React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead                                                                                                                                                     react-hooks/exhaustive-deps
  79:7   error  React Hook useCallback has missing dependencies: 'debouncedSetContent' and 'onUpdate'. Either include them or remove the dependency array. If 'onUpdate' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps

kibana/src/plugins/es_ui_shared/public/components/json_editor/use_json.ts
  87:6  error  React Hook useEffect has missing dependencies: 'formatContent', 'isControlled', 'onUpdate', and 'validate'. Either include them or remove the dependency array. If 'onUpdate' changes too often, find the parent component that defines it and wrap that definition in useCallback  react-hooks/exhaustive-deps
@cjcenizal cjcenizal added chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jul 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants