Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observability overview: news article links should render with the external icon #74223

Closed
ogupte opened this issue Aug 4, 2020 · 4 comments · Fixed by #77164
Closed

Observability overview: news article links should render with the external icon #74223

ogupte opened this issue Aug 4, 2020 · 4 comments · Fixed by #77164
Assignees
@cauemarcondes
Labels
bug Fixes for quality problems that affect the customer experience Feature:Observability Landing good first issue low hanging fruit low hanging fruit DO NOT USE. Use `good first issue` instead Team:APM All issues that need APM UI Team support v7.10.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Aug 4, 2020 •
edited
Loading

It's not obvious that clicking the links the full news articles in observability overview will open in a new tab. This can be fixed by using the external prop of the EuiLink component.

Screen Shot 2020-08-04 at 1.39.29 AM.png
@ogupte ogupte added 7.10.0 Feature:Observability Landing Team:APM All issues that need APM UI Team support labels Aug 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@ogupte ogupte added v7.10 and removed v7.10 labels Aug 4, 2020
@cauemarcondes
Copy link
Contributor

@formgeist What do you think? Should we fix it for 7.9?

@formgeist
Copy link
Contributor

@cauemarcondes @ogupte I think it's fine to make this improvement in 7.10 when we'd also want to add an example image with the article examples, which I see is not present.

@cauemarcondes
Copy link
Contributor

cauemarcondes commented Aug 4, 2020 •
edited
Loading

example image with the article examples

@formgeist the image will be available when the article has one, the image field is optional.

@formgeist formgeist changed the title Observability overview news article links should render with the external icon Observability overview: Resources and news article links should render with the external icon Aug 4, 2020
@cauemarcondes cauemarcondes mentioned this issue Aug 4, 2020
Closed
@ogupte ogupte changed the title Observability overview: Resources and news article links should render with the external icon Observability overview: news article links should render with the external icon Aug 5, 2020
@ogupte ogupte added 7.9.0 bug Fixes for quality problems that affect the customer experience and removed [zube]: Inbox labels Aug 5, 2020
@sorenlouv sorenlouv added low hanging fruit DO NOT USE. Use `good first issue` instead good first issue low hanging fruit labels Sep 8, 2020
@cauemarcondes cauemarcondes mentioned this issue Sep 10, 2020
Merged
@zube zube bot added the [zube]: Done label Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cauemarcondes cauemarcondes

Labels
bug Fixes for quality problems that affect the customer experience Feature:Observability Landing good first issue low hanging fruit low hanging fruit DO NOT USE. Use `good first issue` instead Team:APM All issues that need APM UI Team support v7.10.0
Projects
None yet
Milestone
No milestone
5 participants
@sorenlouv @ogupte @formgeist @elasticmachine @cauemarcondes