EUI labels not translating

[zumo64]

Kibana version:
verified in 7.6.1

Elasticsearch version:

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:

"Show Dates" (core.euiSuperDatePicker.showDatesButtonLabel) and the associated "Refresh" button (see screenshot attached) are not translated when using Kibana with a different locale.

Expected behavior:
Translation for these 2 labels should apply.

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

[elasticmachine]

Pinging @elastic/kibana-core-ui (Team:Core UI)

[zumo64]

Hi @Bamieh do you have any update for this issue ?

[elasticmachine]

Pinging @elastic/eui-design (EUI)

[chandlerprall]

Confirmed this is also an issue on the master branch. I updated the default message in

kibana/src/core/public/i18n/i18n_eui_mapping.tsx

Line 489 in 1cdbd60

defaultMessage: 'Show dates',

and confirmed that renders as expected, so there is something missing in Kibana which is preventing the translation values from propagating through.

Inspecting the component tree, it appears the PseudoLocaleWrapper is not providing the translated values to EuiContext.

[pgayvallet]

Cannot reproduce on current master, both labels are correctly translated when switching to zh-CN

Dashboard

Discover

@Bamieh are you aware of any changes that could have fixed that on the past year?

[Bamieh]

@pgayvallet The tracker issue we have for this is Add test for eui tokens coverage.

This part of the UI gets internationalized and de-internationalized from version to version. At the moment it is working but probably within a few releases some changes will break it again.

We need to add tests to make sure we have full eui tokens i18n coverage in our eui mappings file (https://github.com/elastic/kibana/blob/master/src/core/public/i18n/i18n_eui_mapping.tsx)

This means we need to expose the tokens in eui first then grab that file in a unit test and make sure we have all the labels in the object.

Right now EUI package build process (yarn build) begins by executing yarn extract-i18n-strings, which generates i18ntokens.json. To better coordinate that into the release, we can move that extract-i18n-strings command into scripts/compile-eui.js, which could then copy the result from src-docs/src/i18ntokens.json into the dist directory, which should include it in the npm package.

[afharo]

I've created elastic/eui#4771 so @elastic/eui publishes i18ntokens.json in their NPM package. Once it's published, and Kibana is updated to that version, I'll follow up with the changes in Kibana to validate that we are not missing any keys :)

[afharo]

The PR to upgrade @elastic/eui to the version containing i18ntokens.json is #99382. When that's merged, I'll follow up with adding the tests.

[afharo]

Status update: The PR #99613 adds the tests and corrects any mismatches, but it's blocked by the works in #99382, dealing with the changes required in Kibana to upgrade @elastic/eui to v33.0.0. Once #99382 is merged, we can rebase #99613 and submit it for review.