Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsed visualize play button taking full width #7810

Closed
jbudz opened this issue Jul 22, 2016 · 3 comments
Closed

Collapsed visualize play button taking full width #7810

jbudz opened this issue Jul 22, 2016 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@jbudz
Copy link
Member

jbudz commented Jul 22, 2016

image

@jbudz jbudz changed the title IE11 visualize play button taking full width Collapsed visualize play button taking full width Jul 22, 2016
@jbudz jbudz added bug Fixes for quality problems that affect the customer experience P2 labels Jul 22, 2016
@thomasneirynck
Copy link
Contributor

The stretching of the buttons is due to a media query being applied when the mode changing from wide-screen to mobile version.

Not sure what the buttons "should" look like in the mobile version. That said though, we might want the buttons to stretch to full width, it gives it more of that "smart-phone" feel.

Note that the fix for #7808 fixes this issue, if we want the buttons to have the "stretch" behavior.

However, there is a larger issue with the CSS. The nav.navbar class, which forces a height of 70px to align the header with the Kibana logo, seems applied too liberally. Any (sub)component that applies it, is stretched to at least 70px. This includes the visualization headers. We should move that rule so it only applies to the header on top of the page, not all headers of all (sub)components.

@thomasneirynck
Copy link
Contributor

headers

example of header of visualization-form being too big.

@thomasneirynck
Copy link
Contributor

For now, we want to retain the button expansion behavior, since it works a little better for small screen mobile layouts.

The overlap is due to a CSS issue that was addressed in #7850.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

No branches or pull requests

2 participants