Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GS] Observability apps do not appear in initial result set for nav search #78174

Closed
ryankeairns opened this issue Sep 22, 2020 · 5 comments · Fixed by #78741
Closed

[GS] Observability apps do not appear in initial result set for nav search #78174

ryankeairns opened this issue Sep 22, 2020 · 5 comments · Fixed by #78741
Assignees
Labels
bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented Sep 22, 2020

@tbragin pointed out that the Observability apps (APM, Metrics, Logs, and Uptime) are not appearing in the initial result set. This was not intentional and, as a side note, they do appear as you type.

Initial results

As this is alphabetical, APM should appear first.

Screen Shot 2020-09-22 at 11 25 47 AM

Upon typing

Screen Shot 2020-09-22 at 11 26 05 AM

cc:/ @myasonik @alexfrancoeur

@ryankeairns ryankeairns added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc REASSIGN from Team:Core UI Deprecated label for old Core UI team labels Sep 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@alexfrancoeur alexfrancoeur added the bug Fixes for quality problems that affect the customer experience label Sep 22, 2020
@ryankeairns
Copy link
Contributor Author

@pgayvallet Please increase the max results limit to at least 30. I just did a quick count and came up with 27, so maybe it should be even higher (35 or 40?). From the time we defined the original limit, Security essentially moved their page nav into the side bar and Ent Search has been added to Kibana. I realize this is arbitrary and perhaps another issue should be created to track how we future proof this. Thanks!

For reference, here is the line of code you shared in the the thread:

const defaultMaxProviderResults = 20;

@cyrille-leclerc
Copy link
Contributor

Thanks @ryankeairns and @pgayvallet for following up on this request.

@tbragin
Copy link
Contributor

tbragin commented Oct 5, 2020

@pgayvallet @ryankeairns Thank you for moving quickly to address this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience REASSIGN from Team:Core UI Deprecated label for old Core UI team Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants