Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved input editor for Timelion #8881

Closed
rcrezende opened this issue Oct 28, 2016 · 9 comments
Closed

Improved input editor for Timelion #8881

rcrezende opened this issue Oct 28, 2016 · 9 comments
Assignees
Labels
blocked Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@rcrezende
Copy link

rcrezende commented Oct 28, 2016

Allowing multi-line and indentation would dramatically increase readability in Timelion expressions.
The way I'd love to see is the following:

(
    .es(timefield=timestamp, metric=cardinality:somefield.keyword)
    .label("Nice Label")
    .bars()
    .yaxis(yaxis=1,label="First Axis"),

    .es(timefield=timestamp, metric=sum:anotherfield)
    .divide(12)
    .label("Another Lable")
    .yaxis(yaxis=2, label="Secondary Axis")
)
.title("Graph Title")
.legend("ne")

Also, when editing a timeline visualization in Kibana, the left panel is too small and I'm forced to edit the expression in another editor and paste there. Maybe allowing the user to resize the split Editor/Visualization is ideal.

Syntax highlighting would also be very welcome

@tbragin tbragin added release_note:enhancement Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Oct 29, 2016
@tbragin
Copy link
Contributor

tbragin commented Nov 14, 2016

For historical purposes, there is some relevant discussion on an old Timelion issue: elastic/timelion#31

@ddavidebor
Copy link

Excellent someone brought this back!
I looked at this issue time ago, and the most suited multiline editor i could find is https://codemirror.net/

JS syntax highlighting matches fairly well Timelion expressions.

@rcrezende
Copy link
Author

maybe this: https://microsoft.github.io/monaco-editor/ ?

@ddavidebor
Copy link

@rcrezende it does not work on mobile

@tbragin tbragin added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Feb 14, 2017
@tbragin
Copy link
Contributor

tbragin commented Feb 14, 2017

@cjcenizal Curious if this is still something on your radar? If not, maybe we can chat about something more tactical we can do here.

@tbragin tbragin added the P2 label Feb 14, 2017
@cjcenizal
Copy link
Contributor

cjcenizal commented Feb 14, 2017

I haven't spent any more time on this beyond the initial UX exploration (https://codepen.io/cjcenizal/pen/vgGXzZ). If someone wants to dedicate time to building this I think it would be great!

@ddavidebor
Copy link

Timelion is still screaming for help to improve it's input!

@epixa
Copy link
Contributor

epixa commented Apr 10, 2017

Blocked on #10961

@cjcenizal
Copy link
Contributor

The request for multiline queries has been addressed by #11972. I've created #12075 and #12077 to capture the requests for syntax highlighting and a better side panel, respectively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Timelion Timelion app and visualization Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

No branches or pull requests

5 participants