Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time To Visualize] Extract Index Patterns from By Value Panels #89765

Closed
ThomThomson opened this issue Jan 29, 2021 · 3 comments
Closed

[Time To Visualize] Extract Index Patterns from By Value Panels #89765

ThomThomson opened this issue Jan 29, 2021 · 3 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Problem

currently, index pattern references from 'by value' panels on a dashboard are not extracted properly into the dashboard itself. Drilldown dashboard references are extracted this way, so likely something similar needs to be done.

Relationship explorer for a dashboard with a by value panel that has a drilldown:
Screen Shot 2021-01-29 at 12 46 20 PM

The index pattern from that panel should also be propagated.

@ThomThomson ThomThomson added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:TimeToVisualize labels Jan 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@crob611 crob611 self-assigned this Feb 9, 2021
@kmartastic
Copy link
Contributor

@crob611 @ThomThomson -- I'm sorry, I don't understand the issue reading the problem statement above. Can you clarify for me?

@crob611
Copy link
Contributor

crob611 commented Mar 2, 2021

@kmartastic This was fixed by #91567 but I'll summarize it for you. Before TimeToVisualize, a dashboard panels were all backed by saved objects. This made it easy when saving a dashboard to know the other saved objects that it referenced.

With TimeToVisualize, now the panels are not backed by a saved object, but they could still be referencing saved objects, such as an index pattern. The point of this issue was to make sure that dashboard was appropriately extracting these references that are not as obvious as the panel by reference scenario.

@crob611 crob611 closed this as completed Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants