Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard Quicksave Exits Edit Mode #91343

Closed
ThomThomson opened this issue Feb 14, 2021 · 2 comments
Closed

Dashboard Quicksave Exits Edit Mode #91343

ThomThomson opened this issue Feb 14, 2021 · 2 comments
Labels
Feature:Dashboard Dashboard related features Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Feb 14, 2021 •
edited
Loading

Issue

Change quicksave to not boot users out of edit mode and add a loading state to quicksave button to prevent spam.

See discussion here:
#90320

Open Questions

Should the normal save function stay in edit mode, or switch to view mode?
Should the save modal have a 'return to view mode' switch?
Should the Cancel button be renamed 'finish' to better communicate the idea that users may click it after saving to go back into view mode?
@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:TimeToVisualize labels Feb 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson ThomThomson changed the title Dashboard Quicksave Exits Edit mode Dashboard Quicksave Should not Exit Edit Mode Feb 14, 2021
@ThomThomson ThomThomson changed the title Dashboard Quicksave Should not Exit Edit Mode Dashboard Quicksave Exits Edit Mode Feb 14, 2021
@ThomThomson
Copy link
Contributor Author

fixed by #91729

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThomThomson @elasticmachine