Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry] Remove uses of any in the Telemetry & Usage Collection plugins and libraries #93183

Closed
7 of 8 tasks
afharo opened this issue Mar 2, 2021 · 4 comments
Closed
7 of 8 tasks
Labels
chore Feature:Telemetry good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture

Comments

@afharo
Copy link
Member

afharo commented Mar 2, 2021

Let's remove (or minimize as much as possible) the use of any from all the code related to Telemetry and Usage Collection plugins:

Once a path is completed, let's add the rule "@typescript-eslint/no-explicit-any": "error" in .eslintrc.js

@afharo afharo added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Telemetry labels Mar 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@afharo afharo added the technical debt Improvement of the software architecture and operational architecture label Mar 2, 2021
@Bamieh
Copy link
Member

Bamieh commented Mar 4, 2021

Just did a quick search for any against these folders. We have roughly 140 any types in total

@afharo afharo added the good first issue low hanging fruit label Mar 9, 2021
@pgayvallet
Copy link
Contributor

We have 48 occurences remaining in @kbn/telemetry-tools, however from a quick look, those are not necesseraly trivial to address given it's mostly AST related functions and types that are abusing those any.

Given the "let's remove all the any from our codebase" always has been on a best-effort basis, and given those are only build-time tools, I'm leaning toward closing this issue as completed, wdyt @afharo?

@afharo
Copy link
Member Author

afharo commented Jul 10, 2024

I agree! That tool kind of needs those any. Closing!

@afharo afharo closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Telemetry good first issue low hanging fruit Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc technical debt Improvement of the software architecture and operational architecture
Projects
Status: Done (7.13)
Development

No branches or pull requests

4 participants