Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Migrate to ScopedHistory router #96134

Closed
joshdover opened this issue Apr 2, 2021 · 3 comments · Fixed by #106267
Closed

[Fleet] Migrate to ScopedHistory router #96134

joshdover opened this issue Apr 2, 2021 · 3 comments · Fixed by #106267
Assignees
Labels
Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@joshdover
Copy link
Contributor

Fleet is currently using it's own hash-based router on the frontend, which is not actually supported by Core's ApplicationService. There are number of routing bugs that come from using the hash-based router, but it also blocks #86171.

An example of how this router should be hooked up can be found here: https://github.com/elastic/kibana/blob/master/docs/development/core/public/kibana-plugin-core-public.appmountparameters.history.md

It appears that Fleet is using two routers? A hash-based one inside of the one hooked up to Core's provided history instance. I'm not sure of the motivation for doing this? Location in Fleet where the hash router is used: https://github.com/elastic/kibana/blob/master/x-pack/plugins/fleet/public/applications/fleet/app.tsx#L207

@joshdover joshdover added bug Fixes for quality problems that affect the customer experience Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@jfsiii
Copy link
Contributor

jfsiii commented Apr 2, 2021

cc @paul-tavares bc I know you have experience here. I'm curious if you have any guess about the level of effort to replace? It's not your responsibility, I just know you've had a few go rounds with our routing.

@jen-huang jen-huang added technical debt Improvement of the software architecture and operational architecture and removed bug Fixes for quality problems that affect the customer experience labels Apr 26, 2021
@jen-huang jen-huang changed the title Migrate fleet to ScopedHistory router [Fleet] Migrate to ScopedHistory router Apr 27, 2021
@nchaulet nchaulet self-assigned this Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants