Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover][New table] Improve document selection #99775

Closed
Tracked by #166238
kertal opened this issue May 11, 2021 · 2 comments
Closed
Tracked by #166238

[Discover][New table] Improve document selection #99775

kertal opened this issue May 11, 2021 · 2 comments
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@kertal
Copy link
Member

kertal commented May 11, 2021

When selecting documents in the new table we currently select and filter only in UI, based on the records that are fetched from ES (this is usually a sample of max 500 documents).

It works like the classic table in this case, when you expand a document, change the time range so it is no longer in between this range, the document is no longer displayed.

Once a user selects documents, those should not vanish just because those documents were selected at the start of 1500 records and after inverting the sorting they are no longer available.

The desired behavior should be: When the user selects a doc, clicks on "Show selected documents only", those docs should be displayed even if the user changes the time range or filters in the meantime, also sorting should work in this case.

Bildschirmfoto 2021-05-04 um 14 44 32

To achieve this behavior we need to change architecture. When Show selected documents only is selected, this should trigger a request to ES using the ids of the selected docs with same sorting like in the complete table. Since there can be multiple records with the same id in a set of documents, so we need to add an additional filter client side, to show only the documents the user selected.

@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 11, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal added Feature:Discover Discover Application enhancement New value added to drive a business result labels May 11, 2021
@timroes timroes added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@kertal kertal added loe:large Large Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jan 31, 2023
@kertal
Copy link
Member Author

kertal commented Nov 6, 2023

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2023
@kertal kertal added the Icebox label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Development

No branches or pull requests

3 participants