From 3f3d30fe4801ef0fa9f9586a5833419703aca6f4 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Mon, 8 Apr 2024 17:50:19 -0700 Subject: [PATCH 01/33] Upgrade EUI to v94.1.0 --- package.json | 2 +- src/dev/license_checker/config.ts | 2 +- yarn.lock | 170 ++++++++++++++++-------------- 3 files changed, 92 insertions(+), 82 deletions(-) diff --git a/package.json b/package.json index f980721107057d..346bd231bc1f27 100644 --- a/package.json +++ b/package.json @@ -107,7 +107,7 @@ "@elastic/ecs": "^8.11.1", "@elastic/elasticsearch": "^8.13.0", "@elastic/ems-client": "8.5.1", - "@elastic/eui": "93.6.0", + "@elastic/eui": "94.1.0", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "1.2.1", "@elastic/numeral": "^2.5.1", diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index e0e4b2f1376fac..a0c6e784aa61ca 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -86,7 +86,7 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.5.1': ['Elastic License 2.0'], - '@elastic/eui@93.6.0': ['SSPL-1.0 OR Elastic License 2.0'], + '@elastic/eui@94.1.0': ['SSPL-1.0 OR Elastic License 2.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry 'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary '@bufbuild/protobuf@1.2.1': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause) diff --git a/yarn.lock b/yarn.lock index 4f591d2da0689c..eb7a42a0f0f8f5 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1752,10 +1752,10 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui@93.6.0": - version "93.6.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-93.6.0.tgz#9a5892164a4457ba0382a76b63731eeed10dfb89" - integrity sha512-o6TEgSE+mOJmZYtMm+xYMeFQoOcoGTQOMWwRBCkP1efEPAlqjeBnUeahco8jKM3kqTeah+jMLm/A02ZjRwU+GA== +"@elastic/eui@94.1.0": + version "94.1.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-94.1.0.tgz#39fea7dc983206ccc9917fc912631b8947ca68ca" + integrity sha512-93OujrKqgK5UvzRjy/+7cVx6s4Xq8SjDqCsqZvct4aQAkVLrFZhO8tVoYJrTds5bvz6Pb2LCe2HR90U1LlHHGw== dependencies: "@hello-pangea/dnd" "^16.3.0" "@types/lodash" "^4.14.202" @@ -12725,21 +12725,23 @@ bn.js@^5.0.0, bn.js@^5.2.1: resolved "https://registry.yarnpkg.com/bn.js/-/bn.js-5.2.1.tgz#0bc527a6a0d18d0aa8d5b0538ce4a77dccfa7b70" integrity sha512-eXRvHzWyYPBuB4NBy0cmYQjGitUrtqwbvlzP3G6VFnNRbsZQIxQ10PbKKHt8gZ/HW/D/747aDl+QkDqg3KQLMQ== -body-parser@1.19.2: - version "1.19.2" - resolved "https://registry.yarnpkg.com/body-parser/-/body-parser-1.19.2.tgz#4714ccd9c157d44797b8b5607d72c0b89952f26e" - integrity sha512-SAAwOxgoCKMGs9uUAUFHygfLAyaniaoun6I8mFY9pRAJL9+Kec34aU+oIjDhTycub1jozEfEwx1W1IuOYxVSFw== +body-parser@1.20.2: + version "1.20.2" + resolved "https://registry.yarnpkg.com/body-parser/-/body-parser-1.20.2.tgz#6feb0e21c4724d06de7ff38da36dad4f57a747fd" + integrity sha512-ml9pReCu3M61kGlqoTm2umSXTlRTuGTx0bfYj+uIUKKYycG5NtSbeetV3faSU6R7ajOPw0g/J1PvK4qNy7s5bA== dependencies: bytes "3.1.2" - content-type "~1.0.4" + content-type "~1.0.5" debug "2.6.9" - depd "~1.1.2" - http-errors "1.8.1" + depd "2.0.0" + destroy "1.2.0" + http-errors "2.0.0" iconv-lite "0.4.24" - on-finished "~2.3.0" - qs "6.9.7" - raw-body "2.4.3" + on-finished "2.4.1" + qs "6.11.0" + raw-body "2.5.2" type-is "~1.6.18" + unpipe "1.0.0" bonjour-service@^1.0.11: version "1.0.13" @@ -14134,10 +14136,10 @@ content-security-policy-parser@^0.6.0: resolved "https://registry.yarnpkg.com/content-security-policy-parser/-/content-security-policy-parser-0.6.0.tgz#b361d8587dee0e92def19d308cb23e8d32cc26f6" integrity sha512-wejtC/p+HLNQ7uaWgg1o3CKHhE8QXC9fJ2GCY0X82L5HUNtZSq1dmUvNSHHEb6R7LS02fpmRBq/vP8i4/+9KCg== -content-type@~1.0.4: - version "1.0.4" - resolved "https://registry.yarnpkg.com/content-type/-/content-type-1.0.4.tgz#e138cc75e040c727b1966fe5e5f8c9aee256fe3b" - integrity sha512-hIP3EEPs8tB9AT1L+NUqtwOAps4mk2Zob89MWXMHjHWg9milF/j4osnnQLXBCBFBk/tvIG/tUc9mOUJiPBhPXA== +content-type@~1.0.4, content-type@~1.0.5: + version "1.0.5" + resolved "https://registry.yarnpkg.com/content-type/-/content-type-1.0.5.tgz#8b773162656d1d1086784c8f23a54ce6d73d7918" + integrity sha512-nTjqfcBFEipKdXCv4YDQWCfmcLZKm81ldF0pAopTvyrFGVbcR6P/VAAd5G7N+0tTr8QqiU0tFadD6FK4NtJwOA== convert-source-map@^1.4.0, convert-source-map@^1.5.0, convert-source-map@^1.5.1, convert-source-map@^1.6.0, convert-source-map@^1.7.0: version "1.8.0" @@ -14156,21 +14158,16 @@ cookie-signature@1.0.6: resolved "https://registry.yarnpkg.com/cookie-signature/-/cookie-signature-1.0.6.tgz#e303a882b342cc3ee8ca513a79999734dab3ae2c" integrity sha1-4wOogrNCzD7oylE6eZmXNNqzriw= -cookie@0.4.2: - version "0.4.2" - resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.4.2.tgz#0e41f24de5ecf317947c82fc789e06a884824432" - integrity sha512-aSWTXFzaKWkvHO1Ny/s+ePFpvKsPnjc551iI41v3ny/ow6tBG5Vd+FuqGNhh1LxOmVzOlGUriIlOaokOvhaStA== +cookie@0.6.0, cookie@^0.6.0: + version "0.6.0" + resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.6.0.tgz#2798b04b071b0ecbff0dbb62a505a8efa4e19051" + integrity sha512-U71cyTamuh1CRNCfpGY6to28lxvNwPG4Guz/EVjgf3Jmzv0vlDp1atT9eS5dDjMYHucpHbWns6Lwf3BKz6svdw== cookie@^0.5.0: version "0.5.0" resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.5.0.tgz#d1f5d71adec6558c58f389987c366aa47e994f8b" integrity sha512-YZ3GUyn/o8gfKJlnlX7g7xq4gyO6OSuhGPKaaGssGB2qgDUS0gPgtTvoyZLTt9Ab6dC4hfc9dV5arkvc/OCmrw== -cookie@^0.6.0: - version "0.6.0" - resolved "https://registry.yarnpkg.com/cookie/-/cookie-0.6.0.tgz#2798b04b071b0ecbff0dbb62a505a8efa4e19051" - integrity sha512-U71cyTamuh1CRNCfpGY6to28lxvNwPG4Guz/EVjgf3Jmzv0vlDp1atT9eS5dDjMYHucpHbWns6Lwf3BKz6svdw== - cookiejar@^2.1.4: version "2.1.4" resolved "https://registry.yarnpkg.com/cookiejar/-/cookiejar-2.1.4.tgz#ee669c1fea2cf42dc31585469d193fef0d65771b" @@ -15337,6 +15334,11 @@ delegates@^1.0.0: resolved "https://registry.yarnpkg.com/delegates/-/delegates-1.0.0.tgz#84c6e159b81904fdca59a0ef44cd870d31250f9a" integrity sha1-hMbhWbgZBP3KWaDvRM2HDTElD5o= +depd@2.0.0: + version "2.0.0" + resolved "https://registry.yarnpkg.com/depd/-/depd-2.0.0.tgz#b696163cc757560d09cf22cc8fad1571b79e76df" + integrity sha512-g7nH6P6dyDioJogAAGprGpCtVImJhpPk/roCzdb3fIh61/s/nPsfR6onyMwkCAR/OlC3yBC0lESvUoQEAssIrw== + depd@^1.1.2, depd@~1.1.2: version "1.1.2" resolved "https://registry.yarnpkg.com/depd/-/depd-1.1.2.tgz#9bcd52e14c097763e749b274c4346ed2e560b5a9" @@ -15385,10 +15387,10 @@ des.js@^1.0.0: inherits "^2.0.1" minimalistic-assert "^1.0.0" -destroy@~1.0.4: - version "1.0.4" - resolved "https://registry.yarnpkg.com/destroy/-/destroy-1.0.4.tgz#978857442c44749e4206613e37946205826abd80" - integrity sha1-l4hXRCxEdJ5CBmE+N5RiBYJqvYA= +destroy@1.2.0: + version "1.2.0" + resolved "https://registry.yarnpkg.com/destroy/-/destroy-1.2.0.tgz#4803735509ad8be552934c67df614f94e66fa015" + integrity sha512-2sJGJTaXIIaR1w4iJSNoN0hnMY7Gpc/n8D4qSCJw8QqFWXf7cuAgnEHxBpweaVcPevC2l3KpjYCx3NypQQgaJg== detab@2.0.4: version "2.0.4" @@ -17037,31 +17039,32 @@ express@^4.17.1, express@^4.17.3: dependencies: accepts "~1.3.8" array-flatten "1.1.1" - body-parser "1.19.2" + body-parser "1.20.2" content-disposition "0.5.4" content-type "~1.0.4" - cookie "0.4.2" + cookie "0.6.0" cookie-signature "1.0.6" debug "2.6.9" - depd "~1.1.2" + depd "2.0.0" encodeurl "~1.0.2" escape-html "~1.0.3" etag "~1.8.1" - finalhandler "~1.1.2" + finalhandler "1.2.0" fresh "0.5.2" + http-errors "2.0.0" merge-descriptors "1.0.1" methods "~1.1.2" - on-finished "~2.3.0" + on-finished "2.4.1" parseurl "~1.3.3" path-to-regexp "0.1.7" proxy-addr "~2.0.7" - qs "6.9.7" + qs "6.11.0" range-parser "~1.2.1" safe-buffer "5.2.1" - send "0.17.2" - serve-static "1.14.2" + send "0.18.0" + serve-static "1.15.0" setprototypeof "1.2.0" - statuses "~1.5.0" + statuses "2.0.1" type-is "~1.6.18" utils-merge "1.0.1" vary "~1.1.2" @@ -17424,17 +17427,17 @@ fill-range@^7.0.1: dependencies: to-regex-range "^5.0.1" -finalhandler@~1.1.2: - version "1.1.2" - resolved "https://registry.yarnpkg.com/finalhandler/-/finalhandler-1.1.2.tgz#b7e7d000ffd11938d0fdb053506f6ebabe9f587d" - integrity sha512-aAWcW57uxVNrQZqFXjITpW3sIUQmHGG3qSb9mUah9MgMC4NeWhNOlNjXEYq3HjRAvL6arUviZGGJsBg6z0zsWA== +finalhandler@1.2.0: + version "1.2.0" + resolved "https://registry.yarnpkg.com/finalhandler/-/finalhandler-1.2.0.tgz#7d23fe5731b207b4640e4fcd00aec1f9207a7b32" + integrity sha512-5uXcUVftlQMFnWC9qu/svkWv3GTd2PfUhK/3PLkYNAe7FbqJMt3515HaxE6eRL74GdsriiwujiawdaB1BpEISg== dependencies: debug "2.6.9" encodeurl "~1.0.2" escape-html "~1.0.3" - on-finished "~2.3.0" + on-finished "2.4.1" parseurl "~1.3.3" - statuses "~1.5.0" + statuses "2.0.1" unpipe "~1.0.0" find-cache-dir@^2.0.0, find-cache-dir@^2.1.0: @@ -19000,15 +19003,15 @@ http-deceiver@^1.2.7: resolved "https://registry.yarnpkg.com/http-deceiver/-/http-deceiver-1.2.7.tgz#fa7168944ab9a519d337cb0bec7284dc3e723d87" integrity sha1-+nFolEq5pRnTN8sL7HKE3D5yPYc= -http-errors@1.8.1: - version "1.8.1" - resolved "https://registry.yarnpkg.com/http-errors/-/http-errors-1.8.1.tgz#7c3f28577cbc8a207388455dbd62295ed07bd68c" - integrity sha512-Kpk9Sm7NmI+RHhnj6OIWDI1d6fIoFAtFt9RLaTMRlg/8w49juAStsrBgp0Dp4OdxdVbRIeKhtCUvoi/RuAhO4g== +http-errors@2.0.0: + version "2.0.0" + resolved "https://registry.yarnpkg.com/http-errors/-/http-errors-2.0.0.tgz#b7774a1486ef73cf7667ac9ae0858c012c57b9d3" + integrity sha512-FtwrG/euBzaEjYeRqOgly7G0qviiXoJWnvEH2Z1plBdXgbyjv34pHTSb9zoeHMyDy33+DWy5Wt9Wo+TURtOYSQ== dependencies: - depd "~1.1.2" + depd "2.0.0" inherits "2.0.4" setprototypeof "1.2.0" - statuses ">= 1.5.0 < 2" + statuses "2.0.1" toidentifier "1.0.1" http-errors@~1.6.2: @@ -23895,10 +23898,10 @@ on-exit-leak-free@^2.1.0: resolved "https://registry.yarnpkg.com/on-exit-leak-free/-/on-exit-leak-free-2.1.0.tgz#5c703c968f7e7f851885f6459bf8a8a57edc9cc4" integrity sha512-VuCaZZAjReZ3vUwgOB8LxAosIurDiAW0s13rI1YwmaP++jvcxP77AWoQvenZebpCA2m8WC1/EosPYPMjnRAp/w== -on-finished@~2.3.0: - version "2.3.0" - resolved "https://registry.yarnpkg.com/on-finished/-/on-finished-2.3.0.tgz#20f1336481b083cd75337992a16971aa2d906947" - integrity sha1-IPEzZIGwg811M3mSoWlxqi2QaUc= +on-finished@2.4.1: + version "2.4.1" + resolved "https://registry.yarnpkg.com/on-finished/-/on-finished-2.4.1.tgz#58c8c44116e54845ad57f14ab10b03533184ac3f" + integrity sha512-oVlzkg3ENAhCk2zdv7IJwd/QUD4z2RxRwpkcGY8psCVcCYZNq4wYnVWALHM+brtuJjePWiYF/ClmuDr8Ch5+kg== dependencies: ee-first "1.1.1" @@ -25634,10 +25637,12 @@ qs@6.10.4: dependencies: side-channel "^1.0.4" -qs@6.9.7: - version "6.9.7" - resolved "https://registry.yarnpkg.com/qs/-/qs-6.9.7.tgz#4610846871485e1e048f44ae3b94033f0e675afe" - integrity sha512-IhMFgUmuNpyRfxA90umL7ByLlgRXu6tIfKPpF5TmcfRLlLCckfP/g3IQmju6jjpu+Hh8rA+2p6A27ZSPOOHdKw== +qs@6.11.0: + version "6.11.0" + resolved "https://registry.yarnpkg.com/qs/-/qs-6.11.0.tgz#fd0d963446f7a65e1367e01abd85429453f0c37a" + integrity sha512-MvjoMCJwEarSbUYk5O+nmoSzSutSsTwF85zcHPQ9OrlFoZOYIjaqBAJIqIXjptyD5vThxGq52Xu/MaJzRkIk4Q== + dependencies: + side-channel "^1.0.4" qs@^6.10.0, qs@^6.11.0, qs@^6.7.0: version "6.11.2" @@ -25769,13 +25774,13 @@ range-parser@^1.2.1, range-parser@~1.2.1: resolved "https://registry.yarnpkg.com/range-parser/-/range-parser-1.2.1.tgz#3cf37023d199e1c24d1a55b84800c2f3e6468031" integrity sha512-Hrgsx+orqoygnmhFbKaHE6c296J+HTAQXoxEF6gNupROmmGJRoyzfG3ccAveqCBrwr/2yxQ5BVd/GTl5agOwSg== -raw-body@2.4.3: - version "2.4.3" - resolved "https://registry.yarnpkg.com/raw-body/-/raw-body-2.4.3.tgz#8f80305d11c2a0a545c2d9d89d7a0286fcead43c" - integrity sha512-UlTNLIcu0uzb4D2f4WltY6cVjLi+/jEN4lgEUj3E04tpMDpUlkBo/eSn6zou9hum2VMNpCCUone0O0WeJim07g== +raw-body@2.5.2: + version "2.5.2" + resolved "https://registry.yarnpkg.com/raw-body/-/raw-body-2.5.2.tgz#99febd83b90e08975087e8f1f9419a149366b68a" + integrity sha512-8zGqypfENjCIqGhgXToC8aB2r7YrBX+AQAfIPs/Mlk+BtPTztOvTS01NRW/3Eh60J+a48lt8qsCzirQ6loCVfA== dependencies: bytes "3.1.2" - http-errors "1.8.1" + http-errors "2.0.0" iconv-lite "0.4.24" unpipe "1.0.0" @@ -27711,24 +27716,24 @@ semver@^6.0.0, semver@^6.1.0, semver@^6.1.2, semver@^6.3.0, semver@^6.3.1: resolved "https://registry.yarnpkg.com/semver/-/semver-6.3.1.tgz#556d2ef8689146e46dcea4bfdd095f3434dffcb4" integrity sha512-BR7VvDCVHO+q2xBEWskxS6DJE1qRnb7DxzUrogb71CWoSficBxYsiAGd+Kl0mmq/MprG9yArRkyrQxTO6XjMzA== -send@0.17.2: - version "0.17.2" - resolved "https://registry.yarnpkg.com/send/-/send-0.17.2.tgz#926622f76601c41808012c8bf1688fe3906f7820" - integrity sha512-UJYB6wFSJE3G00nEivR5rgWp8c2xXvJ3OPWPhmuteU0IKj8nKbG3DrjiOmLwpnHGYWAVwA69zmTm++YG0Hmwww== +send@0.18.0: + version "0.18.0" + resolved "https://registry.yarnpkg.com/send/-/send-0.18.0.tgz#670167cc654b05f5aa4a767f9113bb371bc706be" + integrity sha512-qqWzuOjSFOuqPjFe4NOsMLafToQQwBSOEpS+FwEt3A2V3vKubTquT3vmLTQpFgMXp8AlFWFuP1qKaJZOtPpVXg== dependencies: debug "2.6.9" - depd "~1.1.2" - destroy "~1.0.4" + depd "2.0.0" + destroy "1.2.0" encodeurl "~1.0.2" escape-html "~1.0.3" etag "~1.8.1" fresh "0.5.2" - http-errors "1.8.1" + http-errors "2.0.0" mime "1.6.0" ms "2.1.3" - on-finished "~2.3.0" + on-finished "2.4.1" range-parser "~1.2.1" - statuses "~1.5.0" + statuses "2.0.1" serialize-javascript@6.0.0: version "6.0.0" @@ -27782,15 +27787,15 @@ serve-index@^1.9.1: mime-types "~2.1.17" parseurl "~1.3.2" -serve-static@1.14.2: - version "1.14.2" - resolved "https://registry.yarnpkg.com/serve-static/-/serve-static-1.14.2.tgz#722d6294b1d62626d41b43a013ece4598d292bfa" - integrity sha512-+TMNA9AFxUEGuC0z2mevogSnn9MXKb4fa7ngeRMJaaGv8vTwnIEkKi+QGvPt33HSnf8pRS+WGM0EbMtCJLKMBQ== +serve-static@1.15.0: + version "1.15.0" + resolved "https://registry.yarnpkg.com/serve-static/-/serve-static-1.15.0.tgz#faaef08cffe0a1a62f60cad0c4e513cff0ac9540" + integrity sha512-XGuRDNjXUijsUL0vl6nSD7cwURuzEgglbOaFuZM9g3kwDXOWVTck0jLzjPzGD+TazWbboZYu52/9/XPdUgne9g== dependencies: encodeurl "~1.0.2" escape-html "~1.0.3" parseurl "~1.3.3" - send "0.17.2" + send "0.18.0" set-blocking@^2.0.0: version "2.0.0" @@ -28659,7 +28664,12 @@ stats-lite@^2.2.0: dependencies: isnumber "~1.0.0" -"statuses@>= 1.4.0 < 2", "statuses@>= 1.5.0 < 2", statuses@~1.5.0: +statuses@2.0.1: + version "2.0.1" + resolved "https://registry.yarnpkg.com/statuses/-/statuses-2.0.1.tgz#55cb000ccf1d48728bd23c685a063998cf1a1b63" + integrity sha512-RwNA9Z/7PrK06rYLIzFMlaF+l73iwpzsqRIFgbMLbTcLD6cOao82TaWefPXQvB2fOC4AjuYSEndS7N/mTCbkdQ== + +"statuses@>= 1.4.0 < 2": version "1.5.0" resolved "https://registry.yarnpkg.com/statuses/-/statuses-1.5.0.tgz#161c7dac177659fd9811f43771fa99381478628c" integrity sha1-Fhx9rBd2Wf2YEfQ3cfqZOBR4Yow= From 1065a2019df3bc51c9bbdf09a618457fa05b8dee Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Mon, 8 Apr 2024 18:01:17 -0700 Subject: [PATCH 02/33] Convert `responsive` prop to new `responsiveBreakpoint` API - same `false` behavior, but more extensible if needed --- packages/kbn-text-based-editor/src/query_history.tsx | 2 +- .../src/components/field_stats/field_number_summary.tsx | 2 +- .../components/preview_panel/indices_list/indices_list.tsx | 2 +- .../no_results_suggestions/syntax_suggestions_popover.tsx | 1 - .../views/requests/components/details/req_details_stats.tsx | 2 +- .../components/drilldown_table/drilldown_table.tsx | 2 +- .../drilldown_template_table/drilldown_template_table.tsx | 2 +- .../public/components/doc_viewer_table/legacy/table.tsx | 2 +- .../public/components/doc_viewer_table/table.tsx | 2 +- .../field_types_filter/field_types_help_popover.tsx | 2 +- .../analytics/components/analytics_tables/analytics_table.tsx | 1 - .../components/analytics_tables/query_clicks_table.tsx | 1 - .../components/analytics_tables/recent_queries_table.tsx | 1 - .../components/api_logs/components/api_logs_table.tsx | 1 - .../components/curations/components/curations_table.tsx | 1 - .../components/curations/components/suggestions_table.tsx | 1 - .../result_settings_table/result_settings_table.tsx | 2 +- .../search_application/search_application_schema.tsx | 4 ++-- .../applications/shared/role_mapping/role_mappings_table.tsx | 2 +- .../components/shared/sources_table/sources_table.tsx | 2 +- .../views/groups/components/group_source_prioritization.tsx | 2 +- .../form_based/dimension_panel/dimension_editor.tsx | 2 +- .../components/advanced_detector_modal/function_help.tsx | 2 +- .../public/components/asset_details/tabs/metadata/table.tsx | 2 +- .../asset_details/tabs/processes/processes_table.tsx | 2 +- .../waterfall/waterfall_flyout/waterfall_flyout_table.tsx | 2 +- .../availability_reporting/availability_reporting.tsx | 2 +- .../waterfall/components/waterfall_flyout_table.tsx | 2 +- .../app/rum_dashboard/impactful_metrics/js_errors.tsx | 2 +- .../public/management/roles/roles_grid/roles_grid_page.tsx | 2 +- .../common/components/ml_popover/jobs_table/jobs_table.tsx | 2 +- .../components/entity_analytics_anomalies/index.tsx | 2 +- .../entity_analytics/components/risk_score_preview_table.tsx | 3 +-- .../components/risk_summary_flyout/risk_summary.tsx | 2 +- 34 files changed, 28 insertions(+), 36 deletions(-) diff --git a/packages/kbn-text-based-editor/src/query_history.tsx b/packages/kbn-text-based-editor/src/query_history.tsx index 2a5a5b05dc2c8b..aece1eb2f654fb 100644 --- a/packages/kbn-text-based-editor/src/query_history.tsx +++ b/packages/kbn-text-based-editor/src/query_history.tsx @@ -319,7 +319,7 @@ export function QueryHistory({ defaultMessage: 'Queries history table', } )} - responsive={false} + responsiveBreakpoint={false} items={historyItems} columns={columns} sorting={sorting} diff --git a/packages/kbn-unified-field-list/src/components/field_stats/field_number_summary.tsx b/packages/kbn-unified-field-list/src/components/field_stats/field_number_summary.tsx index 8e4cdc3d0ff882..5d573e926f5ba3 100755 --- a/packages/kbn-unified-field-list/src/components/field_stats/field_number_summary.tsx +++ b/packages/kbn-unified-field-list/src/components/field_stats/field_number_summary.tsx @@ -88,7 +88,7 @@ export const FieldNumberSummary: React.FC = ({ columns={summaryTableColumns} tableCaption={summaryTableTitle} data-test-subj={`${dataTestSubject}-numberSummary`} - responsive={false} + responsiveBreakpoint={false} css={css` & .euiTableHeaderCell { ${euiScreenReaderOnly()} diff --git a/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx b/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx index d7542a9e70184b..1cb5298911785b 100644 --- a/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx +++ b/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx @@ -218,7 +218,7 @@ export class IndicesList extends React.Component - + {rows} diff --git a/src/plugins/discover/public/application/main/components/no_results/no_results_suggestions/syntax_suggestions_popover.tsx b/src/plugins/discover/public/application/main/components/no_results/no_results_suggestions/syntax_suggestions_popover.tsx index 4e5e3ba3796cdf..3268d9193f1b8d 100644 --- a/src/plugins/discover/public/application/main/components/no_results/no_results_suggestions/syntax_suggestions_popover.tsx +++ b/src/plugins/discover/public/application/main/components/no_results/no_results_suggestions/syntax_suggestions_popover.tsx @@ -90,7 +90,6 @@ export const SyntaxSuggestionsPopover: React.FC = compressed={true} rowHeader="label" columns={columns} - responsive /> diff --git a/src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx b/src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx index fc0ab22e826ff4..17d8953f8aef75 100644 --- a/src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx +++ b/src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx @@ -66,7 +66,7 @@ export class RequestDetailsStats extends Component { .map((id) => ({ id, ...stats[id] } as RequestDetailsStatRow)); return ( - + {sortedStats.map(this.renderStatRow)} ); diff --git a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx index ecc0d23f090920..76a55c270925fa 100644 --- a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx +++ b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx @@ -148,7 +148,7 @@ export const DrilldownTable: React.FC = ({ itemId="id" columns={columns} isSelectable={true} - responsive={false} + responsiveBreakpoint={false} selection={{ onSelectionChange: (selection) => { setSelectedDrilldowns(selection.map((drilldown) => drilldown.id)); diff --git a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx index feabf1a75556be..c409384c840573 100644 --- a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx +++ b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx @@ -111,7 +111,7 @@ export const DrilldownTemplateTable: React.FC = ({ items={items} columns={columns} isSelectable={!!onClone} - responsive={false} + responsiveBreakpoint={false} search={search} sorting={{ sort: { diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx index 310c8653bbee51..aaa14e45d89768 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx @@ -117,7 +117,7 @@ export const DocViewerLegacyTable = ({ columns={tableColumns} rowProps={onSetRowProps} pagination={false} - responsive={false} + responsiveBreakpoint={false} /> ); }; diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.tsx b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.tsx index ad957053b7dd88..b87efe1cad0438 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.tsx +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.tsx @@ -434,7 +434,7 @@ export const DocViewerTable = ({ ) : ( - + {headers} {rowElements} diff --git a/x-pack/plugins/data_visualizer/public/application/common/components/field_types_filter/field_types_help_popover.tsx b/x-pack/plugins/data_visualizer/public/application/common/components/field_types_filter/field_types_help_popover.tsx index be5ecf5acc15af..6c5fedce0fee3e 100644 --- a/x-pack/plugins/data_visualizer/public/application/common/components/field_types_filter/field_types_help_popover.tsx +++ b/x-pack/plugins/data_visualizer/public/application/common/components/field_types_filter/field_types_help_popover.tsx @@ -130,7 +130,7 @@ export const FieldTypesHelpPopover: FC<{ compressed={true} rowHeader="firstName" columns={columnsSidebar} - responsive={false} + responsiveBreakpoint={false} /> diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx index 53fa6312b9c498..aa222650e52aa4 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx @@ -59,7 +59,6 @@ export const AnalyticsTable: React.FC = ({ items, hasClicks, isSmall }) = = ({ items }) => { = ({ items }) => { [TERM_COLUMN, TIME_COLUMN, TAGS_LIST_COLUMN, RESULTS_COLUMN, ACTIONS_COLUMN] as Columns } items={items} - responsive hasActions noItemsMessage={ = ({ hasPagination }) => { } {...paginationProps} diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/curations_table.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/curations_table.tsx index b8f019dc65fca3..9e6b0be6077f8d 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/curations_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/curations_table.tsx @@ -138,7 +138,6 @@ export const CurationsTable: React.FC = () => { { { // TODO This table currently has mutiple theads, which is invalid html. We could change these subheaders to be EuiTableRow instead of EuiTableHeader // to alleviate the issue. return ( - + {!!Object.keys(textResultFields).length && ( diff --git a/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx b/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx index 0ec4998d018c0b..9ea527730fdbb6 100644 --- a/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx @@ -145,7 +145,7 @@ const SchemaFieldDetails: React.FC<{ schemaField: SchemaField }> = ({ schemaFiel css={{ '& .euiTable': { backgroundColor: 'transparent' } }} columns={columns} items={schemaField.indices} - responsive={false} + responsiveBreakpoint={false} /> @@ -452,7 +452,7 @@ export const SearchApplicationSchema: React.FC = () => { itemId="name" itemIdToExpandedRowMap={itemIdToExpandedRowMap} isExpandable - responsive={false} + responsiveBreakpoint={false} /> {totalConflictsHiddenByTypeFilters > 0 && ( = ({ search={search} pagination={pagination} message={ROLE_MAPPINGS_NO_RESULTS_MESSAGE} - responsive={false} + responsiveBreakpoint={false} /> ); }; diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/components/shared/sources_table/sources_table.tsx b/x-pack/plugins/enterprise_search/public/applications/workplace_search/components/shared/sources_table/sources_table.tsx index 8081dbff5b3fef..68f7bf732c4273 100644 --- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/components/shared/sources_table/sources_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/components/shared/sources_table/sources_table.tsx @@ -26,7 +26,7 @@ export const SourcesTable: React.FC = ({ onSearchableToggle, }) => { return ( - + {SOURCE} {STATUS_HEADER} diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_source_prioritization.tsx b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_source_prioritization.tsx index f72d4825aa0400..f4a9790770ee4b 100644 --- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_source_prioritization.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_source_prioritization.tsx @@ -123,7 +123,7 @@ export const GroupSourcePrioritization: React.FC = () => { ); const sourceTable = ( - + {SOURCE_TABLE_HEADER} {PRIORITY_TABLE_HEADER} diff --git a/x-pack/plugins/lens/public/datasources/form_based/dimension_panel/dimension_editor.tsx b/x-pack/plugins/lens/public/datasources/form_based/dimension_panel/dimension_editor.tsx index ca23cc220e3dde..9a4666788656b5 100644 --- a/x-pack/plugins/lens/public/datasources/form_based/dimension_panel/dimension_editor.tsx +++ b/x-pack/plugins/lens/public/datasources/form_based/dimension_panel/dimension_editor.tsx @@ -800,7 +800,7 @@ export function DimensionEditor(props: DimensionEditorProps) { compressed={true} rowHeader="firstName" columns={columnsSidebar} - responsive={false} + responsiveBreakpoint={false} /> diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/function_help.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/function_help.tsx index 6f280a8da6de61..41b9c24c635b34 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/function_help.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/function_help.tsx @@ -243,7 +243,7 @@ export const FunctionHelpPopover: FC = memo(() => { items={items} compressed={true} columns={columns} - responsive={false} + responsiveBreakpoint={false} /> diff --git a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/table.tsx b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/table.tsx index ceb2773486d1f3..af36f7bad67949 100644 --- a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/table.tsx @@ -173,7 +173,7 @@ export const Table = ({ loading, rows, onSearchChange, search, showActionsColumn + {columns.map((column) => ( diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/step_details_page/step_waterfall_chart/waterfall/waterfall_flyout/waterfall_flyout_table.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/step_details_page/step_waterfall_chart/waterfall/waterfall_flyout/waterfall_flyout_table.tsx index 92714aa1481741..0e8d1b3ecf6a3b 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/step_details_page/step_waterfall_chart/waterfall/waterfall_flyout/waterfall_flyout_table.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/step_details_page/step_waterfall_chart/waterfall/waterfall_flyout/waterfall_flyout_table.tsx @@ -69,7 +69,7 @@ export const Table = (props: Props) => { diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/status_details/availability_reporting/availability_reporting.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/status_details/availability_reporting/availability_reporting.tsx index 109416c3e8c841..a1f9b03c96c1a5 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/status_details/availability_reporting/availability_reporting.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/status_details/availability_reporting/availability_reporting.tsx @@ -75,7 +75,7 @@ export const AvailabilityReporting: React.FC = ({ allLocations }) => { <> { diff --git a/x-pack/plugins/observability_solution/ux/public/components/app/rum_dashboard/impactful_metrics/js_errors.tsx b/x-pack/plugins/observability_solution/ux/public/components/app/rum_dashboard/impactful_metrics/js_errors.tsx index 0500ccb2dff42d..890258f56a7204 100644 --- a/x-pack/plugins/observability_solution/ux/public/components/app/rum_dashboard/impactful_metrics/js_errors.tsx +++ b/x-pack/plugins/observability_solution/ux/public/components/app/rum_dashboard/impactful_metrics/js_errors.tsx @@ -124,7 +124,7 @@ export function JSErrors() { }) : '' } - responsive={false} + responsiveBreakpoint={false} compressed={true} columns={cols} items={data?.items ?? []} diff --git a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx index 1da786c7e6b700..612ba7eacf72c4 100644 --- a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx +++ b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx @@ -143,7 +143,7 @@ export class RolesGridPage extends Component { } pagination={pagination} - responsive={false} + responsiveBreakpoint={false} onChange={({ page }: { page: { index: number } }) => { setPageIndex(page.index); }} diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.tsx index d841e59aeb67a8..5102cb40124e2d 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.tsx @@ -194,7 +194,7 @@ export const EntityAnalyticsAnomalies = () => { )} ); }; diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx index 4b5a85f35ebe11..dc3471d46254cf 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx @@ -261,7 +261,7 @@ const RiskSummaryComponent = ({ Date: Mon, 8 Apr 2024 19:21:01 -0700 Subject: [PATCH 03/33] Remove unused `textOnly` table prop --- examples/field_formats_example/public/app.tsx | 2 -- examples/partial_results_example/public/app/app.tsx | 1 - 2 files changed, 3 deletions(-) diff --git a/examples/field_formats_example/public/app.tsx b/examples/field_formats_example/public/app.tsx index 6aa2f2d5e6c75d..112b0a8d4f0aed 100644 --- a/examples/field_formats_example/public/app.tsx +++ b/examples/field_formats_example/public/app.tsx @@ -61,7 +61,6 @@ const UsingAnExistingFieldFormatExample: React.FC<{ deps: Deps }> = (props) => { = (props) => { {datatable ? ( ({ field, From 6c86f0cc0def3df357a29cadac49054e73b1a487 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Tue, 9 Apr 2024 10:43:59 -0700 Subject: [PATCH 04/33] Remove `hasActions` table props - now detected automatically in `columns`, there's no need to pass this prop manually --- examples/data_view_field_editor_example/public/app.tsx | 1 - .../components/sync_jobs/sync_jobs_table.tsx | 1 - .../components/drilldown_table/drilldown_table.tsx | 1 - .../drilldown_template_table/drilldown_template_table.tsx | 1 - .../components/change_point_detection/change_points_table.tsx | 1 - .../maintenance_windows/components/maintenance_windows_list.tsx | 1 - .../plugins/canvas/public/components/var_config/var_config.tsx | 1 - x-pack/plugins/cases/public/components/all_cases/table.tsx | 1 - .../analytics/components/analytics_tables/analytics_table.tsx | 1 - .../components/analytics_tables/recent_queries_table.tsx | 1 - .../components/curations/components/curations_table.tsx | 1 - .../components/curations/components/suggestions_table.tsx | 1 - .../components/ignored_queries_panel/ignored_queries_panel.tsx | 1 - .../fleet/sections/agent_policy/list_page/index.tsx | 1 - .../agents/agent_list_page/components/agent_list_table.tsx | 1 - .../fleet/sections/agents/enrollment_token_list_page/index.tsx | 1 - .../fleet/sections/agents/uninstall_token_list_page/index.tsx | 1 - .../applications/fleet/sections/data_stream/list_page/index.tsx | 1 - .../document_fields/field_parameters/relations_parameter.tsx | 1 - .../components/analytics_list/analytics_list.tsx | 1 - .../jobs/jobs_list/components/jobs_list/jobs_list.js | 1 - .../memory_usage/nodes_overview/allocated_models.tsx | 1 - .../application/memory_usage/nodes_overview/nodes_list.tsx | 1 - .../ml/public/application/model_management/models_list.tsx | 2 -- .../application/model_management/pipelines/expanded_row.tsx | 1 - .../application/notifications/components/notifications_list.tsx | 1 - .../application/overview/components/analytics_panel/table.tsx | 1 - .../overview/components/anomaly_detection_panel/table.tsx | 1 - .../ml/anomaly_detection/anomalies_table/anomalies_table.tsx | 1 - .../pages/logs/log_entry_rate/sections/anomalies/table.tsx | 1 - .../common/monitor_test_result/browser_steps_list.tsx | 1 - .../management/monitor_list_table/monitor_list.tsx | 1 - .../test_now_mode/simple/ping_list/ping_list_table.tsx | 1 - .../components/monitor/ping_list/ping_list_table.tsx | 1 - .../components/overview/monitor_list/monitor_list.tsx | 1 - .../components/synthetics/check_steps/steps_list.tsx | 1 - .../public/components/sources_panel/indices_table.tsx | 1 - .../public/components/view_query/view_query_flyout.tsx | 1 - .../role_mappings_grid/role_mappings_grid_page.tsx | 1 - .../space_aware_privilege_section/privilege_space_table.tsx | 1 - .../public/management/roles/roles_grid/roles_grid_page.tsx | 1 - .../spaces/public/management/spaces_grid/spaces_grid_page.tsx | 1 - .../public/connector_types/sentinelone/sentinelone_params.tsx | 1 - .../components/transform_list/transform_list.tsx | 1 - 44 files changed, 45 deletions(-) diff --git a/examples/data_view_field_editor_example/public/app.tsx b/examples/data_view_field_editor_example/public/app.tsx index 71e10634cd8184..d4e0974366a6b6 100644 --- a/examples/data_view_field_editor_example/public/app.tsx +++ b/examples/data_view_field_editor_example/public/app.tsx @@ -121,7 +121,6 @@ const DataViewFieldEditorExample = ({ dataView, dataViewFieldEditor }: Props) => items={fields} columns={columns} pagination={true} - hasActions={true} sorting={{ sort: { field: 'name', diff --git a/packages/kbn-search-connectors/components/sync_jobs/sync_jobs_table.tsx b/packages/kbn-search-connectors/components/sync_jobs/sync_jobs_table.tsx index 7426d7dad3dec8..6ed36f35d7987d 100644 --- a/packages/kbn-search-connectors/components/sync_jobs/sync_jobs_table.tsx +++ b/packages/kbn-search-connectors/components/sync_jobs/sync_jobs_table.tsx @@ -140,7 +140,6 @@ export const SyncJobsTable: React.FC = ({ data-test-subj={`entSearchContent-index-${type}-syncJobs-table`} items={syncJobs} columns={columns} - hasActions onChange={onPaginate} pagination={pagination} tableLayout="fixed" diff --git a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx index 76a55c270925fa..8878821c0e42dc 100644 --- a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx +++ b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx @@ -158,7 +158,6 @@ export const DrilldownTable: React.FC = ({ rowProps={{ 'data-test-subj': TEST_SUBJ_DRILLDOWN_ITEM, }} - hasActions={true} sorting={{ sort: { field: 'drilldownName', diff --git a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx index c409384c840573..a1d884855a08e0 100644 --- a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx +++ b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx @@ -125,7 +125,6 @@ export const DrilldownTemplateTable: React.FC = ({ }, selectableMessage: () => txtSelectableMessage, }} - hasActions={true} /> {!!onClone && !!selected.length && ( diff --git a/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx b/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx index f42e1acc319965..078c9c1e39c6f3 100644 --- a/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx +++ b/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx @@ -324,7 +324,6 @@ export const ChangePointsTable: FC = ({ } sorting={sorting} onTableChange={onTableChange} - hasActions={hasActions} rowProps={(item) => ({ 'data-test-subj': `aiopsChangePointResultsTableRow row-${item.id}`, })} diff --git a/x-pack/plugins/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.tsx b/x-pack/plugins/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.tsx index 0abd1c4e1863cc..dd396057e3724f 100644 --- a/x-pack/plugins/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.tsx +++ b/x-pack/plugins/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.tsx @@ -191,7 +191,6 @@ export const MaintenanceWindowsList = React.memo( sorting={sorting} rowProps={rowProps} search={search} - hasActions={true} /> ); } diff --git a/x-pack/plugins/canvas/public/components/var_config/var_config.tsx b/x-pack/plugins/canvas/public/components/var_config/var_config.tsx index 25c77ab7704bf8..b3ddd8c96c2bad 100644 --- a/x-pack/plugins/canvas/public/components/var_config/var_config.tsx +++ b/x-pack/plugins/canvas/public/components/var_config/var_config.tsx @@ -212,7 +212,6 @@ export const VarConfig: FC = ({ className="canvasVarConfig__list" items={variables} columns={varColumns} - hasActions={true} pagination={false} sorting={true} compressed diff --git a/x-pack/plugins/cases/public/components/all_cases/table.tsx b/x-pack/plugins/cases/public/components/all_cases/table.tsx index 24c354970f038c..61b917ef987174 100644 --- a/x-pack/plugins/cases/public/components/all_cases/table.tsx +++ b/x-pack/plugins/cases/public/components/all_cases/table.tsx @@ -114,7 +114,6 @@ export const CasesTable: FunctionComponent = ({ rowProps={tableRowProps} selection={!isSelectorView ? selection : undefined} sorting={sorting} - hasActions={false} /> ); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx index aa222650e52aa4..a5e981e7f7b8dc 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx @@ -59,7 +59,6 @@ export const AnalyticsTable: React.FC = ({ items, hasClicks, isSmall }) = = ({ items }) => { [TERM_COLUMN, TIME_COLUMN, TAGS_LIST_COLUMN, RESULTS_COLUMN, ACTIONS_COLUMN] as Columns } items={items} - hasActions noItemsMessage={ { { { itemId="query" // @ts-expect-error - EuiBasicTable wants an array of objects, but will accept strings if coerced columns={columns} - hasActions pagination={{ ...convertMetaToPagination(meta), showPerPageOptions: false, diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx index a24ba5e7135a87..a3b1102e60bef0 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx @@ -279,7 +279,6 @@ export const AgentPolicyListPage: React.FunctionComponent<{}> = () => { loading={isLoading} - hasActions={true} noItemsMessage={ isLoading ? ( = (props: Props) => { className="fleet__agentList__table" data-test-subj="fleetAgentListTable" loading={isLoading} - hasActions={true} noItemsMessage={noItemsMessage} items={ totalAgents diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/enrollment_token_list_page/index.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/enrollment_token_list_page/index.tsx index 05b4ead4cc3eae..b72794868a1c2f 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/enrollment_token_list_page/index.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/enrollment_token_list_page/index.tsx @@ -275,7 +275,6 @@ export const EnrollmentTokenListPage: React.FunctionComponent<{}> = () => { data-test-subj="enrollmentTokenListTable" loading={isLoading} - hasActions={true} noItemsMessage={ isLoading ? ( { }} onChange={handleTablePagination} noItemsMessage={} - hasActions={true} /> diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/data_stream/list_page/index.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/data_stream/list_page/index.tsx index daf4aff7079b8a..29f672c012a2c4 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/data_stream/list_page/index.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/data_stream/list_page/index.tsx @@ -193,7 +193,6 @@ export const DataStreamListPage: React.FunctionComponent<{}> = () => { return ( { defaultMessage: 'No relationship defined', } )} - hasActions /> {/* Add relation button */} diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx index cc5c6d5ad1e759..9291c2002d9eb9 100644 --- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx +++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx @@ -280,7 +280,6 @@ export const DataFrameAnalyticsList: FC = ({ allowNeutralSort={false} columns={columns} - hasActions={false} isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} isSelectable={false} diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js index b7988b0f71a818..aca09cc314e2cf 100644 --- a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js +++ b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js @@ -395,7 +395,6 @@ export class JobsList extends Component { itemIdToExpandedRowMap={this.state.itemIdToExpandedRowMap} isExpandable={true} sorting={sorting} - hasActions={true} rowProps={(item) => ({ 'data-test-subj': `mlJobListRow row-${item.id}`, })} diff --git a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx index d33c1a0c8bc404..56822bf2af1c65 100644 --- a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx +++ b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx @@ -257,7 +257,6 @@ export const AllocatedModels: FC = ({ allowNeutralSort={false} columns={columns} - hasActions={false} isExpandable={false} isSelectable={false} items={models} diff --git a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx index 2fbb8ffb8a1446..1ddb101f1f5d13 100644 --- a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx +++ b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx @@ -220,7 +220,6 @@ export const NodesList: FC = ({ compactView = false }) => { allowNeutralSort={false} columns={columns} - hasActions={false} isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} isSelectable={false} diff --git a/x-pack/plugins/ml/public/application/model_management/models_list.tsx b/x-pack/plugins/ml/public/application/model_management/models_list.tsx index b26014b57c0650..88809e1fb9c520 100644 --- a/x-pack/plugins/ml/public/application/model_management/models_list.tsx +++ b/x-pack/plugins/ml/public/application/model_management/models_list.tsx @@ -769,9 +769,7 @@ export const ModelsList: FC = ({
css={{ overflowX: 'auto' }} - isSelectable={true} isExpandable={true} - hasActions={true} allowNeutralSort={false} columns={columns} itemIdToExpandedRowMap={itemIdToExpandedRowMap} diff --git a/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx b/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx index 25e76c989bb4f3..e5f157f4dc7518 100644 --- a/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx +++ b/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx @@ -170,7 +170,6 @@ export const ProcessorsStats: FC = ({ stats }) => { allowNeutralSort={false} columns={columns} - hasActions={false} isExpandable={false} isSelectable={false} items={items} diff --git a/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx b/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx index 665e8865165514..33eb9ed264917b 100644 --- a/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx +++ b/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx @@ -397,7 +397,6 @@ export const NotificationsList: FC = () => { columns={columns} - hasActions={false} isExpandable={false} isSelectable={false} items={itemsPerPage} diff --git a/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx b/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx index c6c715aa5cad59..e85829aeae0730 100644 --- a/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx +++ b/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx @@ -112,7 +112,6 @@ export const AnalyticsTable: FC = ({ items }) => { allowNeutralSort={false} className="mlAnalyticsTable" columns={columns} - hasActions={true} isExpandable={false} isSelectable={false} items={items} diff --git a/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx b/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx index 2476a0d2a3bed1..20f23933c356ad 100644 --- a/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx +++ b/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx @@ -186,7 +186,6 @@ export const AnomalyDetectionTable: FC = ({ items, chartsService }) => { allowNeutralSort={false} className="mlAnomalyDetectionTable" columns={columns} - hasActions={true} isExpandable={false} isSelectable={false} items={groupsList} diff --git a/x-pack/plugins/observability_solution/infra/public/components/ml/anomaly_detection/anomalies_table/anomalies_table.tsx b/x-pack/plugins/observability_solution/infra/public/components/ml/anomaly_detection/anomalies_table/anomalies_table.tsx index 0c1b656169033a..b38af534df6e7e 100644 --- a/x-pack/plugins/observability_solution/infra/public/components/ml/anomaly_detection/anomalies_table/anomalies_table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/components/ml/anomaly_detection/anomalies_table/anomalies_table.tsx @@ -531,7 +531,6 @@ export const AnomaliesTable = ({ items={results} sorting={{ sort: sorting }} onChange={onTableChange} - hasActions={true} loading={isLoading} noItemsMessage={ isLoading ? ( diff --git a/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx b/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx index 1e1f720a1ad67f..965b2cdc817ff6 100644 --- a/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx @@ -208,7 +208,6 @@ export const AnomaliesTable: React.FunctionComponent<{ itemId="id" itemIdToExpandedRowMap={expandedIdsRowContents} isExpandable={true} - hasActions={true} columns={columns} sorting={tableSortOptions} onChange={handleTableChange} diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx index f596b632fe1581..4cdd25457967ed 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx @@ -299,7 +299,6 @@ export const BrowserStepsList = ({ columns={columns} error={error?.message} isExpandable={showExpand} - hasActions={false} items={stepEnds} noItemsMessage={ loading diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitors_page/management/monitor_list_table/monitor_list.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitors_page/management/monitor_list_table/monitor_list.tsx index 1e394143eecd5b..2dee5e2809558b 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitors_page/management/monitor_list_table/monitor_list.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitors_page/management/monitor_list_table/monitor_list.tsx @@ -113,7 +113,6 @@ export const MonitorList = ({ error={error?.body?.message} loading={loading} isExpandable={true} - hasActions={true} itemId="monitor_id" items={syntheticsMonitors} columns={columns} diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/test_now_mode/simple/ping_list/ping_list_table.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/test_now_mode/simple/ping_list/ping_list_table.tsx index 830bd3edb2964b..37d456fb8aa554 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/test_now_mode/simple/ping_list/ping_list_table.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/test_now_mode/simple/ping_list/ping_list_table.tsx @@ -116,7 +116,6 @@ export function PingListTable({ loading, error, pings, onChange }: Props) { columns={columns} error={error?.message} isExpandable={true} - hasActions={true} items={pings} itemId="docId" itemIdToExpandedRowMap={expandedRows} diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx index 98ccc4524d48c0..6f4af1d83829ef 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx @@ -227,7 +227,6 @@ export function PingListTable({ loading, error, pings, pagination, onChange, fai columns={columns} error={error?.message} isExpandable={true} - hasActions={true} items={pings} itemId="docId" itemIdToExpandedRowMap={expandedRows} diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/overview/monitor_list/monitor_list.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/overview/monitor_list/monitor_list.tsx index 0543a2676791fd..79321172fbdce4 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/overview/monitor_list/monitor_list.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/overview/monitor_list/monitor_list.tsx @@ -227,7 +227,6 @@ export const MonitorListComponent: ({ error={error?.body?.message || error?.message} loading={loading || isPending} isExpandable={true} - hasActions={true} itemId="monitor_id" itemIdToExpandedRowMap={getExpandedRowMap()} items={items} diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx index 4063671661647e..61fb964e0da341 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx @@ -237,7 +237,6 @@ export const StepsList = ({ columns={columns} error={error?.message} isExpandable={true} - hasActions={true} items={steps} itemIdToExpandedRowMap={expandedRows} noItemsMessage={ diff --git a/x-pack/plugins/search_playground/public/components/sources_panel/indices_table.tsx b/x-pack/plugins/search_playground/public/components/sources_panel/indices_table.tsx index 85f53eec44be43..cd5643d7ea303e 100644 --- a/x-pack/plugins/search_playground/public/components/sources_panel/indices_table.tsx +++ b/x-pack/plugins/search_playground/public/components/sources_panel/indices_table.tsx @@ -45,6 +45,5 @@ export const IndicesTable: React.FC = ({ indices, onRemoveCli ], }, ]} - hasActions /> ); diff --git a/x-pack/plugins/search_playground/public/components/view_query/view_query_flyout.tsx b/x-pack/plugins/search_playground/public/components/view_query/view_query_flyout.tsx index cc271bd8fe1e53..f7758afc88a2b8 100644 --- a/x-pack/plugins/search_playground/public/components/view_query/view_query_flyout.tsx +++ b/x-pack/plugins/search_playground/public/components/view_query/view_query_flyout.tsx @@ -170,7 +170,6 @@ export const ViewQueryFlyout: React.FC = ({ onClose }) => ], }, ]} - hasActions /> diff --git a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx index ed733ac8d24b97..438abc4c53c46e 100644 --- a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx +++ b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx @@ -283,7 +283,6 @@ export class RoleMappingsGridPage extends Component { items={roleMappings!} itemId="name" columns={this.getColumnConfig(deleteRoleMappingPrompt)} - hasActions={true} search={search} sorting={sorting} selection={this.props.readOnly ? undefined : selection} diff --git a/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/space_aware_privilege_section/privilege_space_table.tsx b/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/space_aware_privilege_section/privilege_space_table.tsx index cbbbc96863bda3..530f6ffb2ee3c2 100644 --- a/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/space_aware_privilege_section/privilege_space_table.tsx +++ b/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/space_aware_privilege_section/privilege_space_table.tsx @@ -264,7 +264,6 @@ export class PrivilegeSpaceTable extends Component { { return { className: isGlobalPrivilegeDefinition(item.privileges) diff --git a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx index 612ba7eacf72c4..34546a74639e43 100644 --- a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx +++ b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx @@ -145,7 +145,6 @@ export class RolesGridPage extends Component { itemId="name" responsiveBreakpoint={false} columns={this.getColumnConfig()} - hasActions={true} selection={ this.props.readOnly ? undefined diff --git a/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx b/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx index d557fcdb604bbd..6d2cd1a9bd05d7 100644 --- a/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx +++ b/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx @@ -130,7 +130,6 @@ export class SpacesGridPage extends Component { })} rowHeader="name" columns={this.getColumnConfig()} - hasActions pagination={true} sorting={true} search={{ diff --git a/x-pack/plugins/stack_connectors/public/connector_types/sentinelone/sentinelone_params.tsx b/x-pack/plugins/stack_connectors/public/connector_types/sentinelone/sentinelone_params.tsx index 622cab06d14dfa..a0dd8e0ebbf972 100644 --- a/x-pack/plugins/stack_connectors/public/connector_types/sentinelone/sentinelone_params.tsx +++ b/x-pack/plugins/stack_connectors/public/connector_types/sentinelone/sentinelone_params.tsx @@ -297,7 +297,6 @@ const SentinelOneParamsFields: React.FunctionComponent< search={search} pagination={pagination} sorting - hasActions itemIdToExpandedRowMap={itemIdToExpandedRowMap} /> )} diff --git a/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx b/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx index da4ddd44ed7e01..eb7a40bc9e0ee8 100644 --- a/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx +++ b/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx @@ -356,7 +356,6 @@ export const TransformList: FC = ({ className="transform__TransformTable" columns={columns} error={searchError} - hasActions={false} isExpandable={true} isSelectable={false} items={filteredTransforms} From f220cea63a00b129152f56b42f0c386f22c1d416 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Tue, 9 Apr 2024 10:44:43 -0700 Subject: [PATCH 05/33] Remove `hasActions` prop + util - as far as I can tell this util isn't used anywhere else, so I'm deleting it entirely --- .../field_browser/components/field_items/field_items.tsx | 7 ------- .../sections/field_browser/components/field_items/index.ts | 2 +- .../field_browser/components/field_table/field_table.tsx | 4 +--- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/field_items.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/field_items.tsx index 66d7705a1bd123..ae0f5d7670f1a2 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/field_items.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/field_items.tsx @@ -12,8 +12,6 @@ import { EuiFlexGroup, EuiFlexItem, EuiBadge, - EuiBasicTableColumn, - EuiTableActionsColumnType, EuiScreenReaderOnly, } from '@elastic/eui'; import { uniqBy } from 'lodash/fp'; @@ -189,8 +187,3 @@ export const getFieldColumns = ({ ? getFieldTableColumns({ highlight, onHide }) : getDefaultFieldTableColumns({ highlight })), ]; - -/** Returns whether the table column has actions attached to it */ -export const isActionsColumn = (column: EuiBasicTableColumn): boolean => { - return !!(column as EuiTableActionsColumnType).actions?.length; -}; diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/index.ts b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/index.ts index 103d94a29e151a..d783e8cd7f0953 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/index.ts +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/index.ts @@ -5,4 +5,4 @@ * 2.0. */ -export { getFieldItemsData, getFieldColumns, isActionsColumn } from './field_items'; +export { getFieldItemsData, getFieldColumns } from './field_items'; diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_table/field_table.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_table/field_table.tsx index eb2962c9af20fb..c5bf6647763010 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_table/field_table.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_table/field_table.tsx @@ -7,7 +7,7 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react'; import { EuiInMemoryTable, Pagination, Direction, useEuiTheme } from '@elastic/eui'; import { BrowserFields } from '@kbn/rule-registry-plugin/common'; -import { getFieldColumns, getFieldItemsData, isActionsColumn } from '../field_items'; +import { getFieldColumns, getFieldItemsData } from '../field_items'; import { CATEGORY_TABLE_CLASS_NAME, TABLE_HEIGHT } from '../../helpers'; import type { FieldBrowserProps, GetFieldTableColumns } from '../../types'; import { FieldTableHeader } from './field_table_header'; @@ -128,7 +128,6 @@ const FieldTableComponent: React.FC = ({ }), [getFieldTableColumns, searchInput, onHide, onToggleColumn] ); - const hasActions = useMemo(() => columns.some((column) => isActionsColumn(column)), [columns]); return ( <> @@ -147,7 +146,6 @@ const FieldTableComponent: React.FC = ({ columns={columns} pagination={pagination} sorting={sorting} - hasActions={hasActions} onChange={onTableChange} compressed /> From 894238954cfd0a12d8c6b86ccb174581497b3942 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Tue, 9 Apr 2024 10:51:51 -0700 Subject: [PATCH 06/33] Remove `isExpandable` table prop - this is now automatically detected by the presence of the `itemIdToExpandedRowMap` prop and no longer needs to be passed manually --- .../src/status/components/status_table.tsx | 1 - .../details/clusters_view/clusters_table/clusters_table.tsx | 1 - .../clusters_table/shards_view/shard_failure_table.tsx | 1 - .../impl/data_quality/data_quality_panel/summary_table/index.tsx | 1 - .../log_categorization/category_table/category_table.tsx | 1 - .../components/stats_table/data_visualizer_stats_table.tsx | 1 - .../public/application/data_drift/data_drift_overview_table.tsx | 1 - .../components/search_application/search_application_schema.tsx | 1 - .../extraction_rules/extraction_rules_table.tsx | 1 - .../components/analytics_list/analytics_list.tsx | 1 - .../application/jobs/jobs_list/components/jobs_list/jobs_list.js | 1 - .../application/memory_usage/nodes_overview/allocated_models.tsx | 1 - .../application/memory_usage/nodes_overview/nodes_list.tsx | 1 - .../ml/public/application/model_management/models_list.tsx | 1 - .../application/model_management/pipelines/expanded_row.tsx | 1 - .../application/notifications/components/notifications_list.tsx | 1 - .../application/overview/components/analytics_panel/table.tsx | 1 - .../overview/components/anomaly_detection_panel/table.tsx | 1 - .../pages/logs/log_entry_rate/sections/anomalies/table.tsx | 1 - .../monitor_details/monitor_summary/test_runs_table.tsx | 1 - .../monitors_page/management/monitor_list_table/monitor_list.tsx | 1 - .../test_now_mode/simple/ping_list/ping_list_table.tsx | 1 - .../components/monitor/ping_list/ping_list_table.tsx | 1 - .../components/overview/monitor_list/monitor_list.tsx | 1 - .../components/synthetics/check_steps/steps_list.tsx | 1 - .../public/live_queries/form/pack_queries_status_table.tsx | 1 - .../plugins/osquery/public/packs/pack_queries_status_table.tsx | 1 - .../public/components/message_list/citations_table.tsx | 1 - .../rule_details/execution_log_table/execution_log_table.tsx | 1 - .../components/execution_events_table/execution_events_table.tsx | 1 - .../components/actions_log_table.tsx | 1 - .../timelines/components/open_timeline/timelines_table/index.tsx | 1 - .../sections/home/restore_list/restore_table/restore_table.tsx | 1 - .../components/transform_list/transform_list.tsx | 1 - .../sections/rules_list/components/rules_list_table.tsx | 1 - 35 files changed, 35 deletions(-) diff --git a/packages/core/apps/core-apps-browser-internal/src/status/components/status_table.tsx b/packages/core/apps/core-apps-browser-internal/src/status/components/status_table.tsx index 37833ebfde923f..977dd3efb3e0e2 100644 --- a/packages/core/apps/core-apps-browser-internal/src/status/components/status_table.tsx +++ b/packages/core/apps/core-apps-browser-internal/src/status/components/status_table.tsx @@ -104,7 +104,6 @@ export const StatusTable: FunctionComponent = ({ statuses }) = columns={tableColumns} itemId={(item) => item.id} items={statuses} - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} rowProps={({ state }) => ({ className: `status-table-row-${state.uiColor}`, diff --git a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.tsx b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.tsx index 1cd0f0864742ff..92e8e7ebcbafe6 100644 --- a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.tsx +++ b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.tsx @@ -137,7 +137,6 @@ export function ClustersTable({ clusters }: Props) { ? items.sort(Comparators.property(sortField, Comparators.default(sortDirection))) : items } - isExpandable={true} itemIdToExpandedRowMap={expandedRows} itemId="name" columns={columns} diff --git a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/shards_view/shard_failure_table.tsx b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/shards_view/shard_failure_table.tsx index 344b17b38a741c..d72f661576a556 100644 --- a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/shards_view/shard_failure_table.tsx +++ b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/shards_view/shard_failure_table.tsx @@ -108,7 +108,6 @@ export function ShardFailureTable({ failures }: Props) { failureType: failure.reason.type, }; })} - isExpandable={true} itemIdToExpandedRowMap={expandedRows} itemId="rowId" columns={columns} diff --git a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/index.tsx b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/index.tsx index a2305100292226..6379539f050968 100644 --- a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/index.tsx +++ b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/index.tsx @@ -108,7 +108,6 @@ const SummaryTableComponent: React.FC = ({ compressed={true} columns={columns} data-test-subj="summaryTable" - isExpandable={true} itemId={getItemId} itemIdToExpandedRowMap={itemIdToExpandedRowMap} items={items} diff --git a/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx b/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx index a8bf7d04298e1a..ab2dcdbb91b9fa 100644 --- a/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx +++ b/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx @@ -324,7 +324,6 @@ export const CategoryTable: FC = ({ pagination={pagination} sorting={sorting} data-test-subj="aiopsLogPatternsTable" - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} rowProps={(category) => { return enableRowActions diff --git a/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx b/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx index 2e2c1e2b9d9e8a..8e12f94d8c3ab8 100644 --- a/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx +++ b/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx @@ -481,7 +481,6 @@ export const DataVisualizerTable = ({ columns={columns} pagination={pagination} sorting={sorting} - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} isSelectable={false} onTableChange={onTableChange} diff --git a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_overview_table.tsx b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_overview_table.tsx index 55bce9d953c5b3..7de413c74b4de7 100644 --- a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_overview_table.tsx +++ b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_overview_table.tsx @@ -305,7 +305,6 @@ export const DataDriftOverviewTable = ({ cellProps={getCellProps} itemId="featureName" itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable={true} sorting={sorting} onChange={onTableChange} pagination={pagination} diff --git a/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx b/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx index 9ea527730fdbb6..a9343feea72fc4 100644 --- a/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx @@ -451,7 +451,6 @@ export const SearchApplicationSchema: React.FC = () => { loading={isLoadingSearchApplicationSchema} itemId="name" itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable responsiveBreakpoint={false} /> {totalConflictsHiddenByTypeFilters > 0 && ( diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawler_domain_detail/extraction_rules/extraction_rules_table.tsx b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawler_domain_detail/extraction_rules/extraction_rules_table.tsx index d2ae9936bf2901..03119c6a2297ca 100644 --- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawler_domain_detail/extraction_rules/extraction_rules_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/crawler_domain_detail/extraction_rules/extraction_rules_table.tsx @@ -243,7 +243,6 @@ export const ExtractionRulesTable: React.FC = () => { )} = ({ allowNeutralSort={false} columns={columns} - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} isSelectable={false} items={analytics} diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js index aca09cc314e2cf..3629bd4215bbc7 100644 --- a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js +++ b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js @@ -393,7 +393,6 @@ export class JobsList extends Component { onChange={this.onTableChange} selection={selectionControls} itemIdToExpandedRowMap={this.state.itemIdToExpandedRowMap} - isExpandable={true} sorting={sorting} rowProps={(item) => ({ 'data-test-subj': `mlJobListRow row-${item.id}`, diff --git a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx index 56822bf2af1c65..6551b3af184270 100644 --- a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx +++ b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx @@ -257,7 +257,6 @@ export const AllocatedModels: FC = ({ allowNeutralSort={false} columns={columns} - isExpandable={false} isSelectable={false} items={models} itemId={'key'} diff --git a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx index 1ddb101f1f5d13..69888cb74bf533 100644 --- a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx +++ b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx @@ -220,7 +220,6 @@ export const NodesList: FC = ({ compactView = false }) => { allowNeutralSort={false} columns={columns} - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} isSelectable={false} items={items} diff --git a/x-pack/plugins/ml/public/application/model_management/models_list.tsx b/x-pack/plugins/ml/public/application/model_management/models_list.tsx index 88809e1fb9c520..8f4a9ae1e55f14 100644 --- a/x-pack/plugins/ml/public/application/model_management/models_list.tsx +++ b/x-pack/plugins/ml/public/application/model_management/models_list.tsx @@ -769,7 +769,6 @@ export const ModelsList: FC = ({
css={{ overflowX: 'auto' }} - isExpandable={true} allowNeutralSort={false} columns={columns} itemIdToExpandedRowMap={itemIdToExpandedRowMap} diff --git a/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx b/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx index e5f157f4dc7518..a052b8edf34df7 100644 --- a/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx +++ b/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx @@ -170,7 +170,6 @@ export const ProcessorsStats: FC = ({ stats }) => { allowNeutralSort={false} columns={columns} - isExpandable={false} isSelectable={false} items={items} itemId={'id'} diff --git a/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx b/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx index 33eb9ed264917b..8e632ed0b4e6fd 100644 --- a/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx +++ b/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx @@ -397,7 +397,6 @@ export const NotificationsList: FC = () => { columns={columns} - isExpandable={false} isSelectable={false} items={itemsPerPage} itemId={'id'} diff --git a/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx b/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx index e85829aeae0730..8ccb4ad244144e 100644 --- a/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx +++ b/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx @@ -112,7 +112,6 @@ export const AnalyticsTable: FC = ({ items }) => { allowNeutralSort={false} className="mlAnalyticsTable" columns={columns} - isExpandable={false} isSelectable={false} items={items} itemId={DataFrameAnalyticsListColumn.id} diff --git a/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx b/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx index 20f23933c356ad..7ee2620b845b13 100644 --- a/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx +++ b/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx @@ -186,7 +186,6 @@ export const AnomalyDetectionTable: FC = ({ items, chartsService }) => { allowNeutralSort={false} className="mlAnomalyDetectionTable" columns={columns} - isExpandable={false} isSelectable={false} items={groupsList} itemId={AnomalyDetectionListColumns.id} diff --git a/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx b/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx index 965b2cdc817ff6..34075a301c9111 100644 --- a/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx @@ -207,7 +207,6 @@ export const AnomaliesTable: React.FunctionComponent<{ items={tableItems} itemId="id" itemIdToExpandedRowMap={expandedIdsRowContents} - isExpandable={true} columns={columns} sorting={tableSortOptions} onChange={handleTableChange} diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx index c61242fa2373b5..edaf7ca2e7ad24 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx @@ -293,7 +293,6 @@ export const TestRunsTable = ({ /> = ( columns={columns} sorting={sorting} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable /> {queryDetailsFlyoutOpen ? ( diff --git a/x-pack/plugins/osquery/public/packs/pack_queries_status_table.tsx b/x-pack/plugins/osquery/public/packs/pack_queries_status_table.tsx index 89b1a6adacdad4..f4f941a1254eb5 100644 --- a/x-pack/plugins/osquery/public/packs/pack_queries_status_table.tsx +++ b/x-pack/plugins/osquery/public/packs/pack_queries_status_table.tsx @@ -757,7 +757,6 @@ const PackQueriesStatusTableComponent: React.FC = ( columns={columns} sorting={sorting} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable /> ); }; diff --git a/x-pack/plugins/search_playground/public/components/message_list/citations_table.tsx b/x-pack/plugins/search_playground/public/components/message_list/citations_table.tsx index 6de4ec26485d7e..6be67bd4b19254 100644 --- a/x-pack/plugins/search_playground/public/components/message_list/citations_table.tsx +++ b/x-pack/plugins/search_playground/public/components/message_list/citations_table.tsx @@ -67,7 +67,6 @@ export const CitationsTable: React.FC = ({ citations }) => items={citations} itemId="id" itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable /> ); }; diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/execution_log_table/execution_log_table.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/execution_log_table/execution_log_table.tsx index e30e2b6e6aa523..1171c22fbcea2f 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/execution_log_table/execution_log_table.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/execution_log_table/execution_log_table.tsx @@ -524,7 +524,6 @@ const ExecutionLogTableComponent: React.FC = ({ onChange={onTableChangeCallback} itemId={getItemId} itemIdToExpandedRowMap={rows.itemIdToExpandedRowMap} - isExpandable={true} /> ); diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_monitoring/components/execution_events_table/execution_events_table.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_monitoring/components/execution_events_table/execution_events_table.tsx index f05636f9aced13..85870f7cda4e36 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_monitoring/components/execution_events_table/execution_events_table.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_monitoring/components/execution_events_table/execution_events_table.tsx @@ -123,7 +123,6 @@ const ExecutionEventsTableComponent: React.FC = ({ ru items={items} itemId={getItemId} itemIdToExpandedRowMap={rows.itemIdToExpandedRowMap} - isExpandable={true} loading={executionEvents.isFetching} sorting={sorting.state} pagination={pagination.state} diff --git a/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_table.tsx b/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_table.tsx index 03a2485892dac6..795044b240bb82 100644 --- a/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_table.tsx +++ b/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_table.tsx @@ -436,7 +436,6 @@ export const ActionsLogTable = memo( columns={columns} itemId="id" itemIdToExpandedRowMap={expandedRowMap} - isExpandable pagination={tablePagination} onChange={onChange} loading={loading} diff --git a/x-pack/plugins/security_solution/public/timelines/components/open_timeline/timelines_table/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/open_timeline/timelines_table/index.tsx index c62d05a25d69a6..6b3020d7b1be2c 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/open_timeline/timelines_table/index.tsx +++ b/x-pack/plugins/security_solution/public/timelines/components/open_timeline/timelines_table/index.tsx @@ -230,7 +230,6 @@ export const TimelinesTable = React.memo( = React.memo(({ restor items={getRestores()} itemId="index" itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable={true} columns={columns} sorting={getSorting()} pagination={getPagination()} diff --git a/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx b/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx index eb7a40bc9e0ee8..e75d2ac3dc06ff 100644 --- a/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx +++ b/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx @@ -356,7 +356,6 @@ export const TransformList: FC = ({ className="transform__TransformTable" columns={columns} error={searchError} - isExpandable={true} isSelectable={false} items={filteredTransforms} itemId={TRANSFORM_LIST_COLUMN.ID} diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx index 0f1f42b475a358..0652d5416f0a8e 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx @@ -944,7 +944,6 @@ export const RulesListTable = (props: RulesListTableProps) => { } }} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable={true} /> From fc31f49b420c65acbac07c17ab117a9068a6fd9f Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Tue, 9 Apr 2024 10:52:31 -0700 Subject: [PATCH 07/33] Remove `isExpandable` table prop with conditional logic - was confused about this as the condition for `itemIdToExpandedRowMap` wasn't the same as `isExpandable`, so I updated the row map to support both --- .../common/monitor_test_result/browser_steps_list.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx index 4cdd25457967ed..c514850b2c7eb0 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx @@ -298,7 +298,6 @@ export const BrowserStepsList = ({ loading={loading} columns={columns} error={error?.message} - isExpandable={showExpand} items={stepEnds} noItemsMessage={ loading @@ -311,7 +310,7 @@ export const BrowserStepsList = ({ } tableLayout={'auto'} itemId="_id" - itemIdToExpandedRowMap={testNowMode ? expandedMap : undefined} + itemIdToExpandedRowMap={testNowMode || showExpand ? expandedMap : undefined} /> ); From 6897cc25e8ef249b6f28d6505b8bee53d07958be Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Tue, 9 Apr 2024 11:35:37 -0700 Subject: [PATCH 08/33] Remove `isSelectable` table prop - this is now automatically detected by the presence of the `selectable` prop and no longer needs to be passed manually --- .../table_list_view_table/src/components/table.tsx | 1 - .../components/drilldown_table/drilldown_table.tsx | 1 - .../data_anonymization_editor/context_editor/index.tsx | 1 - .../log_categorization/category_table/category_table.tsx | 1 - .../auto_follow_pattern_table.js | 1 - .../follower_indices_table/follower_indices_table.js | 1 - .../stats_table/data_visualizer_stats_table.tsx | 1 - .../package_policies/package_policies_table.tsx | 1 - .../fleet/sections/agent_policy/list_page/index.tsx | 1 - .../agent_list_page/components/agent_list_table.tsx | 1 - .../component_templates/component_template_list/table.tsx | 1 - .../data_stream_table/data_stream_table.tsx | 1 - .../policies_table/policies_table.tsx | 1 - .../legacy_templates/template_table/template_table.tsx | 1 - .../home/template_list/template_table/template_table.tsx | 1 - .../public/application/sections/pipelines_list/table.tsx | 1 - .../components/pipeline_list/pipelines_table.js | 1 - .../components/analytics_list/analytics_list.tsx | 1 - .../analytics_selector/analytics_id_selector.tsx | 2 -- .../memory_usage/nodes_overview/allocated_models.tsx | 1 - .../memory_usage/nodes_overview/nodes_list.tsx | 1 - .../model_management/pipelines/expanded_row.tsx | 1 - .../notifications/components/notifications_list.tsx | 1 - .../overview/components/analytics_panel/table.tsx | 1 - .../overview/components/anomaly_detection_panel/table.tsx | 1 - .../application/settings/calendars/list/table/table.js | 1 - .../application/settings/filter_lists/list/table.js | 1 - .../public/components/dataset_quality/table/table.tsx | 1 - .../public/pages/metrics/hosts/components/hosts_table.tsx | 1 - .../remote_cluster_table/remote_cluster_table.js | 1 - .../reporting/public/management/report_listing_table.tsx | 1 - .../role_mappings_grid/role_mappings_grid_page.tsx | 1 - .../management/roles/roles_grid/roles_grid_page.tsx | 1 - .../management/users/users_grid/users_grid_page.tsx | 1 - .../components/flyout_components/linked_to_list/index.tsx | 1 - .../add_prebuilt_rules_table/add_prebuilt_rules_table.tsx | 1 - .../upgrade_prebuilt_rules_table.tsx | 1 - .../alerts_kpis/alerts_count_panel/alerts_count.tsx | 8 +------- .../tabs/risk_inputs/risk_inputs_tab.tsx | 1 - .../row_renderers_browser/row_renderers_browser.tsx | 1 - .../home/policy_list/policy_table/policy_table.tsx | 1 - .../repository_list/repository_table/repository_table.tsx | 1 - .../home/snapshot_list/components/snapshot_table.tsx | 1 - .../components/transform_list/transform_list.tsx | 1 - .../sections/watch_list_page/watch_list_page.tsx | 1 - 45 files changed, 1 insertion(+), 52 deletions(-) diff --git a/packages/content-management/table_list_view_table/src/components/table.tsx b/packages/content-management/table_list_view_table/src/components/table.tsx index 42bd6763433621..a459bc26ede506 100644 --- a/packages/content-management/table_list_view_table/src/components/table.tsx +++ b/packages/content-management/table_list_view_table/src/components/table.tsx @@ -242,7 +242,6 @@ export function Table({ data-test-subj="itemsInMemTable" rowHeader="attributes.title" tableCaption={tableCaption} - isSelectable /> ); } diff --git a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx index 8878821c0e42dc..97ae04a2331e24 100644 --- a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx +++ b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx @@ -147,7 +147,6 @@ export const DrilldownTable: React.FC = ({ items={drilldowns} itemId="id" columns={columns} - isSelectable={true} responsiveBreakpoint={false} selection={{ onSelectionChange: (selection) => { diff --git a/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx b/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx index ea62b43b85635a..c6bf5852e8ccf5 100644 --- a/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx +++ b/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx @@ -118,7 +118,6 @@ const ContextEditorComponent: React.FC = ({ columns={columns} compressed={true} data-test-subj="contextEditor" - isSelectable={true} itemId={FIELDS.FIELD} items={rows} pagination={pagination} diff --git a/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx b/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx index ab2dcdbb91b9fa..fc2d4b559e8599 100644 --- a/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx +++ b/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx @@ -317,7 +317,6 @@ export const CategoryTable: FC = ({ compressed items={categories} columns={columns} - isSelectable={true} selection={selectionValue} itemId="key" onTableChange={onTableChange} diff --git a/x-pack/plugins/cross_cluster_replication/public/app/sections/home/auto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js b/x-pack/plugins/cross_cluster_replication/public/app/sections/home/auto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js index 5c966eac9219d8..b5df0f1c5011e0 100644 --- a/x-pack/plugins/cross_cluster_replication/public/app/sections/home/auto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js +++ b/x-pack/plugins/cross_cluster_replication/public/app/sections/home/auto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js @@ -341,7 +341,6 @@ export class AutoFollowPatternTable extends PureComponent { pagination={pagination} sorting={sorting} selection={selection} - isSelectable={true} rowProps={() => ({ 'data-test-subj': 'row', })} diff --git a/x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js b/x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js index 6b4170cf18c028..5d04fe8586a25c 100644 --- a/x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js +++ b/x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js @@ -326,7 +326,6 @@ export class FollowerIndicesTable extends PureComponent { pagination={pagination} sorting={sorting} selection={selection} - isSelectable={true} rowProps={() => ({ 'data-test-subj': 'row', })} diff --git a/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx b/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx index 8e12f94d8c3ab8..a2140ec3745b68 100644 --- a/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx +++ b/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx @@ -482,7 +482,6 @@ export const DataVisualizerTable = ({ pagination={pagination} sorting={sorting} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isSelectable={false} onTableChange={onTableChange} data-test-subj={`dataVisualizerTable-${loading ? 'loading' : 'loaded'}`} rowProps={(item) => ({ diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx index 7f3880947782c8..fd9a27ed66f013 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx @@ -335,7 +335,6 @@ export const PackagePoliciesTable: React.FunctionComponent = ({ }, ], }} - isSelectable={false} /> ); }; diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx index a3b1102e60bef0..cdd804f60d4847 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx @@ -307,7 +307,6 @@ export const AgentPolicyListPage: React.FunctionComponent<{}> = () => { items={agentPolicyData ? agentPolicyData.items : []} itemId="id" columns={columns} - isSelectable={false} pagination={{ pageIndex: pagination.currentPage - 1, pageSize: pagination.pageSize, diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx index 7b0d9135601a25..1a1320e8b942a2 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx @@ -337,7 +337,6 @@ export const AgentListTable: React.FC = (props: Props) => { totalItemCount: totalAgents, pageSizeOptions, }} - isSelectable={true} selection={ !authz.fleet.allAgents ? undefined diff --git a/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx b/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx index 7f6eb875664103..68e6e9b74f4c28 100644 --- a/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx +++ b/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx @@ -131,7 +131,6 @@ export const ComponentTable: FunctionComponent = ({ const tableProps: EuiInMemoryTableProps = { tableLayout: 'auto', itemId: 'name', - isSelectable: true, 'data-test-subj': 'componentTemplatesTable', sorting: { sort: { field: 'name', direction: 'asc' } }, selection: { diff --git a/x-pack/plugins/index_management/public/application/sections/home/data_stream_list/data_stream_table/data_stream_table.tsx b/x-pack/plugins/index_management/public/application/sections/home/data_stream_list/data_stream_table/data_stream_table.tsx index 97293c9a5f13b7..8fc1e46bf06883 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/data_stream_list/data_stream_table/data_stream_table.tsx +++ b/x-pack/plugins/index_management/public/application/sections/home/data_stream_list/data_stream_table/data_stream_table.tsx @@ -271,7 +271,6 @@ export const DataStreamTable: React.FunctionComponent = ({ columns={columns} search={searchConfig} sorting={sorting} - isSelectable={true} selection={selectionConfig} pagination={pagination} rowProps={() => ({ diff --git a/x-pack/plugins/index_management/public/application/sections/home/enrich_policies_list/policies_table/policies_table.tsx b/x-pack/plugins/index_management/public/application/sections/home/enrich_policies_list/policies_table/policies_table.tsx index 50140898ee0904..ad0106869361fc 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/enrich_policies_list/policies_table/policies_table.tsx +++ b/x-pack/plugins/index_management/public/application/sections/home/enrich_policies_list/policies_table/policies_table.tsx @@ -169,7 +169,6 @@ export const PoliciesTable: FunctionComponent = ({ search={search} pagination={pagination} sorting={true} - isSelectable={false} /> ); }; diff --git a/x-pack/plugins/index_management/public/application/sections/home/template_list/legacy_templates/template_table/template_table.tsx b/x-pack/plugins/index_management/public/application/sections/home/template_list/legacy_templates/template_table/template_table.tsx index 136fa6a63fa417..a390c28e784809 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/template_list/legacy_templates/template_table/template_table.tsx +++ b/x-pack/plugins/index_management/public/application/sections/home/template_list/legacy_templates/template_table/template_table.tsx @@ -281,7 +281,6 @@ export const LegacyTemplateTable: React.FunctionComponent = ({ columns={columns} search={searchConfig} sorting={sorting} - isSelectable={true} selection={selectionConfig} pagination={pagination} rowProps={() => ({ diff --git a/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx b/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx index 4a08a93c9a0c4d..775bc8aa34ff82 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx +++ b/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx @@ -282,7 +282,6 @@ export const TemplateTable: React.FunctionComponent = ({ columns={columns} search={searchConfig} sorting={sorting} - isSelectable={true} selection={selectionConfig} pagination={pagination} rowProps={() => ({ diff --git a/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/table.tsx b/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/table.tsx index f689f55e997426..8c50cc885e0731 100644 --- a/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/table.tsx +++ b/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/table.tsx @@ -114,7 +114,6 @@ export const PipelineTable: FunctionComponent = ({ const tableProps: EuiInMemoryTableProps = { itemId: 'name', - isSelectable: true, 'data-test-subj': 'pipelinesTable', sorting: { sort: { field: 'name', direction: 'asc' } }, selection: { diff --git a/x-pack/plugins/logstash/public/application/components/pipeline_list/pipelines_table.js b/x-pack/plugins/logstash/public/application/components/pipeline_list/pipelines_table.js index 002c4818e08150..95a68649b052e4 100644 --- a/x-pack/plugins/logstash/public/application/components/pipeline_list/pipelines_table.js +++ b/x-pack/plugins/logstash/public/application/components/pipeline_list/pipelines_table.js @@ -186,7 +186,6 @@ function PipelinesTableUi({ = ({ allowNeutralSort={false} columns={columns} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isSelectable={false} items={analytics} itemId={DataFrameAnalyticsListColumn.id} loading={isLoading} diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/components/analytics_selector/analytics_id_selector.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/components/analytics_selector/analytics_id_selector.tsx index cbfe96f14ff9d8..7878e58193b89c 100644 --- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/components/analytics_selector/analytics_id_selector.tsx +++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/components/analytics_selector/analytics_id_selector.tsx @@ -238,7 +238,6 @@ export function AnalyticsIdSelector({ pagination={pagination} sorting={true} selection={selectionValue} - isSelectable={true} /> ), }, @@ -259,7 +258,6 @@ export function AnalyticsIdSelector({ pagination={pagination} sorting={true} selection={selectionValue} - isSelectable={true} /> ), }); diff --git a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx index 6551b3af184270..f0ff64eae64457 100644 --- a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx +++ b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx @@ -257,7 +257,6 @@ export const AllocatedModels: FC = ({ allowNeutralSort={false} columns={columns} - isSelectable={false} items={models} itemId={'key'} rowProps={(item) => ({ diff --git a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx index 69888cb74bf533..c6632adcefccf0 100644 --- a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx +++ b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx @@ -221,7 +221,6 @@ export const NodesList: FC = ({ compactView = false }) => { allowNeutralSort={false} columns={columns} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isSelectable={false} items={items} itemId={'id'} loading={isLoading} diff --git a/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx b/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx index a052b8edf34df7..904fe5bcbe09c0 100644 --- a/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx +++ b/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx @@ -170,7 +170,6 @@ export const ProcessorsStats: FC = ({ stats }) => { allowNeutralSort={false} columns={columns} - isSelectable={false} items={items} itemId={'id'} rowProps={(item) => ({ diff --git a/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx b/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx index 8e632ed0b4e6fd..cb2f64c69050b0 100644 --- a/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx +++ b/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx @@ -397,7 +397,6 @@ export const NotificationsList: FC = () => { columns={columns} - isSelectable={false} items={itemsPerPage} itemId={'id'} loading={isLoading} diff --git a/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx b/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx index 8ccb4ad244144e..5e24dd230ae820 100644 --- a/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx +++ b/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx @@ -112,7 +112,6 @@ export const AnalyticsTable: FC = ({ items }) => { allowNeutralSort={false} className="mlAnalyticsTable" columns={columns} - isSelectable={false} items={items} itemId={DataFrameAnalyticsListColumn.id} onTableChange={onTableChange} diff --git a/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx b/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx index 7ee2620b845b13..5531c1a4b578e4 100644 --- a/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx +++ b/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx @@ -186,7 +186,6 @@ export const AnomalyDetectionTable: FC = ({ items, chartsService }) => { allowNeutralSort={false} className="mlAnomalyDetectionTable" columns={columns} - isSelectable={false} items={groupsList} itemId={AnomalyDetectionListColumns.id} onTableChange={onTableChange} diff --git a/x-pack/plugins/ml/public/application/settings/calendars/list/table/table.js b/x-pack/plugins/ml/public/application/settings/calendars/list/table/table.js index 374ab80da118f7..e9240557d2a688 100644 --- a/x-pack/plugins/ml/public/application/settings/calendars/list/table/table.js +++ b/x-pack/plugins/ml/public/application/settings/calendars/list/table/table.js @@ -142,7 +142,6 @@ export const CalendarsListTable = ({ sorting={sorting} loading={loading} selection={tableSelection} - isSelectable={true} data-test-subj={loading ? 'mlCalendarTable loading' : 'mlCalendarTable loaded'} rowProps={(item) => ({ 'data-test-subj': `mlCalendarListRow row-${item.calendar_id}`, diff --git a/x-pack/plugins/ml/public/application/settings/filter_lists/list/table.js b/x-pack/plugins/ml/public/application/settings/filter_lists/list/table.js index 6eadf71e4e7253..a97c70d8c1a2c1 100644 --- a/x-pack/plugins/ml/public/application/settings/filter_lists/list/table.js +++ b/x-pack/plugins/ml/public/application/settings/filter_lists/list/table.js @@ -213,7 +213,6 @@ export function FilterListsTable({ pagination={true} sorting={sorting} selection={tableSelection} - isSelectable={true} data-test-subj="mlFilterListsTable" rowProps={(item) => ({ 'data-test-subj': `mlFilterListRow row-${item.filter_id}`, diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/table.tsx b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/table.tsx index 2629a00318da6c..e4ef50266de2df 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/table.tsx +++ b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/table.tsx @@ -81,7 +81,6 @@ export const Table = () => { onChange={onTableChange} pagination={pagination} data-test-subj="datasetQualityTable" - isSelectable rowProps={{ 'data-test-subj': 'datasetQualityTableRow', }} diff --git a/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx b/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx index eaa1a14f373800..ab4fd6a1b79c51 100644 --- a/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx @@ -42,7 +42,6 @@ export const HostsTable = () => { ); diff --git a/x-pack/plugins/reporting/public/management/report_listing_table.tsx b/x-pack/plugins/reporting/public/management/report_listing_table.tsx index 0b07ae38697e9f..5cb113693c9152 100644 --- a/x-pack/plugins/reporting/public/management/report_listing_table.tsx +++ b/x-pack/plugins/reporting/public/management/report_listing_table.tsx @@ -421,7 +421,6 @@ export class ReportListingTable extends Component { } pagination={pagination} selection={selection} - isSelectable={true} onChange={this.onTableChange} data-test-subj={REPORT_TABLE_ID} rowProps={() => ({ 'data-test-subj': REPORT_TABLE_ROW_ID })} diff --git a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx index 438abc4c53c46e..3b7a082673d8f2 100644 --- a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx +++ b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx @@ -289,7 +289,6 @@ export class RoleMappingsGridPage extends Component { pagination={pagination} loading={loadState === 'loadingTable'} message={message} - isSelectable={true} rowProps={() => { return { 'data-test-subj': 'roleMappingRow', diff --git a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx index 34546a74639e43..3d7cb8d6478625 100644 --- a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx +++ b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx @@ -191,7 +191,6 @@ export class RolesGridPage extends Component { 'data-test-subj': `roleRow`, }; }} - isSelectable /> diff --git a/x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx b/x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx index 071de42046706a..a9861850cf13e0 100644 --- a/x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx +++ b/x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx @@ -282,7 +282,6 @@ export class UsersGridPage extends Component { search={search} sorting={sorting} rowProps={rowProps} - isSelectable /> } diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_list/index.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_list/index.tsx index 94ceb9337e674c..87a735e4428550 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_list/index.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_list/index.tsx @@ -61,7 +61,6 @@ const ExceptionsLinkedToListsComponent: React.FC diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx index e64645e967cc21..22794ab525dca2 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx @@ -86,7 +86,6 @@ export const AddPrebuiltRulesTable = React.memo(() => { initialPageSize: RULES_TABLE_INITIAL_PAGE_SIZE, pageSizeOptions: RULES_TABLE_PAGE_SIZE_OPTIONS, }} - isSelectable selection={{ selectable: () => true, onSelectionChange: selectRules, diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/upgrade_prebuilt_rules_table/upgrade_prebuilt_rules_table.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/upgrade_prebuilt_rules_table/upgrade_prebuilt_rules_table.tsx index c1468b458e339d..09b231403b10a1 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/upgrade_prebuilt_rules_table/upgrade_prebuilt_rules_table.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/upgrade_prebuilt_rules_table/upgrade_prebuilt_rules_table.tsx @@ -108,7 +108,6 @@ export const UpgradePrebuiltRulesTable = React.memo(() => { initialPageSize: RULES_TABLE_INITIAL_PAGE_SIZE, pageSizeOptions: RULES_TABLE_PAGE_SIZE_OPTIONS, }} - isSelectable selection={{ selectable: () => true, onSelectionChange: selectRules, diff --git a/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.tsx b/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.tsx index 6c2e3fc008cfb0..84fba825b59652 100644 --- a/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.tsx +++ b/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.tsx @@ -88,13 +88,7 @@ export const AlertsCountComponent: React.FC = ({ return ( - + ); }; diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx index c77de4b1d46235..21428eedc2a57f 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx @@ -194,7 +194,6 @@ export const RiskInputsTab = ({ entityType, entityName }: RiskInputsTabProps) => sorting selection={euiTableSelectionProps} onTableChange={onTableChange} - isSelectable itemId="_id" /> diff --git a/x-pack/plugins/security_solution/public/timelines/components/row_renderers_browser/row_renderers_browser.tsx b/x-pack/plugins/security_solution/public/timelines/components/row_renderers_browser/row_renderers_browser.tsx index 3377924c1acd39..d423463895153f 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/row_renderers_browser/row_renderers_browser.tsx +++ b/x-pack/plugins/security_solution/public/timelines/components/row_renderers_browser/row_renderers_browser.tsx @@ -157,7 +157,6 @@ const RowRenderersBrowserComponent = ({ columns={columns} search={search} sorting={initialSorting} - isSelectable={true} /> ); }; diff --git a/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_table/policy_table.tsx b/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_table/policy_table.tsx index 0e56c47abc4302..2097a139adebe9 100644 --- a/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_table/policy_table.tsx +++ b/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_table/policy_table.tsx @@ -418,7 +418,6 @@ export const PolicyTable: React.FunctionComponent = ({ sorting={sorting} selection={selection} pagination={pagination} - isSelectable={true} rowProps={() => ({ 'data-test-subj': 'row', })} diff --git a/x-pack/plugins/snapshot_restore/public/application/sections/home/repository_list/repository_table/repository_table.tsx b/x-pack/plugins/snapshot_restore/public/application/sections/home/repository_list/repository_table/repository_table.tsx index abfd7e6f1b6248..a6fb6b10ae4a0e 100644 --- a/x-pack/plugins/snapshot_restore/public/application/sections/home/repository_list/repository_table/repository_table.tsx +++ b/x-pack/plugins/snapshot_restore/public/application/sections/home/repository_list/repository_table/repository_table.tsx @@ -300,7 +300,6 @@ export const RepositoryTable: React.FunctionComponent = ({ sorting={sorting} selection={selection} pagination={pagination} - isSelectable={true} rowProps={() => ({ 'data-test-subj': 'row', })} diff --git a/x-pack/plugins/snapshot_restore/public/application/sections/home/snapshot_list/components/snapshot_table.tsx b/x-pack/plugins/snapshot_restore/public/application/sections/home/snapshot_list/components/snapshot_table.tsx index 1272d841173c6c..7204bb4bc3895b 100644 --- a/x-pack/plugins/snapshot_restore/public/application/sections/home/snapshot_list/components/snapshot_table.tsx +++ b/x-pack/plugins/snapshot_restore/public/application/sections/home/snapshot_list/components/snapshot_table.tsx @@ -330,7 +330,6 @@ export const SnapshotTable: React.FunctionComponent = (props: Props) => { }); }} loading={isLoading} - isSelectable={true} selection={selection} pagination={pagination} rowProps={() => ({ diff --git a/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx b/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx index e75d2ac3dc06ff..71e631ee62e4eb 100644 --- a/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx +++ b/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx @@ -356,7 +356,6 @@ export const TransformList: FC = ({ className="transform__TransformTable" columns={columns} error={searchError} - isSelectable={false} items={filteredTransforms} itemId={TRANSFORM_LIST_COLUMN.ID} itemIdToExpandedRowMap={itemIdToExpandedRowMap} diff --git a/x-pack/plugins/watcher/public/application/sections/watch_list_page/watch_list_page.tsx b/x-pack/plugins/watcher/public/application/sections/watch_list_page/watch_list_page.tsx index 37d73d0c8a25ae..2a3dc8fc094445 100644 --- a/x-pack/plugins/watcher/public/application/sections/watch_list_page/watch_list_page.tsx +++ b/x-pack/plugins/watcher/public/application/sections/watch_list_page/watch_list_page.tsx @@ -515,7 +515,6 @@ export const WatchListPage = () => { }, }} selection={selectionConfig} - isSelectable={true} childrenBetween={ queryError && ( <> From 5ac19138636c371922cc140df26b1b1e1a97c8f4 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Tue, 9 Apr 2024 14:05:43 -0700 Subject: [PATCH 09/33] Remove `isSelectable` conditional table props - basic validation against `selection` conditionals, if they existed - either way, this only affects responsive table views + remove unit test that no longer applies --- .../components/index_pattern_table/index_pattern_table.tsx | 1 - .../drilldown_template_table/drilldown_template_table.tsx | 3 +-- .../public/components/all_cases/all_cases_list.test.tsx | 7 ------- x-pack/plugins/cases/public/components/all_cases/table.tsx | 1 - .../components/settings/global_params/params_list.tsx | 1 - x-pack/plugins/osquery/public/packs/pack_queries_table.tsx | 2 +- .../api_keys/api_keys_grid/api_keys_grid_page.tsx | 1 - .../components/rules_table/rules_tables.tsx | 1 - .../components/open_timeline/timelines_table/index.tsx | 1 - 9 files changed, 2 insertions(+), 16 deletions(-) diff --git a/src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx b/src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx index f2d5c8d18aa0e9..044904d96eea39 100644 --- a/src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx +++ b/src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx @@ -340,7 +340,6 @@ export const IndexPatternTable = ({ = ({ <> { }); }); - it('case table should not be selectable when isSelectorView=true', async () => { - appMockRenderer.render(); - await waitFor(() => { - expect(screen.queryByTestId('cases-table')).not.toHaveAttribute('isSelectable'); - }); - }); - it('should call onRowClick with no cases and isSelectorView=true when create case is clicked', async () => { appMockRenderer.render(); userEvent.click(screen.getByTestId('cases-table-add-case-filter-bar')); diff --git a/x-pack/plugins/cases/public/components/all_cases/table.tsx b/x-pack/plugins/cases/public/components/all_cases/table.tsx index 61b917ef987174..022753a2899c43 100644 --- a/x-pack/plugins/cases/public/components/all_cases/table.tsx +++ b/x-pack/plugins/cases/public/components/all_cases/table.tsx @@ -82,7 +82,6 @@ export const CasesTable: FunctionComponent = ({ className={classnames({ isSelectorView })} columns={columns} data-test-subj="cases-table" - isSelectable={!isSelectorView} itemId="id" items={data.cases} loading={isCommentUpdating} diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/settings/global_params/params_list.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/settings/global_params/params_list.tsx index 58769a7e688fea..d72d92156e42e7 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/settings/global_params/params_list.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/settings/global_params/params_list.tsx @@ -240,7 +240,6 @@ export const ParamsList = () => { items={filteredItems} columns={columns} tableLayout="auto" - isSelectable={canSave} pagination={true} sorting={{ sort: { field: 'key', direction: 'asc' }, diff --git a/x-pack/plugins/osquery/public/packs/pack_queries_table.tsx b/x-pack/plugins/osquery/public/packs/pack_queries_table.tsx index 60569ebaf184ae..f3a76e98a46268 100644 --- a/x-pack/plugins/osquery/public/packs/pack_queries_table.tsx +++ b/x-pack/plugins/osquery/public/packs/pack_queries_table.tsx @@ -181,7 +181,7 @@ const PackQueriesTableComponent: React.FC = ({ itemId={itemId} columns={columns} sorting={sorting} - {...(!isReadOnly ? { selection, isSelectable: true } : {})} + selection={isReadOnly ? undefined : selection} /> ); }; diff --git a/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx b/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx index 834c4d4fd60545..0f717ecfe46c9d 100644 --- a/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx +++ b/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx @@ -518,7 +518,6 @@ export const ApiKeysTable: FunctionComponent = ({ pageSizeOptions: [10, 25, 50], }} loading={loading} - isSelectable={canManageOwnApiKeys} /> ); }; diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_tables.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_tables.tsx index 707846c8a492a1..4dfac4c0c2c39c 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_tables.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_tables.tsx @@ -297,7 +297,6 @@ export const RulesTables = React.memo(({ selectedTab }) => { ( Date: Tue, 9 Apr 2024 14:07:12 -0700 Subject: [PATCH 10/33] [EuiTableRow] `isSelectable` prop update - `isSelectable` now indicates whether the checkbox is disabled or enabled; `hasSelection` (new prop) determines visual checkbox affordance --- test/functional/services/listing_table.ts | 10 +++------- .../home/index_list/index_table/index_table.js | 1 + .../custom_selection_table/custom_selection_table.js | 2 +- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/test/functional/services/listing_table.ts b/test/functional/services/listing_table.ts index 98841ea996d2a3..61da3756a3d2a2 100644 --- a/test/functional/services/listing_table.ts +++ b/test/functional/services/listing_table.ts @@ -69,14 +69,10 @@ export class ListingTableService extends FtrService { private async getAllSelectableItemsNamesOnCurrentPage(): Promise { const visualizationNames = []; - // TODO - use .euiTableRow-isSelectable when it's working again (https://github.com/elastic/eui/issues/7515) - const rows = await this.find.allByCssSelector('.euiTableRow'); + const rows = await this.find.allByCssSelector('.euiTableRow-isSelectable'); for (let i = 0; i < rows.length; i++) { - const checkbox = await rows[i].findByCssSelector('.euiCheckbox__input'); - if (await checkbox.isEnabled()) { - const link = await rows[i].findByCssSelector('.euiLink'); - visualizationNames.push(await link.getVisibleText()); - } + const link = await rows[i].findByCssSelector('.euiLink'); + visualizationNames.push(await link.getVisibleText()); } this.log.debug(`Found ${visualizationNames.length} selectable visualizations on current page`); return visualizationNames; diff --git a/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js b/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js index bdeb31a55343d3..5405f925101968 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js +++ b/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js @@ -437,6 +437,7 @@ export class IndexTable extends Component { data-test-subj="indexTableRow" isSelected={this.isItemSelected(name)} isSelectable + hasSelection key={`${name}-row`} > diff --git a/x-pack/plugins/ml/public/application/components/custom_selection_table/custom_selection_table.js b/x-pack/plugins/ml/public/application/components/custom_selection_table/custom_selection_table.js index a592fb571a03e3..d1597cce0fb081 100644 --- a/x-pack/plugins/ml/public/application/components/custom_selection_table/custom_selection_table.js +++ b/x-pack/plugins/ml/public/application/components/custom_selection_table/custom_selection_table.js @@ -325,7 +325,7 @@ export function CustomSelectionTable({ From 3db5f8ced04e020d448e3d1ef6faad8fb611cd1a Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Tue, 9 Apr 2024 14:09:03 -0700 Subject: [PATCH 11/33] [EuiTables] Misc syntax cleanups/chores - remove unnecessary props that already default to false - various syntax nits - small CSS fixes --- .../public/components/doc_viewer_table/legacy/table.tsx | 1 - .../change_point_detection/change_points_table.tsx | 2 +- .../components/stats_table/data_visualizer_stats_table.tsx | 2 +- .../common/monitor_test_result/browser_steps_list.tsx | 2 +- .../monitor_details/monitor_summary/test_runs_table.tsx | 3 +-- .../management/monitor_list_table/monitor_list.tsx | 7 ++----- .../waterfall/waterfall_flyout/waterfall_flyout_table.tsx | 2 +- .../test_now_mode/simple/ping_list/ping_list_table.tsx | 2 +- .../components/monitor/ping_list/ping_list_table.tsx | 2 +- .../waterfall/components/waterfall_flyout_table.tsx | 2 +- .../components/overview/monitor_list/monitor_list.tsx | 2 +- .../components/synthetics/check_steps/steps_list.tsx | 2 +- .../tabs/risk_inputs/risk_inputs_tab.tsx | 2 +- 13 files changed, 13 insertions(+), 18 deletions(-) diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx index aaa14e45d89768..deb5e5a52fb7a1 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx @@ -116,7 +116,6 @@ export const DocViewerLegacyTable = ({ items={items} columns={tableColumns} rowProps={onSetRowProps} - pagination={false} responsiveBreakpoint={false} /> ); diff --git a/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx b/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx index 078c9c1e39c6f3..e94db623362351 100644 --- a/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx +++ b/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx @@ -313,7 +313,7 @@ export const ChangePointsTable: FC = ({ return ( - itemId={'id'} + itemId="id" selection={selectionValue} loading={isLoading} data-test-subj={`aiopsChangePointResultsTable ${isLoading ? 'loading' : 'loaded'}`} diff --git a/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx b/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx index a2140ec3745b68..9f52a00a3b2be3 100644 --- a/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx +++ b/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx @@ -395,7 +395,7 @@ export const DataVisualizerTable = ({ backgroundColor: euiTheme.colors.emptyShade, boxShadow: `inset 0 0px 0, inset 0 -1px 0 ${euiTheme.border.color}`, }, - '.euiTableRow > .euiTableRowCel': { + '.euiTableRow > .euiTableRowCell': { borderTop: 0, }, [useEuiMinBreakpoint('s')]: { diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx index c514850b2c7eb0..114b206f95b249 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx @@ -308,7 +308,7 @@ export const BrowserStepsList = ({ defaultMessage: 'No data found', }) } - tableLayout={'auto'} + tableLayout="auto" itemId="_id" itemIdToExpandedRowMap={testNowMode || showExpand ? expandedMap : undefined} /> diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx index edaf7ca2e7ad24..f2d50b165d9524 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx @@ -295,13 +295,12 @@ export const TestRunsTable = ({ itemId="docId" itemIdToExpandedRowMap={expandedRows} css={{ overflowX: isTabletOrGreater ? 'auto' : undefined }} - compressed={false} loading={pingsLoading} columns={columns} error={pingsError?.body?.message} items={sortedPings} noItemsMessage={pingsLoading ? LOADING_TEST_RUNS : NO_DATA_FOUND} - tableLayout={'auto'} + tableLayout="auto" sorting={sorting} onChange={handleTableChange} rowProps={getRowProps} diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitors_page/management/monitor_list_table/monitor_list.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitors_page/management/monitor_list_table/monitor_list.tsx index 0290db34ddc2c7..180b6299bfa4f6 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitors_page/management/monitor_list_table/monitor_list.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitors_page/management/monitor_list_table/monitor_list.tsx @@ -11,8 +11,7 @@ import { EuiBasicTable, EuiTableSortingType, EuiPanel, - EuiSpacer, - useEuiTheme, + EuiHorizontalRule, useIsWithinMinBreakpoint, } from '@elastic/eui'; import { i18n } from '@kbn/i18n'; @@ -50,7 +49,6 @@ export const MonitorList = ({ loadPage, reloadPage, }: Props) => { - const { euiTheme } = useEuiTheme(); const isXl = useIsWithinMinBreakpoint('xxl'); const [monitorPendingDeletion, setMonitorPendingDeletion] = @@ -104,8 +102,7 @@ export const MonitorList = ({ <> {recordRangeLabel} - -
+ { ); diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx index 9919935ba78b58..90c878d0982f5a 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx @@ -239,7 +239,7 @@ export function PingListTable({ loading, error, pings, pagination, onChange, fai defaultMessage: 'No history found', }) } - tableLayout={'auto'} + tableLayout="auto" rowProps={getRowProps} onChange={onChange} /> diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/synthetics/waterfall/components/waterfall_flyout_table.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/synthetics/waterfall/components/waterfall_flyout_table.tsx index 813068250d55a9..e05089d3b1537f 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/synthetics/waterfall/components/waterfall_flyout_table.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/synthetics/waterfall/components/waterfall_flyout_table.tsx @@ -67,7 +67,7 @@ export const Table = (props: Props) => { } columns={columns} - tableLayout={'auto'} + tableLayout="auto" rowProps={ hideExtraColumns ? ({ monitor_id: monitorId }) => ({ diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx index 964ce6869a4874..70ffc6d7be859d 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx @@ -247,7 +247,7 @@ export const StepsList = ({ defaultMessage: 'No history found', }) } - tableLayout={'auto'} + tableLayout="auto" rowProps={getRowProps} /> diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx index 21428eedc2a57f..e7c960ed995122 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx @@ -186,7 +186,7 @@ export const RiskInputsTab = ({ entityType, entityName }: RiskInputsTabProps) => Date: Tue, 9 Apr 2024 18:04:45 -0700 Subject: [PATCH 12/33] Remove direct references to table classNames - they no longer have styles attached to them and thus no longer do anything - replace with direct component usage instead (or in some cases remove if they're not doing anything) --- .../dashboard_sections/benchmarks_section.tsx | 2 +- .../detail/overview/markdown_renderers.tsx | 4 +-- .../index_list/index_table/index_table.js | 15 +-------- .../components/jobs_list/jobs_list.js | 11 +++---- .../components/message_panel/message_text.tsx | 31 ++++++------------- .../get_comments/stream/message_text.tsx | 31 ++++++------------- 6 files changed, 27 insertions(+), 67 deletions(-) diff --git a/x-pack/plugins/cloud_security_posture/public/pages/compliance_dashboard/dashboard_sections/benchmarks_section.tsx b/x-pack/plugins/cloud_security_posture/public/pages/compliance_dashboard/dashboard_sections/benchmarks_section.tsx index fa9b53ff06c110..8b61b3f093b70b 100644 --- a/x-pack/plugins/cloud_security_posture/public/pages/compliance_dashboard/dashboard_sections/benchmarks_section.tsx +++ b/x-pack/plugins/cloud_security_posture/public/pages/compliance_dashboard/dashboard_sections/benchmarks_section.tsx @@ -133,7 +133,7 @@ export const BenchmarksSection = ({ id="xpack.csp.dashboard.benchmarkSection.columnsHeader.complianceScoreTitle" defaultMessage="Compliance Score" /> - +
diff --git a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/markdown_renderers.tsx b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/markdown_renderers.tsx index 6dc1415b6416d9..067d35414c00b7 100644 --- a/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/markdown_renderers.tsx +++ b/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/markdown_renderers.tsx @@ -56,9 +56,7 @@ export const markdownRenderers = ( refs: MutableRefObject> ): TransformOptions['components'] => { return { - table: ({ children }) => ( - {children} - ), + table: ({ children }) => {children}, tr: ({ children }) => {children}, th: ({ children }) => {children}, td: ({ children }) => {children}, diff --git a/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js b/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js index 5405f925101968..8ad11dbdbeb80a 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js +++ b/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js @@ -374,24 +374,11 @@ export class IndexTable extends Component { return columnConfigs.map((columnConfig) => { const { name } = index; const { fieldName } = columnConfig; - if (fieldName === 'name') { - return ( - -
- {this.buildRowCell(index, columnConfig)} -
- - ); - } return ( ( - - {item.latestTimestampMs === undefined - ? '' - : moment(item.latestTimestampMs).format(TIME_FORMAT)} - - ), + render: (time, item) => + item.latestTimestampMs === undefined + ? '' + : moment(item.latestTimestampMs).format(TIME_FORMAT), textOnly: true, width: '15%', }, diff --git a/x-pack/plugins/observability_solution/observability_ai_assistant/public/components/message_panel/message_text.tsx b/x-pack/plugins/observability_solution/observability_ai_assistant/public/components/message_panel/message_text.tsx index a4d8532205fa8e..337ae9503fe658 100644 --- a/x-pack/plugins/observability_solution/observability_ai_assistant/public/components/message_panel/message_text.tsx +++ b/x-pack/plugins/observability_solution/observability_ai_assistant/public/components/message_panel/message_text.tsx @@ -5,6 +5,10 @@ * 2.0. */ import { + EuiTable, + EuiTableRow, + EuiTableRowCell, + EuiTableHeaderCell, EuiMarkdownFormat, EuiSpacer, EuiText, @@ -141,36 +145,21 @@ export function MessageText({ loading, content, onActionClick }: Props) { }, table: (props) => ( <> -
- {' '} - - + ), th: (props) => { const { children, ...rest } = props; - return ( - - ); + return {children}; }, - tr: (props) => , + tr: (props) => , td: (props) => { const { children, ...rest } = props; return ( - + + {children} + ); }, }; diff --git a/x-pack/plugins/security_solution/public/assistant/get_comments/stream/message_text.tsx b/x-pack/plugins/security_solution/public/assistant/get_comments/stream/message_text.tsx index 415800a04609d8..c249a631afc283 100644 --- a/x-pack/plugins/security_solution/public/assistant/get_comments/stream/message_text.tsx +++ b/x-pack/plugins/security_solution/public/assistant/get_comments/stream/message_text.tsx @@ -5,6 +5,10 @@ * 2.0. */ import { + EuiTable, + EuiTableRow, + EuiTableRowCell, + EuiTableHeaderCell, EuiMarkdownFormat, EuiSpacer, EuiText, @@ -114,36 +118,21 @@ const getPluginDependencies = () => { }, table: (props) => ( <> -
- {' '} -
- - - {children} - - -
-
- - {children} - -
-
- + ), th: (props) => { const { children, ...rest } = props; - return ( - - ); + return {children}; }, - tr: (props) => , + tr: (props) => , td: (props) => { const { children, ...rest } = props; return ( - + + {children} + ); }, }; From cdc3fbd69f56da46f40bb16e06b16829f85e7c78 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 10 Apr 2024 10:03:56 -0700 Subject: [PATCH 13/33] Remove deprecated `showOnHover` column API and direct className usage - replace with custom CSS instead for now, with a comment --- .../tabs/metadata/add_pin_to_row.tsx | 21 +++++++++++++++++-- .../asset_details/tabs/metadata/table.tsx | 3 --- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_pin_to_row.tsx b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_pin_to_row.tsx index 1e5e31b887911c..42245552b664c3 100644 --- a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_pin_to_row.tsx +++ b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_pin_to_row.tsx @@ -6,8 +6,9 @@ */ import React, { Dispatch } from 'react'; +import { css } from '@emotion/css'; import { i18n } from '@kbn/i18n'; -import { EuiToolTip, EuiButtonIcon } from '@elastic/eui'; +import { EuiToolTip, EuiButtonIcon, useEuiTheme, euiCanAnimate } from '@elastic/eui'; import type { Field } from './utils'; interface AddMetadataPinToRowProps { @@ -25,6 +26,8 @@ export const AddMetadataPinToRow = ({ pinnedItems, onPinned, }: AddMetadataPinToRowProps) => { + const { euiTheme } = useEuiTheme(); + const handleAddPin = () => { onPinned([...pinnedItems, fieldName]); }; @@ -58,8 +61,22 @@ export const AddMetadataPinToRow = ({ ); } + // Custom table show on hover CSS, since this button is not technically in an action column + // Potential EUI TODO - multiple action columns and `align`ed actions are not currently supported + const showOnRowHoverCss = css` + opacity: 0; + ${euiCanAnimate} { + transition: opacity ${euiTheme.animation.normal} ${euiTheme.animation.resistance}; + } + + .euiTableRow:hover &, + &:focus-within { + opacity: 1; + } + `; + return ( - + { return ( { return ; @@ -176,7 +174,6 @@ export const Table = ({ loading, rows, onSearchChange, search, showActionsColumn responsiveBreakpoint={false} columns={columns} items={fieldsWithPins} - rowProps={{ className: 'euiTableRow-hasActions' }} search={searchBar} loading={loading} error={searchError ? `${searchError.message}` : ''} From 7284869586c36a4e403707e2c837bb38d5add9be Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 10 Apr 2024 10:28:05 -0700 Subject: [PATCH 14/33] [Security] Replace role tables' custom actions/CSS with default actions - now that EuiBasicTable's default actions supports passing the item to `href` as well as the click event to `onClick` --- .../role_mappings_grid_page.test.tsx | 34 +-- .../role_mappings_grid_page.tsx | 174 +++++-------- .../roles/roles_grid/roles_grid_page.test.tsx | 22 +- .../roles/roles_grid/roles_grid_page.tsx | 242 ++++++++---------- .../public/management/table_utils.tsx | 37 --- 5 files changed, 183 insertions(+), 326 deletions(-) delete mode 100644 x-pack/plugins/security/public/management/table_utils.tsx diff --git a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.test.tsx b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.test.tsx index bebc0619e2a689..7f2182e1a7e671 100644 --- a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.test.tsx +++ b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.test.tsx @@ -292,28 +292,22 @@ describe('RoleMappingsGridPage', () => { await nextTick(); wrapper.update(); - const editButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="editRoleMappingButton-some-realm"]' - ); + const editButton = wrapper.find('a[data-test-subj="editRoleMappingButton-some-realm"]'); expect(editButton).toHaveLength(1); expect(editButton.prop('href')).toBe('/edit/some-realm'); - const cloneButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="cloneRoleMappingButton-some-realm"]' - ); + const cloneButton = wrapper.find('a[data-test-subj="cloneRoleMappingButton-some-realm"]'); expect(cloneButton).toHaveLength(1); expect(cloneButton.prop('href')).toBe('/clone/some-realm'); - const actionMenuButton = wrapper.find( - 'EuiButtonIcon[data-test-subj="euiCollapsedItemActionsButton"]' - ); + const actionMenuButton = wrapper.find('button[data-test-subj="euiCollapsedItemActionsButton"]'); expect(actionMenuButton).toHaveLength(1); actionMenuButton.simulate('click'); wrapper.update(); const deleteButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="deleteRoleMappingButton-some-realm"]' + 'button[data-test-subj="deleteRoleMappingButton-some-realm"]' ); expect(deleteButton).toHaveLength(1); }); @@ -371,30 +365,22 @@ describe('RoleMappingsGridPage', () => { await nextTick(); wrapper.update(); - const bulkButton = wrapper.find('EuiButtonEmpty[data-test-subj="bulkDeleteActionButton"]'); + const bulkButton = wrapper.find('[data-test-subj="bulkDeleteActionButton"]'); expect(bulkButton).toHaveLength(0); - const createButton = wrapper.find('EuiButton[data-test-subj="createRoleMappingButton"]'); + const createButton = wrapper.find('[data-test-subj="createRoleMappingButton"]'); expect(createButton).toHaveLength(0); - const editButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="editRoleMappingButton-some-realm"]' - ); + const editButton = wrapper.find('[data-test-subj="editRoleMappingButton-some-realm"]'); expect(editButton).toHaveLength(0); - const cloneButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="cloneRoleMappingButton-some-realm"]' - ); + const cloneButton = wrapper.find('[data-test-subj="cloneRoleMappingButton-some-realm"]'); expect(cloneButton).toHaveLength(0); - const deleteButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="deleteRoleMappingButton-some-realm"]' - ); + const deleteButton = wrapper.find('[data-test-subj="deleteRoleMappingButton-some-realm"]'); expect(deleteButton).toHaveLength(0); - const actionMenuButton = wrapper.find( - 'EuiButtonIcon[data-test-subj="euiCollapsedItemActionsButton"]' - ); + const actionMenuButton = wrapper.find('[data-test-subj="euiCollapsedItemActionsButton"]'); expect(actionMenuButton).toHaveLength(0); }); }); diff --git a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx index 3b7a082673d8f2..4ddcb83abf7f3b 100644 --- a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx +++ b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx @@ -7,7 +7,6 @@ import type { EuiBasicTableColumn } from '@elastic/eui'; import { EuiButton, - EuiButtonEmpty, EuiCallOut, EuiFlexGroup, EuiFlexItem, @@ -16,7 +15,6 @@ import { EuiPageHeader, EuiPageSection, EuiSpacer, - EuiToolTip, } from '@elastic/eui'; import React, { Component } from 'react'; @@ -41,7 +39,6 @@ import { } from '../../management_urls'; import { RoleTableDisplay } from '../../role_table_display'; import type { RolesAPIClient } from '../../roles'; -import { ActionsEuiTableFormatting } from '../../table_utils'; import { DeleteProvider, NoCompatibleRealms, @@ -278,24 +275,22 @@ export class RoleMappingsGridPage extends Component { > {(deleteRoleMappingPrompt) => { return ( - - { - return { - 'data-test-subj': 'roleMappingRow', - }; - }} - /> - + { + return { + 'data-test-subj': 'roleMappingRow', + }; + }} + /> ); }} @@ -380,102 +375,63 @@ export class RoleMappingsGridPage extends Component { name: i18n.translate('xpack.security.management.roleMappings.actionsColumnName', { defaultMessage: 'Actions', }), - width: '80px', + width: '108px', actions: [ { isPrimary: true, - render: (record: RoleMapping) => { - const title = i18n.translate( - 'xpack.security.management.roleMappings.actionCloneTooltip', - { defaultMessage: 'Clone' } - ); - const label = i18n.translate( - 'xpack.security.management.roleMappings.actionCloneAriaLabel', - { - defaultMessage: `Clone '{name}'`, - values: { name: record.name }, - } - ); - return ( - - = 1} - {...reactRouterNavigate( - this.props.history, - getCloneRoleMappingHref(record.name) - )} - > - {title} - - - ); - }, + type: 'icon', + icon: 'copy', + name: i18n.translate('xpack.security.management.roleMappings.actionCloneTooltip', { + defaultMessage: 'Clone', + }), + description: (record: RoleMapping) => + i18n.translate('xpack.security.management.roleMappings.actionCloneAriaLabel', { + defaultMessage: `Clone '{name}'`, + values: { name: record.name }, + }), + href: (record: RoleMapping) => + reactRouterNavigate(this.props.history, getCloneRoleMappingHref(record.name)).href, + onClick: (record: RoleMapping, event: React.MouseEvent) => + reactRouterNavigate(this.props.history, getCloneRoleMappingHref(record.name)).onClick( + event + ), + 'data-test-subj': (record: RoleMapping) => `cloneRoleMappingButton-${record.name}`, }, { - render: (record: RoleMapping) => { - const title = i18n.translate( - 'xpack.security.management.roleMappings.actionDeleteTooltip', - { defaultMessage: 'Delete' } - ); - const label = i18n.translate( - 'xpack.security.management.roleMappings.actionDeleteAriaLabel', - { - defaultMessage: `Delete '{name}'`, - values: { name: record.name }, - } - ); - return ( - - = 1} - onClick={() => deleteRoleMappingPrompt([record], this.onRoleMappingsDeleted)} - > - {title} - - - ); - }, + type: 'icon', + icon: 'trash', + color: 'danger', + name: i18n.translate('xpack.security.management.roleMappings.actionDeleteTooltip', { + defaultMessage: 'Delete', + }), + description: (record: RoleMapping) => + i18n.translate('xpack.security.management.roleMappings.actionDeleteAriaLabel', { + defaultMessage: `Delete '{name}'`, + values: { name: record.name }, + }), + 'data-test-subj': (record: RoleMapping) => `deleteRoleMappingButton-${record.name}`, + onClick: (record: RoleMapping) => + deleteRoleMappingPrompt([record], this.onRoleMappingsDeleted), }, { isPrimary: true, - render: (record: RoleMapping) => { - const label = i18n.translate( - 'xpack.security.management.roleMappings.actionEditAriaLabel', - { - defaultMessage: `Edit '{name}'`, - values: { name: record.name }, - } - ); - const title = i18n.translate( - 'xpack.security.management.roleMappings.actionEditTooltip', - { defaultMessage: 'Edit' } - ); - return ( - - = 1} - {...reactRouterNavigate( - this.props.history, - getEditRoleMappingHref(record.name) - )} - > - {title} - - - ); - }, + type: 'icon', + icon: 'pencil', + name: i18n.translate('xpack.security.management.roleMappings.actionEditTooltip', { + defaultMessage: 'Edit', + }), + description: (record: RoleMapping) => + i18n.translate('xpack.security.management.roleMappings.actionEditAriaLabel', { + defaultMessage: `Edit '{name}'`, + values: { name: record.name }, + }), + 'data-test-subj': (record: RoleMapping) => `editRoleMappingButton-${record.name}`, + href: (record: RoleMapping) => + reactRouterNavigate(this.props.history, getEditRoleMappingHref(record.name)).href, + onClick: (record: RoleMapping, event: React.MouseEvent) => + reactRouterNavigate(this.props.history, getEditRoleMappingHref(record.name)).onClick( + event + ), }, ], }); diff --git a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.test.tsx b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.test.tsx index 6ca8dd1322cbff..ed6f28ea8321f0 100644 --- a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.test.tsx +++ b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.test.tsx @@ -144,34 +144,24 @@ describe('', () => { expect(wrapper.find(PermissionDenied)).toHaveLength(0); - let editButton = wrapper.find('EuiButtonEmpty[data-test-subj="edit-role-action-test-role-1"]'); + let editButton = wrapper.find('a[data-test-subj="edit-role-action-test-role-1"]'); expect(editButton).toHaveLength(1); expect(editButton.prop('href')).toBe('/edit/test-role-1'); - editButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="edit-role-action-special%chars%role"]' - ); + editButton = wrapper.find('a[data-test-subj="edit-role-action-special%chars%role"]'); expect(editButton).toHaveLength(1); expect(editButton.prop('href')).toBe('/edit/special%25chars%25role'); - let cloneButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="clone-role-action-test-role-1"]' - ); + let cloneButton = wrapper.find('a[data-test-subj="clone-role-action-test-role-1"]'); expect(cloneButton).toHaveLength(1); expect(cloneButton.prop('href')).toBe('/clone/test-role-1'); - cloneButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="clone-role-action-special%chars%role"]' - ); + cloneButton = wrapper.find('a[data-test-subj="clone-role-action-special%chars%role"]'); expect(cloneButton).toHaveLength(1); expect(cloneButton.prop('href')).toBe('/clone/special%25chars%25role'); - expect( - wrapper.find('EuiButtonEmpty[data-test-subj="edit-role-action-disabled-role"]') - ).toHaveLength(1); - expect( - wrapper.find('EuiButtonEmpty[data-test-subj="clone-role-action-disabled-role"]') - ).toHaveLength(1); + expect(wrapper.find('a[data-test-subj="edit-role-action-disabled-role"]')).toHaveLength(1); + expect(wrapper.find('a[data-test-subj="clone-role-action-disabled-role"]')).toHaveLength(1); }); it('hides reserved roles when instructed to', async () => { diff --git a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx index 3d7cb8d6478625..ca74e3776fe7dc 100644 --- a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx +++ b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx @@ -8,7 +8,6 @@ import type { EuiBasicTableColumn, EuiSwitchEvent } from '@elastic/eui'; import { EuiButton, - EuiButtonEmpty, EuiFlexGroup, EuiFlexItem, EuiInMemoryTable, @@ -17,7 +16,6 @@ import { EuiSpacer, EuiSwitch, EuiText, - EuiToolTip, } from '@elastic/eui'; import _ from 'lodash'; import React, { Component } from 'react'; @@ -39,7 +37,6 @@ import { isRoleReserved, } from '../../../../common/model'; import { DeprecatedBadge, DisabledBadge, ReservedBadge } from '../../badges'; -import { ActionsEuiTableFormatting } from '../../table_utils'; import type { RolesAPIClient } from '../roles_api_client'; interface Props { @@ -140,59 +137,57 @@ export class RolesGridPage extends Component { /> ) : null} - - !role.metadata || !role.metadata._reserved, - selectableMessage: (selectable: boolean) => - !selectable ? 'Role is reserved' : '', - onSelectionChange: (selection: Role[]) => this.setState({ selection }), - selected: this.state.selection, - } - } - pagination={{ - initialPageSize: 20, - pageSizeOptions: [10, 20, 30, 50, 100], - }} - items={this.state.visibleRoles} - loading={roles.length === 0} - search={{ - toolsLeft: this.renderToolsLeft(), - toolsRight: this.renderToolsRight(), - box: { - incremental: true, - 'data-test-subj': 'searchRoles', - }, - onChange: (query: Record) => { - this.setState({ - filter: query.queryText, - visibleRoles: this.getVisibleRoles( - this.state.roles, - query.queryText, - this.state.includeReservedRoles - ), - }); - }, - }} - sorting={{ - sort: { - field: 'name', - direction: 'asc', - }, - }} - rowProps={(role: Role) => { - return { - 'data-test-subj': `roleRow`, - }; - }} - /> - + !role.metadata || !role.metadata._reserved, + selectableMessage: (selectable: boolean) => + !selectable ? 'Role is reserved' : '', + onSelectionChange: (selection: Role[]) => this.setState({ selection }), + selected: this.state.selection, + } + } + pagination={{ + initialPageSize: 20, + pageSizeOptions: [10, 20, 30, 50, 100], + }} + items={this.state.visibleRoles} + loading={roles.length === 0} + search={{ + toolsLeft: this.renderToolsLeft(), + toolsRight: this.renderToolsRight(), + box: { + incremental: true, + 'data-test-subj': 'searchRoles', + }, + onChange: (query: Record) => { + this.setState({ + filter: query.queryText, + visibleRoles: this.getVisibleRoles( + this.state.roles, + query.queryText, + this.state.includeReservedRoles + ), + }); + }, + }} + sorting={{ + sort: { + field: 'name', + direction: 'asc', + }, + }} + rowProps={(role: Role) => { + return { + 'data-test-subj': `roleRow`, + }; + }} + /> ); }; @@ -238,100 +233,67 @@ export class RolesGridPage extends Component { width: '150px', actions: [ { - available: (role: Role) => !isRoleReserved(role), + type: 'icon', + icon: 'copy', isPrimary: true, - render: (role: Role) => { - const title = i18n.translate('xpack.security.management.roles.cloneRoleActionName', { - defaultMessage: `Clone`, - }); - - const label = i18n.translate('xpack.security.management.roles.cloneRoleActionLabel', { - defaultMessage: `Clone {roleName}`, + available: (role: Role) => !isRoleReserved(role), + name: i18n.translate('xpack.security.management.roles.cloneRoleActionName', { + defaultMessage: 'Clone', + }), + description: (role: Role) => + i18n.translate('xpack.security.management.roles.cloneRoleActionLabel', { + defaultMessage: 'Clone {roleName}', values: { roleName: role.name }, - }); - - return ( - - = 1} - iconType={'copy'} - {...reactRouterNavigate( - this.props.history, - getRoleManagementHref('clone', role.name) - )} - > - {title} - - - ); - }, + }), + href: (role: Role) => + reactRouterNavigate(this.props.history, getRoleManagementHref('clone', role.name)) + .href, + onClick: (role: Role, event: React.MouseEvent) => + reactRouterNavigate( + this.props.history, + getRoleManagementHref('clone', role.name) + ).onClick(event), + 'data-test-subj': (role: Role) => `clone-role-action-${role.name}`, }, { + type: 'icon', + icon: 'trash', + color: 'danger', + name: i18n.translate('xpack.security.management.roles.deleteRoleActionName', { + defaultMessage: 'Delete', + }), + description: (role: Role) => + i18n.translate('xpack.security.management.roles.deleteRoleActionLabel', { + defaultMessage: `Delete {roleName}`, + values: { roleName: role.name }, + }), + 'data-test-subj': (role: Role) => `delete-role-action-${role.name}`, + onClick: (role: Role) => this.deleteOneRole(role), available: (role: Role) => !role.metadata || !role.metadata._reserved, - render: (role: Role) => { - const title = i18n.translate('xpack.security.management.roles.deleteRoleActionName', { - defaultMessage: `Delete`, - }); - - const label = i18n.translate( - 'xpack.security.management.roles.deleteRoleActionLabel', - { - defaultMessage: `Delete {roleName}`, - values: { roleName: role.name }, - } - ); - - return ( - - = 1} - iconType={'trash'} - onClick={() => this.deleteOneRole(role)} - > - {title} - - - ); - }, }, { - available: (role: Role) => !isRoleReadOnly(role), - enabled: () => this.state.selection.length === 0, isPrimary: true, - render: (role: Role) => { - const title = i18n.translate('xpack.security.management.roles.editRoleActionName', { - defaultMessage: `Edit`, - }); - - const label = i18n.translate('xpack.security.management.roles.editRoleActionLabel', { + type: 'icon', + icon: 'pencil', + name: i18n.translate('xpack.security.management.roles.editRoleActionName', { + defaultMessage: 'Edit', + }), + description: (role: Role) => + i18n.translate('xpack.security.management.roles.editRoleActionLabel', { defaultMessage: `Edit {roleName}`, values: { roleName: role.name }, - }); - - return ( - - = 1} - iconType={'pencil'} - {...reactRouterNavigate( - this.props.history, - getRoleManagementHref('edit', role.name) - )} - > - {title} - - - ); - }, + }), + 'data-test-subj': (role: Role) => `edit-role-action-${role.name}`, + href: (role: Role) => + reactRouterNavigate(this.props.history, getRoleManagementHref('edit', role.name)) + .href, + onClick: (role: Role, event: React.MouseEvent) => + reactRouterNavigate( + this.props.history, + getRoleManagementHref('edit', role.name) + ).onClick(event), + available: (role: Role) => !isRoleReadOnly(role), + enabled: () => this.state.selection.length === 0, }, ], }); diff --git a/x-pack/plugins/security/public/management/table_utils.tsx b/x-pack/plugins/security/public/management/table_utils.tsx deleted file mode 100644 index 74dd51f1cad85d..00000000000000 --- a/x-pack/plugins/security/public/management/table_utils.tsx +++ /dev/null @@ -1,37 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the Elastic License - * 2.0; you may not use this file except in compliance with the Elastic License - * 2.0. - */ -import { css } from '@emotion/react'; -import type { ReactNode } from 'react'; -import React from 'react'; - -interface ActionsEuiTableFormattingProps { - children: ReactNode; -} - -/* - * Notes to future engineer: - * We created this component because as this time EUI actions table where not allowing to pass - * props href on an action. In our case, we want our actions to work with href - * and onClick. Then the problem is that the design did not match with EUI example, therefore - * we are doing some css magic to only have icon showing up when user is hovering a row - */ -export const ActionsEuiTableFormatting = React.memo( - ({ children }) => ( -
- {children} -
- ) -); From c109b205520ec7d425b42b899bea4fbad40daaef Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 10 Apr 2024 11:13:38 -0700 Subject: [PATCH 15/33] Update DOM snapshots of tables --- .../__snapshots__/data_view.test.tsx.snap | 314 +++++++---------- .../url/__snapshots__/url.test.tsx.snap | 256 ++++++-------- .../authentications_host_table.test.tsx.snap | 316 +++++++++--------- .../authentications_user_table.test.tsx.snap | 316 +++++++++--------- 4 files changed, 515 insertions(+), 687 deletions(-) diff --git a/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap b/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap index eb243025df2f73..77df622eaddbb4 100644 --- a/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap +++ b/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap @@ -200,123 +200,79 @@ Array [ class="euiBasicTable insDataTableFormat__table eui-xScroll css-1f59z3t" data-test-subj="inspectorTable" > -
-
-
-
-
+
+ + + +
- - - {children} - - -
-
- - {children} - -
-
+
-
- -
-
- - - - - - - - - - + + + + + + + - - - - -
-
- -
- column1 -
-
+ 123 +
+
- 123 -
-
-
-
+ class="euiFlexGroup emotion-euiFlexGroup-none-flexStart-center-row" + />
-
- + + +
-
-
-
-
-
+ + + + -
- -
-
-
-
-
- - - - - - - + + + + + + + - - - - -
-
- -
- column1 -
-
+ 123 +
+
- 123 -
-
-
-
+ class="euiFlexGroup emotion-euiFlexGroup-none-flexStart-center-row" + />
-
-
+
+ + + +
-
-
-
-
-
-
-
- - - - + + - + - - - + + + + + - - - + - - + + + + - + - - + + + + - + - - -
-
+
+
+
- - Input - + Input -
+ +
- - Output - + Output -
-
- Input -
-
- john -
- 		+ +
-
- Output -
-
-
- converted url for john -
+
+ converted url for john
-
- -
- Input -
-
- /some/pathname/asset.png -
- 		+ +
-
- Output -
-
-
- converted url for /some/pathname/asset.png -
+
+ converted url for /some/pathname/asset.png
-
- -
- Input -
-
- 1234 -
- 		+ +
-
- Output +
+ converted url for 1234
-
-
- converted url for 1234 -
-
-
-
+
+ + + +
diff --git a/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_host_table.test.tsx.snap b/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_host_table.test.tsx.snap index bf74c41fa303fa..22a13d29278da2 100644 --- a/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_host_table.test.tsx.snap +++ b/x-pack/plugins/security_solution/public/explore/components/authentication/__snapshots__/authentications_host_table.test.tsx.snap @@ -160,212 +160,196 @@ exports[`Authentication Host Table Component rendering it renders the host authe class="euiBasicTable c3" data-test-subj="paginated-basic-table" > -
-
-
-
-
-
-
- - - - + + - + - + - + - + - + - + - + - + - - - + + + + + - - - - -
-
+
+
+
- - User - + User -
+ +
- - Successes - + Successes -
+ +
- - Failures - + Failures -
+ +
- - Last success - + Last success -
+ +
- - Last successful source - + Last successful source -
+ +
- - Last successful destination - + Last successful destination -
+ +
- - Last failure - + Last failure -
+ +
- - Last failed source - + Last failed source -
+ +
- - Last failed destination - + Last failed destination -
-
- - No items found - -
-
-
+ No items found + +
+ + + +
-
-
-
-
-
-
-
- - - - + + - + - + - + - + - + - + - + - + - - - + + + + + - - - - -
-
+
+
+
- - User - + User -
+ +
- - Successes - + Successes -
+ +
- - Failures - + Failures -
+ +
- - Last success - + Last success -
+ +
- - Last successful source - + Last successful source -
+ +
- - Last successful destination - + Last successful destination -
+ +
- - Last failure - + Last failure -
+ +
- - Last failed source - + Last failed source -
+ +
- - Last failed destination - + Last failed destination -
-
- - No items found - -
-
-
+ No items found + +
+ + + +
Date: Wed, 10 Apr 2024 14:44:23 -0700 Subject: [PATCH 16/33] Update Enzyme snapshots --- .../__snapshots__/status_table.test.tsx.snap | 2 -- .../__snapshots__/documents_panel.test.tsx.snap | 1 - .../__snapshots__/events_panel.test.tsx.snap | 2 -- .../__snapshots__/pipeline_panel.test.tsx.snap | 1 - .../__snapshots__/indices_list.test.tsx.snap | 12 ++++++------ .../editors/color/__snapshots__/color.test.tsx.snap | 3 --- .../__snapshots__/static_lookup.test.tsx.snap | 2 -- .../samples/__snapshots__/samples.test.tsx.snap | 1 - .../table/__snapshots__/table.test.tsx.snap | 2 -- .../table/__snapshots__/table.test.tsx.snap | 1 - .../table/__snapshots__/table.test.tsx.snap | 1 - .../__snapshots__/delete_modal_msg.test.tsx.snap | 4 ---- .../components/__snapshots__/flyout.test.tsx.snap | 1 - .../__snapshots__/relationships.test.tsx.snap | 6 ------ .../components/__snapshots__/table.test.tsx.snap | 2 -- .../__snapshots__/pipelines_table.test.js.snap | 2 -- .../__snapshots__/events_table.test.js.snap | 2 -- .../list/table/__snapshots__/table.test.js.snap | 2 -- .../list/__snapshots__/table.test.js.snap | 4 ---- .../__snapshots__/latest_active.test.js.snap | 1 - .../overview/__snapshots__/latest_types.test.js.snap | 1 - .../__snapshots__/latest_versions.test.js.snap | 1 - .../elasticsearch/ccr/__snapshots__/ccr.test.js.snap | 1 - .../components/logs/__snapshots__/logs.test.js.snap | 1 - .../__snapshots__/index.test.tsx.snap | 3 --- 25 files changed, 6 insertions(+), 53 deletions(-) diff --git a/packages/core/apps/core-apps-browser-internal/src/status/components/__snapshots__/status_table.test.tsx.snap b/packages/core/apps/core-apps-browser-internal/src/status/components/__snapshots__/status_table.test.tsx.snap index cb10255eb99986..934027aa35ea7c 100644 --- a/packages/core/apps/core-apps-browser-internal/src/status/components/__snapshots__/status_table.test.tsx.snap +++ b/packages/core/apps/core-apps-browser-internal/src/status/components/__snapshots__/status_table.test.tsx.snap @@ -38,7 +38,6 @@ exports[`StatusTable renders when statuses is provided 1`] = ` ] } data-test-subj="statusBreakdown" - isExpandable={true} itemId={[Function]} itemIdToExpandedRowMap={Object {}} items={ @@ -58,7 +57,6 @@ exports[`StatusTable renders when statuses is provided 1`] = ` }, ] } - responsive={true} rowProps={[Function]} searchFormat="eql" sorting={ diff --git a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/documents_panel.test.tsx.snap b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/documents_panel.test.tsx.snap index e29361b08a9c12..171463d436503d 100644 --- a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/documents_panel.test.tsx.snap +++ b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/documents_panel.test.tsx.snap @@ -38,7 +38,6 @@ exports[`DocumentsPanel renders 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> diff --git a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/events_panel.test.tsx.snap b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/events_panel.test.tsx.snap index d4bdda45ccc3b0..8320547cb21079 100644 --- a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/events_panel.test.tsx.snap +++ b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/events_panel.test.tsx.snap @@ -54,7 +54,6 @@ exports[`EventsPanel renders 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> @@ -110,7 +109,6 @@ exports[`EventsPanel renders with some values missing 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> diff --git a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/pipeline_panel.test.tsx.snap b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/pipeline_panel.test.tsx.snap index cddd85fc851b90..66d241be8d92c5 100644 --- a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/pipeline_panel.test.tsx.snap +++ b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/pipeline_panel.test.tsx.snap @@ -43,7 +43,6 @@ exports[`PipelinePanel renders 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> diff --git a/src/plugins/data_view_editor/public/components/preview_panel/indices_list/__snapshots__/indices_list.test.tsx.snap b/src/plugins/data_view_editor/public/components/preview_panel/indices_list/__snapshots__/indices_list.test.tsx.snap index 992880eb75c72b..0c2cce62b52004 100644 --- a/src/plugins/data_view_editor/public/components/preview_panel/indices_list/__snapshots__/indices_list.test.tsx.snap +++ b/src/plugins/data_view_editor/public/components/preview_panel/indices_list/__snapshots__/indices_list.test.tsx.snap @@ -3,7 +3,7 @@ exports[`IndicesList should change pages 1`] = `
@@ -104,7 +104,7 @@ exports[`IndicesList should change pages 1`] = ` exports[`IndicesList should change per page 1`] = `
@@ -206,7 +206,7 @@ exports[`IndicesList should change per page 1`] = ` exports[`IndicesList should highlight fully when an exact match 1`] = `
@@ -314,7 +314,7 @@ exports[`IndicesList should highlight fully when an exact match 1`] = ` exports[`IndicesList should highlight the query in the matches 1`] = `
@@ -422,7 +422,7 @@ exports[`IndicesList should highlight the query in the matches 1`] = ` exports[`IndicesList should render normally 1`] = `
@@ -523,7 +523,7 @@ exports[`IndicesList should render normally 1`] = ` exports[`IndicesList updating props should render all new indices 1`] = `
diff --git a/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/color/__snapshots__/color.test.tsx.snap b/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/color/__snapshots__/color.test.tsx.snap index 1cff82729e6f99..3fb1b65c2d4afe 100644 --- a/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/color/__snapshots__/color.test.tsx.snap +++ b/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/color/__snapshots__/color.test.tsx.snap @@ -82,7 +82,6 @@ exports[`ColorFormatEditor should render multiple colors 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> } - responsive={true} tableLayout="fixed" /> } - responsive={true} tableLayout="fixed" /> } - responsive={true} style={ Object { "maxWidth": "400px", @@ -169,7 +168,6 @@ exports[`StaticLookupFormatEditor should render normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} style={ Object { "maxWidth": "400px", diff --git a/src/plugins/data_view_field_editor/public/components/field_format_editor/samples/__snapshots__/samples.test.tsx.snap b/src/plugins/data_view_field_editor/public/components/field_format_editor/samples/__snapshots__/samples.test.tsx.snap index eecd78db02ef18..c1f59038e4756a 100644 --- a/src/plugins/data_view_field_editor/public/components/field_format_editor/samples/__snapshots__/samples.test.tsx.snap +++ b/src/plugins/data_view_field_editor/public/components/field_format_editor/samples/__snapshots__/samples.test.tsx.snap @@ -57,7 +57,6 @@ exports[`FormatEditorSamples should render normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap index aeb4417ccbd59b..53cb9a9db33b75 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap @@ -57,7 +57,6 @@ exports[`Table render conflict summary modal 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} rowHeader="firstName" tableCaption="Demo of EuiBasicTable" tableLayout="auto" @@ -304,7 +303,6 @@ exports[`Table should render normally 1`] = ` ], } } - responsive={true} searchFormat="eql" sorting={ Object { diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap index 7ce374b2ad3b43..5f8e34d0776eca 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap @@ -86,7 +86,6 @@ exports[`Table should render normally 1`] = ` ], } } - responsive={true} searchFormat="eql" sorting={true} tableLayout="fixed" diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap index e6f71b425ce8e9..66b7b6f106285f 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap @@ -91,7 +91,6 @@ exports[`Table should render normally 1`] = ` ], } } - responsive={true} searchFormat="eql" sorting={true} tableLayout="fixed" diff --git a/src/plugins/data_view_management/public/components/index_pattern_table/__snapshots__/delete_modal_msg.test.tsx.snap b/src/plugins/data_view_management/public/components/index_pattern_table/__snapshots__/delete_modal_msg.test.tsx.snap index ac12af2228758c..90e0d28996d669 100644 --- a/src/plugins/data_view_management/public/components/index_pattern_table/__snapshots__/delete_modal_msg.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/index_pattern_table/__snapshots__/delete_modal_msg.test.tsx.snap @@ -64,7 +64,6 @@ exports[`delete modal content render 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableCaption="Data views selected for deletion" tableLayout="fixed" /> @@ -127,7 +126,6 @@ exports[`delete modal content render 2`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableCaption="Data views selected for deletion" tableLayout="fixed" /> @@ -196,7 +194,6 @@ exports[`delete modal content render 3`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableCaption="Data views selected for deletion" tableLayout="fixed" /> @@ -276,7 +273,6 @@ exports[`delete modal content render 4`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableCaption="Data views selected for deletion" tableLayout="fixed" /> diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap index 03ba5cf5d9ead2..e6b32851f76820 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap @@ -114,7 +114,6 @@ exports[`Flyout conflicts should allow conflict resolution 1`] = ` ], } } - responsive={true} searchFormat="eql" tableLayout="fixed" /> diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/relationships.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/relationships.test.tsx.snap index 4e5b62f8126339..d942d13b0f0224 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/relationships.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/relationships.test.tsx.snap @@ -111,7 +111,6 @@ exports[`Relationships should render dashboards normally 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -313,7 +312,6 @@ exports[`Relationships should render index patterns normally 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -447,7 +445,6 @@ exports[`Relationships should render invalid relations 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} searchFormat="eql" tableLayout="fixed" @@ -506,7 +503,6 @@ exports[`Relationships should render invalid relations 1`] = ` } items={Array []} pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -658,7 +654,6 @@ exports[`Relationships should render searches normally 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -820,7 +815,6 @@ exports[`Relationships should render visualizations normally 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap index 159ef79066a899..f03a255106acc3 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap @@ -227,7 +227,6 @@ exports[`Table prevents hidden saved objects from being deleted 1`] = ` "totalItemCount": 3, } } - responsive={true} rowProps={[Function]} selection={ Object { @@ -467,7 +466,6 @@ exports[`Table should render normally 1`] = ` "totalItemCount": 3, } } - responsive={true} rowProps={[Function]} selection={ Object { diff --git a/x-pack/plugins/logstash/public/application/components/pipeline_list/__snapshots__/pipelines_table.test.js.snap b/x-pack/plugins/logstash/public/application/components/pipeline_list/__snapshots__/pipelines_table.test.js.snap index c552aebbd01648..2de5ed1f88cdfc 100644 --- a/x-pack/plugins/logstash/public/application/components/pipeline_list/__snapshots__/pipelines_table.test.js.snap +++ b/x-pack/plugins/logstash/public/application/components/pipeline_list/__snapshots__/pipelines_table.test.js.snap @@ -39,7 +39,6 @@ exports[`PipelinesTable component renders component as expected 1`] = ` ] } data-test-subj="pipelineTable" - isSelectable={true} itemId="id" items={ Array [ @@ -62,7 +61,6 @@ exports[`PipelinesTable component renders component as expected 1`] = ` "totalItemCount": 1, } } - responsive={true} rowProps={ Object { "data-test-subj": "row", diff --git a/x-pack/plugins/ml/public/application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap b/x-pack/plugins/ml/public/application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap index ba65f329cf7351..2266fab97c4395 100644 --- a/x-pack/plugins/ml/public/application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap +++ b/x-pack/plugins/ml/public/application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap @@ -56,7 +56,6 @@ exports[`EventsTable Renders events table with no search bar 1`] = ` ], } } - responsive={true} rowProps={[Function]} searchFormat="eql" sorting={ @@ -128,7 +127,6 @@ exports[`EventsTable Renders events table with search bar 1`] = ` ], } } - responsive={true} rowProps={[Function]} search={ Object { diff --git a/x-pack/plugins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap b/x-pack/plugins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap index d7da276215d103..6611dd20fc6993 100644 --- a/x-pack/plugins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap +++ b/x-pack/plugins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap @@ -34,7 +34,6 @@ exports[`CalendarsListTable renders the table with all calendars 1`] = ` ] } data-test-subj="mlCalendarTable loaded" - isSelectable={true} itemId="calendar_id" items={ Array [ @@ -66,7 +65,6 @@ exports[`CalendarsListTable renders the table with all calendars 1`] = ` ], } } - responsive={true} rowProps={[Function]} search={ Object { diff --git a/x-pack/plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap b/x-pack/plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap index b5f0f5614145b7..9ac0bcd5ce5bd5 100644 --- a/x-pack/plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap +++ b/x-pack/plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap @@ -39,7 +39,6 @@ exports[`Filter Lists Table renders with filter lists and selection supplied 1`] ] } data-test-subj="mlFilterListsTable" - isSelectable={true} itemId="filter_id" items={ Array [ @@ -64,7 +63,6 @@ exports[`Filter Lists Table renders with filter lists and selection supplied 1`] ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -158,7 +156,6 @@ exports[`Filter Lists Table renders with filter lists supplied 1`] = ` ] } data-test-subj="mlFilterListsTable" - isSelectable={true} itemId="filter_id" items={ Array [ @@ -183,7 +180,6 @@ exports[`Filter Lists Table renders with filter lists supplied 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { diff --git a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_active.test.js.snap b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_active.test.js.snap index c4ce91823ce03a..fd33ec5254d2fc 100644 --- a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_active.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_active.test.js.snap @@ -45,7 +45,6 @@ exports[`Latest Active that latest active component renders normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> `; diff --git a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_types.test.js.snap b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_types.test.js.snap index 4b4f5ca6549715..1a12f37e028b72 100644 --- a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_types.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_types.test.js.snap @@ -37,7 +37,6 @@ exports[`Latest Types that latest active component renders normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> `; diff --git a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_versions.test.js.snap b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_versions.test.js.snap index 88e673eb8dcea6..8318c6301a3f35 100644 --- a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_versions.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_versions.test.js.snap @@ -33,7 +33,6 @@ exports[`Latest Versions that latest active component renders normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> `; diff --git a/x-pack/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap b/x-pack/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap index 70d8be491f5713..2cb56a0c9b4242 100644 --- a/x-pack/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap @@ -127,7 +127,6 @@ exports[`Ccr that it renders normally 1`] = ` ] } pagination={false} - responsive={true} searchFormat="eql" sorting={ Object { diff --git a/x-pack/plugins/monitoring/public/components/logs/__snapshots__/logs.test.js.snap b/x-pack/plugins/monitoring/public/components/logs/__snapshots__/logs.test.js.snap index e85ba5522bdf18..c558d98ea792b9 100644 --- a/x-pack/plugins/monitoring/public/components/logs/__snapshots__/logs.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/logs/__snapshots__/logs.test.js.snap @@ -274,7 +274,6 @@ exports[`Logs should render normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> } - responsive={true} tableLayout="fixed" /> @@ -135,7 +134,6 @@ exports[`conditions_table ConditionsTable should render multi item table with or token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> @@ -181,7 +179,6 @@ exports[`conditions_table ConditionsTable should render single item table correc token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> From e2e5cadd5af1fdee9eb9acf67b3320a58fb2d67b Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 10 Apr 2024 14:44:52 -0700 Subject: [PATCH 17/33] Fix Enzyme selectors - Emotion adds a wrapper with the same props, so we need to specify the actual DOM node --- .../src/testbed/testbed.ts | 4 ++-- .../components/table/table.test.tsx | 3 +-- .../components/delete_confirm_modal.test.tsx | 4 ++-- .../non_text_fields_body.test.tsx | 18 +++++++++--------- .../text_fields_body.test.tsx | 18 +++++++++--------- .../__jest__/components/index_table.test.js | 2 +- .../event_fields_browser.test.tsx | 8 ++++---- .../alerts_count_panel/alerts_count.test.tsx | 10 +++++----- .../uncommon_process_table/index.test.tsx | 16 ++++++++-------- .../components/rule_error_log.test.tsx | 2 +- 10 files changed, 42 insertions(+), 43 deletions(-) diff --git a/packages/kbn-test-jest-helpers/src/testbed/testbed.ts b/packages/kbn-test-jest-helpers/src/testbed/testbed.ts index 284e8d557de6f8..4559924c28aff1 100644 --- a/packages/kbn-test-jest-helpers/src/testbed/testbed.ts +++ b/packages/kbn-test-jest-helpers/src/testbed/testbed.ts @@ -263,11 +263,11 @@ export function registerTestBed ({ reactWrapper: row, - columns: row.find('.euiTableCellContent').map((col) => ({ + columns: row.find('div.euiTableCellContent').map((col) => ({ reactWrapper: col, // We can't access the td value with col.text() because // eui adds an extra div in td on mobile => (.euiTableRowCell__mobileHeader) - value: col.find('.euiTableCellContent').text(), + value: col.find('div.euiTableCellContent').text(), })), })); diff --git a/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx b/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx index de96c865b90e09..26f10f7b8ee8b0 100644 --- a/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx +++ b/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx @@ -100,8 +100,7 @@ describe('Background Search Session Management Table', () => { ); }); - expect(table.find('thead th .euiTableCellContent__text').map((node) => node.text())) - .toMatchInlineSnapshot(` + expect(table.find('thead th').map((node) => node.text())).toMatchInlineSnapshot(` Array [ "App", "Name", diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/delete_confirm_modal.test.tsx b/src/plugins/saved_objects_management/public/management_section/objects_table/components/delete_confirm_modal.test.tsx index 8dffee1b91b643..edfe0b1d00edf5 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/delete_confirm_modal.test.tsx +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/delete_confirm_modal.test.tsx @@ -84,7 +84,7 @@ describe('DeleteConfirmModal', () => { allowedTypes={allowedTypes} /> ); - expect(wrapper.find('.euiTableRow')).toHaveLength(3); + expect(wrapper.find('tr.euiTableRow')).toHaveLength(3); }); it('calls `onCancel` when clicking on the cancel button', () => { @@ -135,7 +135,7 @@ describe('DeleteConfirmModal', () => { allowedTypes={allowedTypes} /> ); - expect(wrapper.find('.euiTableRow')).toHaveLength(1); + expect(wrapper.find('tr.euiTableRow')).toHaveLength(1); }); it('displays a callout when at least one object cannot be deleted', () => { diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/non_text_fields_body.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/non_text_fields_body.test.tsx index 8abb716183a9f0..8b481d38d23bb7 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/non_text_fields_body.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/non_text_fields_body.test.tsx @@ -50,15 +50,15 @@ describe('NonTextFieldsBody', () => { const tableRows = getTableRows(wrapper); expect(tableRows.length).toBe(3); - expect(tableRows.at(0).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'bar' - ); - expect(tableRows.at(1).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'foo' - ); - expect(tableRows.at(2).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'zoo' - ); + expect( + tableRows.at(0).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('bar'); + expect( + tableRows.at(1).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('foo'); + expect( + tableRows.at(2).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('zoo'); }); describe('the "raw" checkbox within each table row', () => { diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/text_fields_body.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/text_fields_body.test.tsx index 3081ccc4456551..3986809c549aa9 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/text_fields_body.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/text_fields_body.test.tsx @@ -65,15 +65,15 @@ describe('TextFieldsBody', () => { const tableRows = getTableRows(wrapper); expect(tableRows.length).toBe(3); - expect(tableRows.at(0).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'bar' - ); - expect(tableRows.at(1).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'foo' - ); - expect(tableRows.at(2).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'zoo' - ); + expect( + tableRows.at(0).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('bar'); + expect( + tableRows.at(1).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('foo'); + expect( + tableRows.at(2).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('zoo'); }); describe('the "raw" checkbox within each table row', () => { diff --git a/x-pack/plugins/index_management/__jest__/components/index_table.test.js b/x-pack/plugins/index_management/__jest__/components/index_table.test.js index af3333d3201ef0..721d6a65d92cfe 100644 --- a/x-pack/plugins/index_management/__jest__/components/index_table.test.js +++ b/x-pack/plugins/index_management/__jest__/components/index_table.test.js @@ -75,7 +75,7 @@ const status = (rendered, row = 0) => { rendered.update(); return findTestSubject(rendered, 'indexTableCell-status') .at(row) - .find('.euiTableCellContent') + .find('div.euiTableCellContent') .text(); }; diff --git a/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx b/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx index 07569928785180..cfe1def2b9da2e 100644 --- a/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx +++ b/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx @@ -129,8 +129,8 @@ describe('EventFieldsBrowser', () => { expect( wrapper - .find('.euiTableRow') - .find('.euiTableRowCell') + .find('tr.euiTableRow') + .find('td.euiTableRowCell') .at(1) .find('[data-euiicon-type]') .exists() @@ -168,8 +168,8 @@ describe('EventFieldsBrowser', () => { ); expect( wrapper - .find('.euiTableRow') - .find('.euiTableRowCell') + .find('tr.euiTableRow') + .find('td.euiTableRowCell') .at(1) .find('[data-euiicon-type]') .last() diff --git a/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.test.tsx b/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.test.tsx index 56aad747a856d7..3740c7b2ef7dff 100644 --- a/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.test.tsx +++ b/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.test.tsx @@ -89,7 +89,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="stackByField0Key"] > div.euiTableCellContent`) + .find(`[data-test-subj="stackByField0Key"] div.euiTableCellContent`) .hostNodes() .at(i) .text() @@ -114,7 +114,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="doc_count"] > div.euiTableCellContent`) + .find(`[data-test-subj="doc_count"] div.euiTableCellContent`) .hostNodes() .at(i) .text() @@ -144,7 +144,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="stackByField0Key"] > div.euiTableCellContent`) + .find(`[data-test-subj="stackByField0Key"] div.euiTableCellContent`) .hostNodes() .at(resultRow++) .text() @@ -175,7 +175,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="stackByField1Key"] > div.euiTableCellContent`) + .find(`[data-test-subj="stackByField1Key"] div.euiTableCellContent`) .hostNodes() .at(resultRow++) .text() @@ -206,7 +206,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="stackByField1DocCount"] > div.euiTableCellContent`) + .find(`[data-test-subj="stackByField1DocCount"] div.euiTableCellContent`) .hostNodes() .at(resultRow++) .text() diff --git a/x-pack/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/index.test.tsx b/x-pack/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/index.test.tsx index 1c8c7997f41ada..64f9bc30d85ef6 100644 --- a/x-pack/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/index.test.tsx +++ b/x-pack/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/index.test.tsx @@ -66,7 +66,7 @@ describe('Uncommon Process Table Component', () => { ); - expect(wrapper.find('.euiTableRow').at(0).find('.euiTableRowCell').at(3).text()).toBe( + expect(wrapper.find('tr.euiTableRow').at(0).find('td.euiTableRowCell').at(3).text()).toBe( `Host names${getEmptyValue()}` ); }); @@ -78,7 +78,7 @@ describe('Uncommon Process Table Component', () => { ); - expect(wrapper.find('.euiTableRow').at(1).find('.euiTableRowCell').at(3).text()).toBe( + expect(wrapper.find('tr.euiTableRow').at(1).find('td.euiTableRowCell').at(3).text()).toBe( 'Host nameshello-world ' ); }); @@ -91,7 +91,7 @@ describe('Uncommon Process Table Component', () => { ); expect( - wrapper.find('.euiTableRow').at(1).find('.euiTableRowCell').at(3).find('a').length + wrapper.find('tr.euiTableRow').at(1).find('td.euiTableRowCell').at(3).find('a').length ).toBe(1); }); @@ -102,7 +102,7 @@ describe('Uncommon Process Table Component', () => { ); - expect(wrapper.find('.euiTableRow').at(2).find('.euiTableRowCell').at(3).text()).toBe( + expect(wrapper.find('tr.euiTableRow').at(2).find('td.euiTableRowCell').at(3).text()).toBe( 'Host nameshello-worldhello-world-2 ' ); }); @@ -115,7 +115,7 @@ describe('Uncommon Process Table Component', () => { ); expect( - wrapper.find('.euiTableRow').at(2).find('.euiTableRowCell').at(3).find('a').length + wrapper.find('tr.euiTableRow').at(2).find('td.euiTableRowCell').at(3).find('a').length ).toBe(2); }); @@ -125,7 +125,7 @@ describe('Uncommon Process Table Component', () => { ); - expect(wrapper.find('.euiTableRow').at(3).find('.euiTableRowCell').at(3).text()).toBe( + expect(wrapper.find('tr.euiTableRow').at(3).find('td.euiTableRowCell').at(3).text()).toBe( `Host names${getEmptyValue()}` ); }); @@ -137,7 +137,7 @@ describe('Uncommon Process Table Component', () => { ); expect( - wrapper.find('.euiTableRow').at(3).find('.euiTableRowCell').at(3).find('a').length + wrapper.find('tr.euiTableRow').at(3).find('td.euiTableRowCell').at(3).find('a').length ).toBe(0); }); @@ -147,7 +147,7 @@ describe('Uncommon Process Table Component', () => { ); - expect(wrapper.find('.euiTableRow').at(4).find('.euiTableRowCell').at(3).text()).toBe( + expect(wrapper.find('tr.euiTableRow').at(4).find('td.euiTableRowCell').at(3).text()).toBe( 'Host nameshello-worldhello-world-2 ' ); }); diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.test.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.test.tsx index c586aba931682d..4066f088ad10e4 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.test.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.test.tsx @@ -176,7 +176,7 @@ describe('rule_error_log', () => { }); expect(wrapper.find(EuiSuperDatePicker).props().isLoading).toBeFalsy(); - expect(wrapper.find('.euiTableRow').length).toEqual(10); + expect(wrapper.find('tr.euiTableRow').length).toEqual(10); nowMock.mockRestore(); }); From 89f107e14dae5b0e701b25504aeb556270a6c183 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 10 Apr 2024 17:46:13 -0700 Subject: [PATCH 18/33] Fix Enzyme simulated events --- .../components/crawler/components/domains_table.test.tsx | 8 +++++--- .../components/tables/test_helpers/shared_columns.tsx | 8 +++++--- .../crawler/domain_management/domains_table.test.tsx | 6 ++++-- 3 files changed, 14 insertions(+), 8 deletions(-) diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx index defa71847a183a..8286bcc263a45a 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx @@ -143,6 +143,8 @@ describe('DomainsTable', () => { }); describe('when the user can manage/delete engines', () => { + const simulatedClickEvent = { persist: () => {} }; // Required for EUI action clicks. Can be removed if switching away from Enzyme to RTL + const getManageAction = () => getActionItems().at(0).dive().find(EuiButtonIcon); const getDeleteAction = () => getActionItems().at(1).dive().find(EuiButtonIcon); @@ -159,7 +161,7 @@ describe('DomainsTable', () => { it('sends the user to the engine overview on click', () => { const { navigateToUrl } = mockKibanaValues; - getManageAction().simulate('click'); + getManageAction().simulate('click', simulatedClickEvent); expect(navigateToUrl).toHaveBeenCalledWith('/engines/some-engine/crawler/domains/1234'); }); @@ -169,7 +171,7 @@ describe('DomainsTable', () => { it('clicking the action and confirming deletes the domain', () => { jest.spyOn(global, 'confirm').mockReturnValueOnce(true); - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(actions.deleteDomain).toHaveBeenCalledWith( expect.objectContaining({ id: '1234' }) @@ -179,7 +181,7 @@ describe('DomainsTable', () => { it('clicking the action and not confirming does not delete the engine', () => { jest.spyOn(global, 'confirm').mockReturnValueOnce(false); - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(actions.deleteDomain).not.toHaveBeenCalled(); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx index e00497a419a3c3..fffd9156555c7d 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx @@ -22,6 +22,8 @@ export const runSharedColumnsTests = ( tableContent: string, values: object = {} ) => { + const simulatedClickEvent = { persist: () => {} }; // Required for EUI action clicks. Can be removed if switching away from Enzyme to RTL + const getTableBody = () => wrapper.find(EuiBasicTable).dive().find('RenderWithEuiTheme').renderProp('children')(); @@ -83,7 +85,7 @@ export const runSharedColumnsTests = ( it('sends the user to the engine overview on click', () => { jest.spyOn(engineLinkHelpers, 'navigateToEngine'); const { navigateToEngine } = engineLinkHelpers; - getManageAction().simulate('click'); + getManageAction().simulate('click', simulatedClickEvent); expect(navigateToEngine).toHaveBeenCalledWith('test-engine'); }); @@ -94,7 +96,7 @@ export const runSharedColumnsTests = ( it('clicking the action and confirming deletes the engine', () => { jest.spyOn(global, 'confirm').mockReturnValueOnce(true); - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(deleteEngine).toHaveBeenCalledWith( expect.objectContaining({ name: 'test-engine' }) @@ -103,7 +105,7 @@ export const runSharedColumnsTests = ( it('clicking the action and not confirming does not delete the engine', () => { jest.spyOn(global, 'confirm').mockReturnValueOnce(false); - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(deleteEngine).not.toHaveBeenCalled(); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_table.test.tsx b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_table.test.tsx index 37250d99e789a4..da652754f704e3 100644 --- a/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_table.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/enterprise_search_content/components/search_index/crawler/domain_management/domains_table.test.tsx @@ -137,6 +137,8 @@ describe('DomainsTable', () => { }); describe('actions column', () => { + const simulatedClickEvent = { persist: () => {} }; // Required for EUI action clicks. Can be removed if switching away from Enzyme to RTL + const getActions = () => getTableBody().find('ExpandedItemActions'); const getActionItems = () => getActions().first().dive().find('DefaultItemAction'); @@ -157,7 +159,7 @@ describe('DomainsTable', () => { it('sends the user to the engine overview on click', () => { const { navigateToUrl } = mockKibanaValues; - getManageAction().simulate('click'); + getManageAction().simulate('click', simulatedClickEvent); expect(navigateToUrl).toHaveBeenCalledWith( '/search_indices/index-name/domain_management/1234' @@ -167,7 +169,7 @@ describe('DomainsTable', () => { describe('delete action', () => { it('clicking the action and confirming deletes the domain', () => { - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(actions.showModal).toHaveBeenCalled(); }); From b6144cac64d47a0b74e3c3a3a80bf9fc371eb1d8 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 10 Apr 2024 14:45:38 -0700 Subject: [PATCH 19/33] Fix test text assertions caused by mobile headers no longer rendering to the DOM on desktop --- .../src/query_history.test.tsx | 2 +- .../components/table/table.test.tsx | 12 ++-- .../clusters_table/clusters_table.test.tsx | 18 ++--- .../__jest__/policy_table.test.tsx | 6 +- .../journeys/private_locations.journey.ts | 4 +- .../cypress/e2e/all/packs_create_edit.cy.ts | 2 +- .../linked_to_rule/index.test.tsx | 2 +- .../entity_analytics_anomalies/index.test.tsx | 2 +- .../tabs/risk_inputs/risk_inputs.test.tsx | 4 +- .../risk_summary_flyout/risk_summary.test.tsx | 17 ++--- .../uncommon_process_table/index.test.tsx | 10 +-- .../public/resolver/view/panel.test.tsx | 71 +++++++++---------- 12 files changed, 69 insertions(+), 81 deletions(-) diff --git a/packages/kbn-text-based-editor/src/query_history.test.tsx b/packages/kbn-text-based-editor/src/query_history.test.tsx index 74cdb096a81f1d..14e7d6e31c08dd 100644 --- a/packages/kbn-text-based-editor/src/query_history.test.tsx +++ b/packages/kbn-text-based-editor/src/query_history.test.tsx @@ -153,7 +153,7 @@ describe('QueryHistory', () => { /> ); expect(screen.getByRole('table')).toHaveTextContent( - 'Time ranRecent queriesLast durationTime ranMar. 25, 24 08:45:27Recent queriesfrom kibana_sample_data_flights | limit 10Last duration2ms' + 'Time ranRecent queriesLast durationMar. 25, 24 08:45:27from kibana_sample_data_flights | limit 102ms' ); }); }); diff --git a/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx b/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx index 26f10f7b8ee8b0..6394deeab843b1 100644 --- a/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx +++ b/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx @@ -135,12 +135,12 @@ describe('Background Search Session Management Table', () => { expect(table.find('tbody td').map((node) => node.text())).toMatchInlineSnapshot(` Array [ - "App", - "Namevery background search Info", - "# Searches0", - "StatusExpired", - "Created2 Dec, 2020, 00:19:32", - "Expiration--", + "", + "very background search Info", + "0", + "Expired", + "2 Dec, 2020, 00:19:32", + "--", "", "", ] diff --git a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.test.tsx b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.test.tsx index 667c8937aa6493..dcaadb58f11554 100644 --- a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.test.tsx +++ b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.test.tsx @@ -32,9 +32,9 @@ describe('ClustersTable', () => { render(); const tableRows = screen.getAllByRole('row'); expect(tableRows.length).toBe(4); // 1 header row, 3 data rows - expect(tableRows[1]).toHaveTextContent('Nameremote1StatussuccessfulResponse time50ms'); - expect(tableRows[2]).toHaveTextContent('Nameremote2StatusskippedResponse time1000ms'); - expect(tableRows[3]).toHaveTextContent('Nameremote3StatusfailedResponse time90ms'); + expect(tableRows[1]).toHaveTextContent('remote1successful50ms'); + expect(tableRows[2]).toHaveTextContent('remote2skipped1000ms'); + expect(tableRows[3]).toHaveTextContent('remote3failed90ms'); }); test('should sort by response time', () => { @@ -45,16 +45,16 @@ describe('ClustersTable', () => { fireEvent.click(button); const tableRowsAsc = screen.getAllByRole('row'); expect(tableRowsAsc.length).toBe(4); // 1 header row, 3 data rows - expect(tableRowsAsc[1]).toHaveTextContent('Nameremote1StatussuccessfulResponse time50ms'); - expect(tableRowsAsc[2]).toHaveTextContent('Nameremote3StatusfailedResponse time90ms'); - expect(tableRowsAsc[3]).toHaveTextContent('Nameremote2StatusskippedResponse time1000ms'); + expect(tableRowsAsc[1]).toHaveTextContent('remote1successful50ms'); + expect(tableRowsAsc[2]).toHaveTextContent('remote3failed90ms'); + expect(tableRowsAsc[3]).toHaveTextContent('remote2skipped1000ms'); fireEvent.click(button); const tableRowsDesc = screen.getAllByRole('row'); expect(tableRowsDesc.length).toBe(4); // 1 header row, 3 data rows - expect(tableRowsDesc[1]).toHaveTextContent('Nameremote2StatusskippedResponse time1000ms'); - expect(tableRowsDesc[2]).toHaveTextContent('Nameremote3StatusfailedResponse time90ms'); - expect(tableRowsDesc[3]).toHaveTextContent('Nameremote1StatussuccessfulResponse time50ms'); + expect(tableRowsDesc[1]).toHaveTextContent('remote2skipped1000ms'); + expect(tableRowsDesc[2]).toHaveTextContent('remote3failed90ms'); + expect(tableRowsDesc[3]).toHaveTextContent('remote1successful50ms'); }); }); }); diff --git a/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx b/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx index b7278f79b0668e..f6a579b58f09bf 100644 --- a/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx +++ b/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx @@ -307,11 +307,11 @@ describe('policy table', () => { const policyName = findTestSubject(firstRow, 'policyTablePolicyNameLink').text(); expect(policyName).toBe(`${testPolicy.name}`); const policyIndexTemplates = findTestSubject(firstRow, 'policy-indexTemplates').text(); - expect(policyIndexTemplates).toBe(`Linked index templates${testPolicy.indexTemplates.length}`); + expect(policyIndexTemplates).toBe(`${testPolicy.indexTemplates.length}`); const policyIndices = findTestSubject(firstRow, 'policy-indices').text(); - expect(policyIndices).toBe(`Linked indices${testPolicy.indices.length}`); + expect(policyIndices).toBe(`${testPolicy.indices.length}`); const policyModifiedDate = findTestSubject(firstRow, 'policy-modifiedDate').text(); - expect(policyModifiedDate).toBe(`Modified date${testDateFormatted}`); + expect(policyModifiedDate).toBe(`${testDateFormatted}`); }); test('opens a flyout with index templates', () => { const rendered = mountWithIntl(component); diff --git a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts index 46d9e00ccb774f..79a24ad342b7ca 100644 --- a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts +++ b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts @@ -118,8 +118,8 @@ journey(`PrivateLocationsSettings`, async ({ page, params }) => { await page.click('[data-test-subj="settings-page-link"]'); await page.click('h1:has-text("Settings")'); await page.click('text=Private Locations'); - await page.waitForSelector('td:has-text("Monitors"):has-text("1")'); - await page.waitForSelector('td:has-text("Location nam"):has-text("Test private")'); + await page.waitForSelector('td:has-text("1")'); + await page.waitForSelector('td:has-text("Test private")'); await page.click('.euiTableCellContent__hoverItem .euiToolTipAnchor'); await page.click('button:has-text("Tags")'); await page.click('[aria-label="Tags"] >> text=Area51'); diff --git a/x-pack/plugins/osquery/cypress/e2e/all/packs_create_edit.cy.ts b/x-pack/plugins/osquery/cypress/e2e/all/packs_create_edit.cy.ts index 05fb987bd0d073..4852db20f0bfd9 100644 --- a/x-pack/plugins/osquery/cypress/e2e/all/packs_create_edit.cy.ts +++ b/x-pack/plugins/osquery/cypress/e2e/all/packs_create_edit.cy.ts @@ -579,7 +579,7 @@ describe('Packs - Create and Edit', { tags: ['@ess', '@serverless'] }, () => { return cy.get('tbody .euiTableRow > td:nth-child(5)').invoke('text'); }, - (response) => response !== 'Docs-', + (response) => response !== '-', { timeout: 300000, post: () => { diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_rule/index.test.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_rule/index.test.tsx index e963c8d7707f91..a007cee4c1963f 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_rule/index.test.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_rule/index.test.tsx @@ -24,7 +24,7 @@ describe('ExceptionsLinkedToRule', () => { /> ); - expect(wrapper.find('[data-test-subj="ruleNameCell"]').at(0).text()).toEqual('NameMy rule'); + expect(wrapper.find('[data-test-subj="ruleNameCell"]').at(0).text()).toEqual('My rule'); expect(wrapper.find('[data-test-subj="linkToRuleSecuritySolutionLink"]').exists()).toBeTruthy(); }); }); diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.test.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.test.tsx index ee3c4cfd022d89..8c511ad19fe173 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.test.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.test.tsx @@ -242,7 +242,7 @@ describe('EntityAnalyticsAnomalies', () => { ); - expect(getByTestId('anomalies-table-column-count').textContent).toEqual('Count'); // 'Count' is always rendered by only displayed on mobile + expect(getByTestId('anomalies-table-column-count')).toHaveTextContent(''); }); it('renders a warning message when jobs are incompatible', () => { diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs.test.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs.test.tsx index 0adf0b0639f6be..d96e843a38a066 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs.test.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs.test.tsx @@ -73,9 +73,7 @@ describe('RiskInputsTab', () => { ); expect(queryByTestId('risk-input-asset-criticality-title')).not.toBeInTheDocument(); - expect(getByTestId('risk-input-table-description-cell')).toHaveTextContent( - 'Rule nameRule Name' - ); + expect(getByTestId('risk-input-table-description-cell')).toHaveTextContent('Rule Name'); }); it('Does not render the context section if enabled but no asset criticality', () => { diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.test.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.test.tsx index 8de14bdbf75214..c7debcdbdc9656 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.test.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.test.tsx @@ -57,18 +57,12 @@ describe('RiskSummary', () => { // Alerts expect(getByTestId('risk-summary-table')).toHaveTextContent( - `Inputs${mockHostRiskScoreState.data?.[0].host.risk.category_1_count ?? 0}` - ); - expect(getByTestId('risk-summary-table')).toHaveTextContent( - `AlertsScore${mockHostRiskScoreState.data?.[0].host.risk.category_1_score ?? 0}` + `${mockHostRiskScoreState.data?.[0].host.risk.category_1_count}` ); // Context expect(getByTestId('risk-summary-table')).not.toHaveTextContent( - `Inputs${mockHostRiskScoreState.data?.[0].host.risk.category_2_count ?? 0}` - ); - expect(getByTestId('risk-summary-table')).not.toHaveTextContent( - `ContextsScore${mockHostRiskScoreState.data?.[0].host.risk.category_2_score ?? 0}` + `${mockHostRiskScoreState.data?.[0].host.risk.category_2_count}` ); // Result row doesn't exist if alerts are the only category @@ -93,15 +87,12 @@ describe('RiskSummary', () => { // Alerts expect(getByTestId('risk-summary-table')).toHaveTextContent( - `Inputs${mockHostRiskScoreState.data?.[0].host.risk.category_1_count ?? 0}` - ); - expect(getByTestId('risk-summary-table')).toHaveTextContent( - `AlertsScore${mockHostRiskScoreState.data?.[0].host.risk.category_1_score ?? 0}` + `${mockHostRiskScoreState.data?.[0].host.risk.category_1_count}` ); // Result expect(getByTestId('risk-summary-result-count')).toHaveTextContent( - `${mockHostRiskScoreState.data?.[0].host.risk.category_1_count ?? 0}` + `${mockHostRiskScoreState.data?.[0].host.risk.category_1_count}` ); expect(getByTestId('risk-summary-result-score')).toHaveTextContent( diff --git a/x-pack/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/index.test.tsx b/x-pack/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/index.test.tsx index 64f9bc30d85ef6..7505780da02745 100644 --- a/x-pack/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/index.test.tsx +++ b/x-pack/plugins/security_solution/public/explore/hosts/components/uncommon_process_table/index.test.tsx @@ -67,7 +67,7 @@ describe('Uncommon Process Table Component', () => { ); expect(wrapper.find('tr.euiTableRow').at(0).find('td.euiTableRowCell').at(3).text()).toBe( - `Host names${getEmptyValue()}` + `${getEmptyValue()}` ); }); @@ -79,7 +79,7 @@ describe('Uncommon Process Table Component', () => { ); expect(wrapper.find('tr.euiTableRow').at(1).find('td.euiTableRowCell').at(3).text()).toBe( - 'Host nameshello-world ' + 'hello-world ' ); }); @@ -103,7 +103,7 @@ describe('Uncommon Process Table Component', () => { ); expect(wrapper.find('tr.euiTableRow').at(2).find('td.euiTableRowCell').at(3).text()).toBe( - 'Host nameshello-worldhello-world-2 ' + 'hello-worldhello-world-2 ' ); }); @@ -126,7 +126,7 @@ describe('Uncommon Process Table Component', () => { ); expect(wrapper.find('tr.euiTableRow').at(3).find('td.euiTableRowCell').at(3).text()).toBe( - `Host names${getEmptyValue()}` + `${getEmptyValue()}` ); }); @@ -148,7 +148,7 @@ describe('Uncommon Process Table Component', () => { ); expect(wrapper.find('tr.euiTableRow').at(4).find('td.euiTableRowCell').at(3).text()).toBe( - 'Host nameshello-worldhello-world-2 ' + 'hello-worldhello-world-2 ' ); }); }); diff --git a/x-pack/plugins/security_solution/public/resolver/view/panel.test.tsx b/x-pack/plugins/security_solution/public/resolver/view/panel.test.tsx index fb875b3ceec3f8..e6091d1f4776ac 100644 --- a/x-pack/plugins/security_solution/public/resolver/view/panel.test.tsx +++ b/x-pack/plugins/security_solution/public/resolver/view/panel.test.tsx @@ -36,17 +36,17 @@ describe(`Resolver: when analyzing a tree with no ancestors and two children and * These are the details we expect to see in the node detail view when the origin is selected. */ const originEventDetailEntries: Array<[string, string]> = [ - ['Field@timestamp', 'ValueSep 23, 2020 @ 08:25:32.316'], - ['Fieldprocess.executable', 'Valueexecutable'], - ['Fieldprocess.pid', 'Value0'], - ['Fieldprocess.entity_id', 'Valueorigin'], - ['Fielduser.name', 'Valueuser.name'], - ['Fielduser.domain', 'Valueuser.domain'], - ['Fieldprocess.parent.pid', 'Value0'], - ['Fieldprocess.hash.md5', 'Valuehash.md5'], - ['Fieldprocess.args', 'Valueargs0'], - ['Fieldprocess.args', 'Valueargs1'], - ['Fieldprocess.args', 'Valueargs2'], + ['@timestamp', 'Sep 23, 2020 @ 08:25:32.316'], + ['process.executable', 'executable'], + ['process.pid', '0'], + ['process.entity_id', 'origin'], + ['user.name', 'user.name'], + ['user.domain', 'user.domain'], + ['process.parent.pid', '0'], + ['process.hash.md5', 'hash.md5'], + ['process.args', 'args0'], + ['process.args', 'args1'], + ['process.args', 'args2'], ]; beforeEach(() => { @@ -137,17 +137,17 @@ describe(`Resolver: when analyzing a tree with no ancestors and two children and }); it('should show the node details for the first child', async () => { await expect(simulator().map(() => simulator().nodeDetailEntries())).toYieldEqualTo([ - ['Field@timestamp', 'ValueSep 23, 2020 @ 08:25:32.317'], - ['Fieldprocess.executable', 'Valueexecutable'], - ['Fieldprocess.pid', 'Value1'], - ['Fieldprocess.entity_id', 'ValuefirstChild'], - ['Fielduser.name', 'Valueuser.name'], - ['Fielduser.domain', 'Valueuser.domain'], - ['Fieldprocess.parent.pid', 'Value0'], - ['Fieldprocess.hash.md5', 'Valuehash.md5'], - ['Fieldprocess.args', 'Valueargs0'], - ['Fieldprocess.args', 'Valueargs1'], - ['Fieldprocess.args', 'Valueargs2'], + ['@timestamp', 'Sep 23, 2020 @ 08:25:32.317'], + ['process.executable', 'executable'], + ['process.pid', '1'], + ['process.entity_id', 'firstChild'], + ['user.name', 'user.name'], + ['user.domain', 'user.domain'], + ['process.parent.pid', '0'], + ['process.hash.md5', 'hash.md5'], + ['process.args', 'args0'], + ['process.args', 'args1'], + ['process.args', 'args2'], ]); }); }); @@ -220,20 +220,19 @@ describe(`Resolver: when analyzing a tree with no ancestors and two children and return typesAndCounts; }) ).toYieldEqualTo([ - // Because there is no printed whitespace after "Count", the count immediately follows it. - { link: 'registry', type: 'Count2' }, - { link: 'authentication', type: 'Count1' }, - { link: 'database', type: 'Count1' }, - { link: 'driver', type: 'Count1' }, - { link: 'file', type: 'Count1' }, - { link: 'host', type: 'Count1' }, - { link: 'iam', type: 'Count1' }, - { link: 'intrusion_detection', type: 'Count1' }, - { link: 'malware', type: 'Count1' }, - { link: 'network', type: 'Count1' }, - { link: 'package', type: 'Count1' }, - { link: 'process', type: 'Count1' }, - { link: 'web', type: 'Count1' }, + { link: 'registry', type: '2' }, + { link: 'authentication', type: '1' }, + { link: 'database', type: '1' }, + { link: 'driver', type: '1' }, + { link: 'file', type: '1' }, + { link: 'host', type: '1' }, + { link: 'iam', type: '1' }, + { link: 'intrusion_detection', type: '1' }, + { link: 'malware', type: '1' }, + { link: 'network', type: '1' }, + { link: 'package', type: '1' }, + { link: 'process', type: '1' }, + { link: 'web', type: '1' }, ]); }); describe('and when the user clicks the registry events link', () => { From a3a273e6943fb59175ab0e30237f9f7a54f091eb Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 10 Apr 2024 17:47:03 -0700 Subject: [PATCH 20/33] Fix/simplify more mobile vs desktop test assertions - DOM no longer renders for mobile vs desktop whatsoever, so we get to remove a bunch of test utils and just mock a mobile window width instead --- .../check_steps/steps_list.test.tsx | 27 +++++++------- .../legacy_uptime/lib/helper/rtl_helpers.tsx | 35 ------------------- .../event_fields_browser.test.tsx | 8 ----- 3 files changed, 15 insertions(+), 55 deletions(-) diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.test.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.test.tsx index 00b40415adefbc..82c5bbf472eceb 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.test.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.test.tsx @@ -8,7 +8,7 @@ import React from 'react'; import { JourneyStep } from '../../../../../common/runtime_types/ping'; import { StepsList } from './steps_list'; -import { render, forDesktopOnly, forMobileOnly } from '../../../lib/helper/rtl_helpers'; +import { render } from '../../../lib/helper/rtl_helpers'; import { VIEW_PERFORMANCE } from '../../monitor/synthetics/translations'; describe('StepList component', () => { @@ -83,7 +83,7 @@ describe('StepList component', () => { ); expect(getByTestId('step-detail-link')).toHaveAttribute('href', '/journey/fake-group/step/1'); - expect(forDesktopOnly(getByTitle, 'title')(`Failed`)); + expect(getByTitle(`Failed`)).toBeInTheDocument(); }); it.each([ @@ -94,7 +94,7 @@ describe('StepList component', () => { const step = steps[0]; step.synthetics!.payload!.status = status; const { getByText } = render(); - expect(forDesktopOnly(getByText)(expectedStatus)); + expect(getByText(expectedStatus)).toBeInTheDocument(); }); it('creates expected message for all succeeded', () => { @@ -156,24 +156,27 @@ describe('StepList component', () => { }); describe('Mobile Designs', () => { - // We don't need to resize the window here because EUI - // does all the manipulation of what is displayed through - // CSS. Therefore, it's enough to check what's actually - // rendered and its classes. + const jestWindowWidth = window.innerWidth; + beforeAll(() => { + window.innerWidth = 600; + }); + afterAll(() => { + window.innerWidth = jestWindowWidth; + }); it('renders the step name and index', () => { const { getByText } = render( ); - expect(forMobileOnly(getByText)('1. load page')).toBeInTheDocument(); - expect(forMobileOnly(getByText)('2. go to login')).toBeInTheDocument(); + expect(getByText('1. load page')).toBeInTheDocument(); + expect(getByText('2. go to login')).toBeInTheDocument(); }); it('does not render the link to view step details', async () => { const { queryByText } = render( ); - expect(forMobileOnly(queryByText)(VIEW_PERFORMANCE)).not.toBeInTheDocument(); + expect(queryByText(VIEW_PERFORMANCE)).not.toBeInTheDocument(); }); it('renders the status label', () => { @@ -183,8 +186,8 @@ describe('StepList component', () => { const { getByText } = render( ); - expect(forMobileOnly(getByText)('Succeeded')).toBeInTheDocument(); - expect(forMobileOnly(getByText)('Skipped')).toBeInTheDocument(); + expect(getByText('Succeeded')).toBeInTheDocument(); + expect(getByText('Skipped')).toBeInTheDocument(); }); }); }); diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/lib/helper/rtl_helpers.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/lib/helper/rtl_helpers.tsx index 0b23c089385d7c..9ca652edb9cc48 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/lib/helper/rtl_helpers.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/lib/helper/rtl_helpers.tsx @@ -356,38 +356,3 @@ export const makeUptimePermissionsCore = ( }, }; }; - -// This function filters out the queried elements which appear only -// either on mobile or desktop. -// -// It does so by filtering those with the class passed as the `classWrapper`. -// For mobile, we filter classes which tell elements to be hidden on desktop. -// For desktop, we do the opposite. -// -// We have this function because EUI will manipulate the visibility of some -// elements through pure CSS, which we can't assert on tests. Therefore, -// we look for the corresponding class wrapper. -const finderWithClassWrapper = - (classWrapper: string) => - ( - getterFn: (f: MatcherFunction) => HTMLElement | null, - customAttribute?: keyof Element | keyof HTMLElement - ) => - (text: string): HTMLElement | null => - getterFn((_content: string, node: Element | null) => { - if (!node) return false; - // There are actually properties that are not in Element but which - // appear on the `node`, so we must cast the customAttribute as a keyof Element - const content = node[(customAttribute as keyof Element) ?? 'innerHTML']; - if (content === text && wrappedInClass(node, classWrapper)) return true; - return false; - }); - -const wrappedInClass = (element: HTMLElement | Element, classWrapper: string): boolean => { - if (element.className.includes(classWrapper)) return true; - if (element.parentElement) return wrappedInClass(element.parentElement, classWrapper); - return false; -}; - -export const forMobileOnly = finderWithClassWrapper('hideForDesktop'); -export const forDesktopOnly = finderWithClassWrapper('hideForMobile'); diff --git a/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx b/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx index cfe1def2b9da2e..570029e1c3c0ba 100644 --- a/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx +++ b/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx @@ -17,14 +17,6 @@ import { TimelineTabs } from '../../../../common/types/timeline'; jest.mock('../../lib/kibana'); -jest.mock('@elastic/eui', () => { - const original = jest.requireActual('@elastic/eui'); - return { - ...original, - EuiScreenReaderOnly: () => <>, - }; -}); - jest.mock('../../hooks/use_get_field_spec'); jest.mock('@kbn/cell-actions/src/hooks/use_load_actions', () => { From e5e3aa907b8d896090ca0d5c931c6f8183657e56 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 11 Apr 2024 11:58:44 -0700 Subject: [PATCH 21/33] Fix FTR selectors to account for removed modifier classNames/updated DOM --- test/functional/services/inspector.ts | 2 +- .../e2e/synthetics/journeys/test_now_mode.journey.ts | 4 +--- x-pack/test/functional/services/ml/stack_management_jobs.ts | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/test/functional/services/inspector.ts b/test/functional/services/inspector.ts index 2b9fef9818dd03..348f37281156e5 100644 --- a/test/functional/services/inspector.ts +++ b/test/functional/services/inspector.ts @@ -144,7 +144,7 @@ export class InspectorService extends FtrService { return await inspectorPanel.findByTagName('thead'); }); const $ = await dataTableHeader.parseDomContent(); - return $('th span.euiTableCellContent__text') + return $('th .euiTableCellContent span') .toArray() .map((cell) => $(cell).text().trim()); } diff --git a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/test_now_mode.journey.ts b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/test_now_mode.journey.ts index 9df533b4df2ed3..4e543c325f4279 100644 --- a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/test_now_mode.journey.ts +++ b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/test_now_mode.journey.ts @@ -136,9 +136,7 @@ journey(`TestNowMode`, async ({ page, params }) => { await services.addTestSummaryDocument({ testRunId, docType: 'stepEnd', stepIndex: 1 }); await page.waitForSelector('text=1 step completed'); - await page.waitForSelector( - '.euiTableRowCell--hideForMobile :has-text("Go to https://www.google.com")' - ); + await page.waitForSelector('.euiTableRowCell:has-text("Go to https://www.google.com")'); expect(await page.getByTestId('stepDurationText1').first()).toHaveText('1.4 sec'); await page.waitForSelector('text=Complete'); }); diff --git a/x-pack/test/functional/services/ml/stack_management_jobs.ts b/x-pack/test/functional/services/ml/stack_management_jobs.ts index 63c2005650c0d9..bbf985d4c0d678 100644 --- a/x-pack/test/functional/services/ml/stack_management_jobs.ts +++ b/x-pack/test/functional/services/ml/stack_management_jobs.ts @@ -446,7 +446,7 @@ export function MachineLearningStackManagementJobsProvider({ const ids: string[] = []; for (const row of rows) { - const cols = await row.findAllByClassName('euiTableRowCell euiTableRowCell--middle'); + const cols = await row.findAllByClassName('euiTableRowCell'); if (cols.length) { ids.push(await cols[0].getVisibleText()); } From ed44615e203235edde2bd6d2730f1e5ad4ce486c Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 10 Apr 2024 15:55:49 -0700 Subject: [PATCH 22/33] Fix FTR selectors around actions `findDescendent` requires "displayed" state, aka for visibility to be true, which in this case isn't because of `showOnHover` action opacity CSS/UX Switching to just `.find` instead doesn't have a visibility requirement --- .../e2e/synthetics/journeys/private_locations.journey.ts | 4 ++-- .../test/functional/page_objects/tag_management_page.ts | 2 +- .../functional/services/ml/data_frame_analytics_table.ts | 8 ++++++-- 3 files changed, 9 insertions(+), 5 deletions(-) diff --git a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts index 79a24ad342b7ca..b9a9b23d16ca7f 100644 --- a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts +++ b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts @@ -120,7 +120,7 @@ journey(`PrivateLocationsSettings`, async ({ page, params }) => { await page.click('text=Private Locations'); await page.waitForSelector('td:has-text("1")'); await page.waitForSelector('td:has-text("Test private")'); - await page.click('.euiTableCellContent__hoverItem .euiToolTipAnchor'); + await page.click('.euiTableRowCell .euiToolTipAnchor'); await page.click('button:has-text("Tags")'); await page.click('[aria-label="Tags"] >> text=Area51'); await page.click( @@ -128,7 +128,7 @@ journey(`PrivateLocationsSettings`, async ({ page, params }) => { ); await page.click('text=Test private'); - await page.click('.euiTableCellContent__hoverItem .euiToolTipAnchor'); + await page.click('.euiTableRowCell .euiToolTipAnchor'); await page.locator(byTestId(`deleteLocation-${locationId}`)).isDisabled(); diff --git a/x-pack/test/functional/page_objects/tag_management_page.ts b/x-pack/test/functional/page_objects/tag_management_page.ts index 68100ef3ad6dbb..9f8c91f084eda5 100644 --- a/x-pack/test/functional/page_objects/tag_management_page.ts +++ b/x-pack/test/functional/page_objects/tag_management_page.ts @@ -381,7 +381,7 @@ export class TagManagementPageObject extends FtrService { async clickEdit(tagName: string) { const tagRow = await this.getRowByName(tagName); if (tagRow) { - const editButton = await this.testSubjects.findDescendant('tagsTableAction-edit', tagRow); + const editButton = await tagRow.findByTestSubject('tagsTableAction-edit'); await editButton?.click(); } } diff --git a/x-pack/test/functional/services/ml/data_frame_analytics_table.ts b/x-pack/test/functional/services/ml/data_frame_analytics_table.ts index c85e38cd78b8ed..3279013f980698 100644 --- a/x-pack/test/functional/services/ml/data_frame_analytics_table.ts +++ b/x-pack/test/functional/services/ml/data_frame_analytics_table.ts @@ -147,11 +147,15 @@ export function MachineLearningDataFrameAnalyticsTableProvider({ } public async assertJobRowViewButtonExists(analyticsId: string) { - await testSubjects.existOrFail(this.rowSelector(analyticsId, 'mlAnalyticsJobViewButton')); + await testSubjects.existOrFail(this.rowSelector(analyticsId, 'mlAnalyticsJobViewButton'), { + allowHidden: true, // Table action may be only visible on row hover + }); } public async assertJobRowMapButtonExists(analyticsId: string) { - await testSubjects.existOrFail(this.rowSelector(analyticsId, 'mlAnalyticsJobMapButton')); + await testSubjects.existOrFail(this.rowSelector(analyticsId, 'mlAnalyticsJobMapButton'), { + allowHidden: true, // Table action may be only visible on row hover + }); } public async assertJobRowViewButtonEnabled(analyticsId: string, expectedValue: boolean) { From 56ed18abd8a912061e1b3723135837cfda00c1fd Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 11 Apr 2024 10:41:24 -0700 Subject: [PATCH 23/33] Fix failing FTR tests caused by examples missing EUI breakpoints provider - without the provider, tables will incorrectly rendering in mobile view --- .../public/app.tsx | 11 ++-- examples/field_formats_example/public/app.tsx | 51 ++++++++-------- .../files_example/public/components/app.tsx | 5 +- .../public/app/app.tsx | 61 ++++++++++--------- 4 files changed, 69 insertions(+), 59 deletions(-) diff --git a/examples/data_view_field_editor_example/public/app.tsx b/examples/data_view_field_editor_example/public/app.tsx index d4e0974366a6b6..336c29aa2a1cac 100644 --- a/examples/data_view_field_editor_example/public/app.tsx +++ b/examples/data_view_field_editor_example/public/app.tsx @@ -7,6 +7,7 @@ */ import { + EuiProvider, DefaultItemAction, EuiButton, EuiCheckbox, @@ -134,10 +135,12 @@ const DataViewFieldEditorExample = ({ dataView, dataViewFieldEditor }: Props) => ); return ( - - - {content} - + + + + {content} + + ); }; diff --git a/examples/field_formats_example/public/app.tsx b/examples/field_formats_example/public/app.tsx index 112b0a8d4f0aed..2961925f0a1607 100644 --- a/examples/field_formats_example/public/app.tsx +++ b/examples/field_formats_example/public/app.tsx @@ -14,6 +14,7 @@ import { EuiCodeBlock, EuiLink, EuiPageTemplate, + EuiProvider, EuiSpacer, EuiText, EuiTitle, @@ -166,29 +167,31 @@ const CreatingCustomFieldFormatEditor: React.FC<{ deps: Deps }> = (props) => { export const App: React.FC<{ deps: Deps }> = (props) => { return ( - - - - -

Using an existing field format

- - - - - - -

Creating a custom field format

- - - - - - -

Creating a custom field format editor

- - - - - + + + + + +

Using an existing field format

+ + + + + + +

Creating a custom field format

+ + + + + + +

Creating a custom field format editor

+ + + + + + ); }; diff --git a/examples/files_example/public/components/app.tsx b/examples/files_example/public/components/app.tsx index db0968d7b43f23..5fea8c5fbc42d6 100644 --- a/examples/files_example/public/components/app.tsx +++ b/examples/files_example/public/components/app.tsx @@ -12,6 +12,7 @@ import type { FileJSON } from '@kbn/files-plugin/common'; import type { FilesClientResponses } from '@kbn/files-plugin/public'; import { + EuiProvider, EuiPageTemplate, EuiInMemoryTable, EuiInMemoryTableProps, @@ -131,7 +132,7 @@ export const FilesExampleApp = ({ files, notifications }: FilesExampleAppDeps) = ]; return ( - <> + @@ -185,6 +186,6 @@ export const FilesExampleApp = ({ files, notifications }: FilesExampleAppDeps) = }} /> )} - + ); }; diff --git a/examples/partial_results_example/public/app/app.tsx b/examples/partial_results_example/public/app/app.tsx index c71711f785c670..fb0fe9e3dbef4a 100644 --- a/examples/partial_results_example/public/app/app.tsx +++ b/examples/partial_results_example/public/app/app.tsx @@ -9,6 +9,7 @@ import React, { useContext, useEffect, useState } from 'react'; import { pluck } from 'rxjs'; import { + EuiProvider, EuiBasicTable, EuiCallOut, EuiCodeBlock, @@ -40,34 +41,36 @@ export function App() { }, [expressions]); return ( - - - - -

- This example listens for the window events and adds them to the table along with a - trigger counter. -

- - - {expression} - - {datatable ? ( - ({ - field, - name, - 'data-test-subj': `example-column-${field.toLowerCase()}`, - }))} - items={datatable.rows ?? []} - /> - ) : ( - -

Click or press any key.

- - )} - - + + + + + +

+ This example listens for the window events and adds them to the table along with a + trigger counter. +

+ + + {expression} + + {datatable ? ( + ({ + field, + name, + 'data-test-subj': `example-column-${field.toLowerCase()}`, + }))} + items={datatable.rows ?? []} + /> + ) : ( + +

Click or press any key.

+ + )} + + + ); } From 67e69d823f60b459902e78f27fa859a95bdf0640 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 11 Apr 2024 11:35:13 -0700 Subject: [PATCH 24/33] Update table cell chart CSS to account for changes - `className`/`css` not applies directly to the `` cell and not the content --- .../components/change_point_detection/change_points_table.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx b/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx index e94db623362351..308a4d8dc22b08 100644 --- a/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx +++ b/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx @@ -153,9 +153,7 @@ export const ChangePointsTable: FC = ({ truncateText: false, valign: 'middle', css: { - // Extra specificity needed here to override Sass styles - // TODO: Can be removed once EuiTable has been converted to Emotion - ['&.euiTableCellContent']: { display: 'block', padding: 0 }, + '.euiTableCellContent': { display: 'block', padding: 0 }, }, render: (annotation: ChangePointAnnotation) => { return ( From 7213048bb9d5e10337cc5fccfe83799a3885d421 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Fri, 12 Apr 2024 13:05:55 -0700 Subject: [PATCH 25/33] Update EUI to grab backport with latest table fixes + more i18n updates from a11y improvements --- package.json | 2 +- .../src/__snapshots__/i18n_service.test.tsx.snap | 2 +- .../src/i18n_eui_mapping.tsx | 10 ++++++---- src/dev/license_checker/config.ts | 2 +- x-pack/plugins/translations/translations/fr-FR.json | 1 - x-pack/plugins/translations/translations/ja-JP.json | 1 - x-pack/plugins/translations/translations/zh-CN.json | 1 - yarn.lock | 8 ++++---- 8 files changed, 13 insertions(+), 14 deletions(-) diff --git a/package.json b/package.json index 346bd231bc1f27..13fbbfe8eeddab 100644 --- a/package.json +++ b/package.json @@ -107,7 +107,7 @@ "@elastic/ecs": "^8.11.1", "@elastic/elasticsearch": "^8.13.0", "@elastic/ems-client": "8.5.1", - "@elastic/eui": "94.1.0", + "@elastic/eui": "94.1.0-backport.0", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "1.2.1", "@elastic/numeral": "^2.5.1", diff --git a/packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap b/packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap index 44170ebcfb06e7..d9fc8ecec80503 100644 --- a/packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap +++ b/packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap @@ -14,7 +14,7 @@ exports[`#start() returns \`Context\` component 1`] = ` "euiAutoRefresh.buttonLabelOn": [Function], "euiBasicTable.noItemsMessage": "No items found", "euiBasicTable.selectAllRows": "Select all rows", - "euiBasicTable.selectThisRow": "Select this row", + "euiBasicTable.selectThisRow": [Function], "euiBasicTable.tableAutoCaptionWithPagination": [Function], "euiBasicTable.tableAutoCaptionWithoutPagination": [Function], "euiBasicTable.tableCaptionWithPagination": [Function], diff --git a/packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx b/packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx index e4f769c8779c7e..3ea767bc5b6bc9 100644 --- a/packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx +++ b/packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx @@ -38,10 +38,12 @@ export const getEuiContextMapping = (): EuiTokensObject => { defaultMessage: 'Select all rows', description: 'ARIA and displayed label on a checkbox to select all table rows', }), - 'euiBasicTable.selectThisRow': i18n.translate('core.euiBasicTable.selectThisRow', { - defaultMessage: 'Select this row', - description: 'ARIA and displayed label on a checkbox to select a single table row', - }), + 'euiBasicTable.selectThisRow': ({ index }: EuiValues) => + i18n.translate('core.euiBasicTable.selectThisRow', { + defaultMessage: 'Select row {index}', + values: { index }, + description: 'ARIA and displayed label on a checkbox to select a single table row', + }), 'euiBasicTable.tableCaptionWithPagination': ({ tableCaption, page, pageCount }: EuiValues) => i18n.translate('core.euiBasicTable.tableCaptionWithPagination', { defaultMessage: '{tableCaption}; Page {page} of {pageCount}.', diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index a0c6e784aa61ca..c708ab543476db 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -86,7 +86,7 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.5.1': ['Elastic License 2.0'], - '@elastic/eui@94.1.0': ['SSPL-1.0 OR Elastic License 2.0'], + '@elastic/eui@94.1.0-backport.0': ['SSPL-1.0 OR Elastic License 2.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry 'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary '@bufbuild/protobuf@1.2.1': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause) diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json index c4e6e574983ec0..d4a03e72d5d6b7 100644 --- a/x-pack/plugins/translations/translations/fr-FR.json +++ b/x-pack/plugins/translations/translations/fr-FR.json @@ -692,7 +692,6 @@ "core.euiAutoRefresh.buttonLabelOff": "L'actualisation automatique est désactivée", "core.euiBasicTable.noItemsMessage": "Aucun élément n'a été trouvé", "core.euiBasicTable.selectAllRows": "Sélectionner toutes les lignes", - "core.euiBasicTable.selectThisRow": "Sélectionner cette ligne", "core.euiBottomBar.screenReaderAnnouncement": "Il y a un nouveau repère de région avec des commandes de niveau de page à la fin du document.", "core.euiBottomBar.screenReaderHeading": "Commandes de niveau de page", "core.euiBreadcrumb.collapsedBadge.ariaLabel": "Voir le fil d’Ariane réduit", diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index c0315dade2da45..509fd6b9b37750 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -692,7 +692,6 @@ "core.euiAutoRefresh.buttonLabelOff": "自動更新はオフです", "core.euiBasicTable.noItemsMessage": "項目が見つかりません", "core.euiBasicTable.selectAllRows": "すべての行を選択", - "core.euiBasicTable.selectThisRow": "この行を選択", "core.euiBottomBar.screenReaderAnnouncement": "ドキュメントの最後には、新しいリージョンランドマークとページレベルのコントロールがあります。", "core.euiBottomBar.screenReaderHeading": "ページレベルのコントロール", "core.euiBreadcrumb.collapsedBadge.ariaLabel": "折りたたまれたブレッドクラムを表示", diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index b63dca733bba9f..7b2391408aaa66 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -694,7 +694,6 @@ "core.euiAutoRefresh.buttonLabelOff": "自动刷新已关闭", "core.euiBasicTable.noItemsMessage": "找不到项目", "core.euiBasicTable.selectAllRows": "选择所有行", - "core.euiBasicTable.selectThisRow": "选择此行", "core.euiBottomBar.screenReaderAnnouncement": "有页面级别控件位于文档结尾的新地区地标。", "core.euiBottomBar.screenReaderHeading": "页面级别控件", "core.euiBreadcrumb.collapsedBadge.ariaLabel": "查看折叠的痕迹导航", diff --git a/yarn.lock b/yarn.lock index eb7a42a0f0f8f5..736c44d9474d06 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1752,10 +1752,10 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui@94.1.0": - version "94.1.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-94.1.0.tgz#39fea7dc983206ccc9917fc912631b8947ca68ca" - integrity sha512-93OujrKqgK5UvzRjy/+7cVx6s4Xq8SjDqCsqZvct4aQAkVLrFZhO8tVoYJrTds5bvz6Pb2LCe2HR90U1LlHHGw== +"@elastic/eui@94.1.0-backport.0": + version "94.1.0-backport.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-94.1.0-backport.0.tgz#93ad707b12785a7e0198af333cdee8d1acdcf35e" + integrity sha512-WFUpYBUgbJfcJInjhyQpOYGFs7JGpBMwpgmbRbKmyf3bJb0yqZeaiL5Qwyk6hOl8j1CSRvcaWOT/P33JxdrV3w== dependencies: "@hello-pangea/dnd" "^16.3.0" "@types/lodash" "^4.14.202" From 8d9b3627a7609bc13fa8283984e5672a2a0d6b36 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Tue, 16 Apr 2024 10:46:17 -0700 Subject: [PATCH 26/33] [PR feedback] Increase actions column width --- .../public/components/doc_viewer_table/legacy/table_columns.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table_columns.tsx b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table_columns.tsx index 4b79a849706987..eac6ba9505f1bd 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table_columns.tsx +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table_columns.tsx @@ -17,7 +17,7 @@ import { TableFieldValue } from '../table_cell_value'; export const ACTIONS_COLUMN: EuiBasicTableColumn = { field: 'action', className: 'kbnDocViewer__tableActionsCell', - width: '108px', + width: '120px', mobileOptions: { header: false }, name: ( From 4055eff2c627bb8fee1bee32d8e21a4425b245de Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Tue, 16 Apr 2024 11:20:04 -0700 Subject: [PATCH 27/33] [PR feedback] Fix custom table cell `className` CSS --- .../doc_viewer_table/legacy/table_columns.tsx | 2 +- .../public/components/doc_viewer_table/table.scss | 12 ++++++++---- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table_columns.tsx b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table_columns.tsx index eac6ba9505f1bd..4b79a849706987 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table_columns.tsx +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table_columns.tsx @@ -17,7 +17,7 @@ import { TableFieldValue } from '../table_cell_value'; export const ACTIONS_COLUMN: EuiBasicTableColumn = { field: 'action', className: 'kbnDocViewer__tableActionsCell', - width: '120px', + width: '108px', mobileOptions: { header: false }, name: ( diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss index c3d3631177c4e5..881e9881111298 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss @@ -41,13 +41,17 @@ .kbnDocViewer__tableActionsCell, .kbnDocViewer__tableFieldNameCell { - align-items: flex-start; - padding: $euiSizeXS; + .euiTableCellContent { + align-items: flex-start; + padding: $euiSizeXS; + } } .kbnDocViewer__tableValueCell { - flex-direction: column; - align-items: flex-start; + .euiTableCellContent { + flex-direction: column; + align-items: flex-start; + } } .kbnDocViewer__value { From c48425eea5c8969d11cecfa7aafb84d4f870630d Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 17 Apr 2024 22:00:39 -0700 Subject: [PATCH 28/33] [Infra][Hosts] Fix truncation on `Command` column --- .../asset_details/tabs/processes/processes_table.tsx | 3 +++ 1 file changed, 3 insertions(+) diff --git a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/processes/processes_table.tsx b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/processes/processes_table.tsx index 56e327843250f7..87d4d7d9b5aa73 100644 --- a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/processes/processes_table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/processes/processes_table.tsx @@ -252,6 +252,7 @@ const ProcessesTableBody = ({ items, currentTime }: TableBodyProps) => ( mobileOptions={{ header: column.name }} align={column.align ?? LEFT_ALIGNMENT} textOnly={column.textOnly ?? true} + truncateText={column.truncateText} > {column.render ? column.render(item[column.field], currentTime) : item[column.field]} @@ -291,6 +292,7 @@ const columns: Array<{ render?: Function; width?: string | number; textOnly?: boolean; + truncateText?: boolean; align?: typeof RIGHT_ALIGNMENT | typeof LEFT_ALIGNMENT; }> = [ { @@ -310,6 +312,7 @@ const columns: Array<{ }), sortable: false, width: '40%', + truncateText: true, render: (command: string) => , }, { From fa99ad8d20301240a65260cdefd8e230e268b4fd Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 17 Apr 2024 22:17:16 -0700 Subject: [PATCH 29/33] [APM][Services] Fix overview tables custom CSS - `:first-child` CSS no longer works well since `EuiBasicTable` no longer adds a `
` wrapper around the `` + additionally fix Errors table to align the pagination bar to the bottom, like the Transactions and Dependencies tables --- .../service_overview_errors_table/index.tsx | 17 ++++++++++------- .../shared/overview_table_container/index.tsx | 5 +++-- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/x-pack/plugins/observability_solution/apm/public/components/app/service_overview/service_overview_errors_table/index.tsx b/x-pack/plugins/observability_solution/apm/public/components/app/service_overview/service_overview_errors_table/index.tsx index fd77708d306c79..a630cb7a2bc605 100644 --- a/x-pack/plugins/observability_solution/apm/public/components/app/service_overview/service_overview_errors_table/index.tsx +++ b/x-pack/plugins/observability_solution/apm/public/components/app/service_overview/service_overview_errors_table/index.tsx @@ -9,6 +9,7 @@ import { EuiFlexGroup, EuiFlexItem, EuiTitle } from '@elastic/eui'; import { i18n } from '@kbn/i18n'; import React from 'react'; import { useApmParams } from '../../../../hooks/use_apm_params'; +import { OverviewTableContainer } from '../../../shared/overview_table_container'; import { ErrorOverviewLink } from '../../../shared/links/apm/error_overview_link'; import { ErrorGroupList } from '../../error_group_overview/error_group_list'; @@ -42,13 +43,15 @@ export function ServiceOverviewErrorsTable({ serviceName }: Props) { - + + + ); diff --git a/x-pack/plugins/observability_solution/apm/public/components/shared/overview_table_container/index.tsx b/x-pack/plugins/observability_solution/apm/public/components/shared/overview_table_container/index.tsx index 0974b4ee63287f..c77c3e7cc7a922 100644 --- a/x-pack/plugins/observability_solution/apm/public/components/shared/overview_table_container/index.tsx +++ b/x-pack/plugins/observability_solution/apm/public/components/shared/overview_table_container/index.tsx @@ -42,8 +42,9 @@ const OverviewTableContainerDiv = euiStyled.div<{ flex-direction: column; flex-grow: 1; - > :first-child { - flex-grow: 1; + /* Align the pagination to the bottom of the card */ + > :last-child { + margin-top: auto; } `} From 718fc3cb1695623c0160131cf192b9346e30f7db Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Wed, 17 Apr 2024 22:57:37 -0700 Subject: [PATCH 30/33] Increase various column widths with text that are now cut off due to new sortable icon MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit + use first custom `responsiveBreakpoint` to handle table with lots of columns!! 🎉 --- .../management_section/objects_table/components/table.tsx | 2 +- .../public/pages/metrics/hosts/components/hosts_table.tsx | 2 ++ .../public/pages/metrics/hosts/hooks/use_hosts_table.tsx | 6 +++--- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx b/src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx index 1d2e2e14b4050a..8cd7234e2591b1 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx @@ -234,7 +234,7 @@ export class Table extends PureComponent { name: i18n.translate('savedObjectsManagement.objectsTable.table.columnTypeName', { defaultMessage: 'Type', }), - width: '50px', + width: '65px', align: 'center', description: i18n.translate( 'savedObjectsManagement.objectsTable.table.columnTypeDescription', diff --git a/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx b/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx index ab4fd6a1b79c51..cc0b7302da20ad 100644 --- a/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx @@ -41,6 +41,8 @@ export const HostsTable = () => { /> { return items.sort(sortTableData(sorting)).slice(startIndex, endIndex); }, [items, pagination, sorting]); - const metricColumnsWidth = displayAlerts ? '11%' : '15%'; + const metricColumnsWidth = displayAlerts ? '12%' : '16%'; const columns: Array> = useMemo( () => [ @@ -360,7 +360,7 @@ export const useHostsTable = () => { formula={formulas?.rx.value} /> ), - width: '10%', + width: '12%', field: 'rx', sortable: true, 'data-test-subj': 'hostsView-tableRow-rx', @@ -375,7 +375,7 @@ export const useHostsTable = () => { formula={formulas?.tx.value} /> ), - width: '10%', + width: '12%', field: 'tx', sortable: true, 'data-test-subj': 'hostsView-tableRow-tx', From e8a856b7d72aa447a78e1e383d6ad378527f5272 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 18 Apr 2024 08:34:45 -0700 Subject: [PATCH 31/33] Update snapshot from updated table --- .../components/__snapshots__/table.test.tsx.snap | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap index f03a255106acc3..528ec071e3c84f 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap @@ -144,7 +144,7 @@ exports[`Table prevents hidden saved objects from being deleted 1`] = ` "name": "Type", "render": [Function], "sortable": true, - "width": "50px", + "width": "65px", }, Object { "data-test-subj": "savedObjectsTableRowTitle", @@ -383,7 +383,7 @@ exports[`Table should render normally 1`] = ` "name": "Type", "render": [Function], "sortable": true, - "width": "50px", + "width": "65px", }, Object { "data-test-subj": "savedObjectsTableRowTitle", From ac4aa7d3ef25fb4b811469721b305b796301f7cd Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 18 Apr 2024 08:40:48 -0700 Subject: [PATCH 32/33] [Security][Data Quality] Increase width of column to account for sortable icon --- .../data_quality/data_quality_panel/summary_table/helpers.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx index 6af80a1e0628e1..6d135477b9af33 100644 --- a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx +++ b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx @@ -194,7 +194,7 @@ export const getSummaryTableColumns = ({ ), sortable: true, truncateText: false, - width: '50px', + width: '65px', }, { field: 'indexName', From 061273bbf404ede67af959cdaecd9bd3d56d6175 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Thu, 18 Apr 2024 10:08:06 -0700 Subject: [PATCH 33/33] Update test w/ updated column width --- .../data_quality_panel/summary_table/helpers.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx index 8209e96a22ea44..673a74e357b662 100644 --- a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx +++ b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx @@ -177,7 +177,7 @@ describe('helpers', () => { name: 'Result', sortable: true, truncateText: false, - width: '50px', + width: '65px', }, { field: 'indexName', name: 'Index', sortable: true, truncateText: false, width: '300px' }, { field: 'docsCount', name: 'Docs', sortable: true, truncateText: false },