Debug around ML rule execution #189307
Closed
Debug around ML rule execution #189307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's see if we can't find why these rules aren't generating alerts.
None of these are showing up in the build. It's not yet clear whether this is a log level / file descriptor issue, or whether our code just isn't being executed.
I'm not seeing these on CI.
Maybe we can see this?
Understanding what happens during the first rule execution (if there is one) might help us to understand why we're not generating alerts that first time.
If the rule is going to eventually succeed, we should see this eventually resolve if the problem lies in the rule executor's handling of the failure.
This should give better granularity on the following: * How long it takes for the ML job to become "started" * How long it takes for the metrics to become available
See previous commit for context.
There's still a chance that the datafeed/job will _no longer_ be ready by the time we hit the failing MKI tests (or maybe the timing issue pops up years from now 😉), but if this makes our tests more consistent we can start to focus on this: better ML integration.
Let's see how long these are pausing; that might indicate an issue.
Despite our job being started, we're now receiving _no_ alerts when before we had some. I think this is because the job is starting, but no anomalies are ready yet. This should validate that hypothesis.
This is less restrictive than the ML helper, which seems to wait for the job to report as having processed records. Let's see if this implementation works for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if we can't find why these rules aren't generating alerts.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers