[Discover] Dismiss flyouts when opening another one #193865
Conversation
jughosta
added
release_note:skip
jughosta
changed the title
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
There was a problem hiding this comment.
While it looks ok as is, I think there are still some minor inconsistencies in discover about fly-outs, in particular with the Inspect and Alert / create rule who do not close the fly-outs underneath.
Perhaps it is arguably a different experience and it still makes sense to keep the fly-outs underneath open there, just worth mentioning it.
From the UX prospective the annoying bit here is the different width of the various fly-outs that makes the layout jump more with this PR changes. While the document flyout is a resizable panel, the other two have fixed width which would be nice to align to avoid too many jumps.
There was a problem hiding this comment.
ES|QL changes LGTM. (just a data-test-subj).
Maybe we should create an issue about the flyout manager that we were discussing cc @davismcphee. From my understanding this would be the fast fix till we do something better.
There was a problem hiding this comment.
Code changes look good and it works as intended, thanks!
While the document flyout is a resizable panel, the other two have fixed width which would be nice to align to avoid too many jumps.
Maybe the solution is to just make them all resizable? 🙂
Maybe we should create an issue about the flyout manager that we were discussing cc @davismcphee. From my understanding this would be the fast fix till we do something better.
It is and I agree, I created an issue for it here: #194239.
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: cc @jughosta |
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11066513519 |
- Closes elastic#193452 ## Summary This PR makes sure that only one flyout is open at a time and automatically dismisses all others. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) (cherry picked from commit 6fc017a)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…194256) # Backport This will backport the following commits from `main` to `8.x`: - [[Discover] Dismiss flyouts when opening another one (#193865)](#193865) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Rechkunova","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T07:35:31Z","message":"[Discover] Dismiss flyouts when opening another one (#193865)\n\n- Closes https://github.com/elastic/kibana/issues/193452\r\n\r\n## Summary\r\n\r\nThis PR makes sure that only one flyout is open at a time and\r\nautomatically dismisses all others.\r\n\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"6fc017a597fc34158313b8537f6b6a2536833cba","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:DataDiscovery","backport:prev-minor","Feature:ES|QL"],"title":"[Discover] Dismiss flyouts when opening another one","number":193865,"url":"https://github.com/elastic/kibana/pull/193865","mergeCommit":{"message":"[Discover] Dismiss flyouts when opening another one (#193865)\n\n- Closes https://github.com/elastic/kibana/issues/193452\r\n\r\n## Summary\r\n\r\nThis PR makes sure that only one flyout is open at a time and\r\nautomatically dismisses all others.\r\n\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"6fc017a597fc34158313b8537f6b6a2536833cba"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193865","number":193865,"mergeCommit":{"message":"[Discover] Dismiss flyouts when opening another one (#193865)\n\n- Closes https://github.com/elastic/kibana/issues/193452\r\n\r\n## Summary\r\n\r\nThis PR makes sure that only one flyout is open at a time and\r\nautomatically dismisses all others.\r\n\r\n\r\n### Checklist\r\n\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)","sha":"6fc017a597fc34158313b8537f6b6a2536833cba"}}]}] BACKPORT--> Co-authored-by: Julia Rechkunova <[email protected]>
Summary
This PR makes sure that only one flyout is open at a time and automatically dismisses all others.
Checklist