Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SLOs] Slo form little things #193990

Merged
merged 3 commits into from
Sep 27, 2024
Merged

[SLOs] Slo form little things #193990

merged 3 commits into from
Sep 27, 2024

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Sep 25, 2024 •
edited by kibanamachine
Loading

Summary

Slo form little things !!

Will auto add values for APM defaults to all instead of forcing user !!

Changes

Details Before After
Data View component image image
APM SLI image image

@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 marked this pull request as ready for review September 26, 2024 09:49
@shahzad31 shahzad31 requested review from a team as code owners September 26, 2024 09:49
@shahzad31 shahzad31 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes labels Sep 26, 2024
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-management Observability Management User Experience Team labels Sep 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
slo 844 846 +2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 855.1KB 854.2KB -941.0B
unifiedSearch 347.2KB 347.2KB +39.0B
total -902.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

markov00
markov00 approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, done just a code review on owned files

mgiota
mgiota approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@mgiota mgiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shahzad31 shahzad31 merged commit c2a2042 into elastic:main Sep 27, 2024
23 checks passed
@shahzad31 shahzad31 deleted the slo-form-imp branch September 27, 2024 11:04
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11069476859

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Sep 27, 2024
@shahzad31
[SLOs] Slo form little things (elastic#193990)
7bbd943 
## Summary

Slo form little things !!

Will auto add values for APM defaults to all instead of forcing user !!

### Changes

Details | Before | After
-- | -- | --
Data View component | <img width="1262" alt="image"
src="https://github.com/user-attachments/assets/79a5cbcd-04e1-49e6-aa86-036b36c8a6e6">
| <img width="1391" alt="image"
src="https://github.com/user-attachments/assets/973db8f5-179d-4f89-b57b-39c7b57eb360">
APM SLI | <img width="1183" alt="image"
src="https://github.com/user-attachments/assets/a3e083fa-df13-408b-b02d-e26695398225">
| <img width="1158" alt="image"
src="https://github.com/user-attachments/assets/a94cfe07-32b0-4367-95e8-ab10d232e98c">

(cherry picked from commit c2a2042)
@kibanamachine kibanamachine mentioned this pull request Sep 27, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Sep 27, 2024
@kibanamachine @shahzad31
[8.x] [SLOs] Slo form little things (#193990) (#194284)
869fe87 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[SLOs] Slo form little things
(#193990)](#193990)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-09-27T11:04:20Z","message":"[SLOs]
Slo form little things (#193990)\n\n## Summary\r\n\r\nSlo form little
things !!\r\n\r\nWill auto add values for APM defaults to all instead of
forcing user !!\r\n\r\n### Changes \r\n\r\nDetails | Before |
After\r\n-- | -- | --\r\nData View component | <img width=\"1262\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/79a5cbcd-04e1-49e6-aa86-036b36c8a6e6\">\r\n|
<img width=\"1391\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/973db8f5-179d-4f89-b57b-39c7b57eb360\">\r\nAPM
SLI | <img width=\"1183\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a3e083fa-df13-408b-b02d-e26695398225\">\r\n|
<img width=\"1158\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a94cfe07-32b0-4367-95e8-ab10d232e98c\">","sha":"c2a204269af459fc05145d2977493ad975c8df62","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[SLOs]
Slo form little
things","number":193990,"url":"https://github.com/elastic/kibana/pull/193990","mergeCommit":{"message":"[SLOs]
Slo form little things (#193990)\n\n## Summary\r\n\r\nSlo form little
things !!\r\n\r\nWill auto add values for APM defaults to all instead of
forcing user !!\r\n\r\n### Changes \r\n\r\nDetails | Before |
After\r\n-- | -- | --\r\nData View component | <img width=\"1262\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/79a5cbcd-04e1-49e6-aa86-036b36c8a6e6\">\r\n|
<img width=\"1391\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/973db8f5-179d-4f89-b57b-39c7b57eb360\">\r\nAPM
SLI | <img width=\"1183\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a3e083fa-df13-408b-b02d-e26695398225\">\r\n|
<img width=\"1158\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a94cfe07-32b0-4367-95e8-ab10d232e98c\">","sha":"c2a204269af459fc05145d2977493ad975c8df62"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193990","number":193990,"mergeCommit":{"message":"[SLOs]
Slo form little things (#193990)\n\n## Summary\r\n\r\nSlo form little
things !!\r\n\r\nWill auto add values for APM defaults to all instead of
forcing user !!\r\n\r\n### Changes \r\n\r\nDetails | Before |
After\r\n-- | -- | --\r\nData View component | <img width=\"1262\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/79a5cbcd-04e1-49e6-aa86-036b36c8a6e6\">\r\n|
<img width=\"1391\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/973db8f5-179d-4f89-b57b-39c7b57eb360\">\r\nAPM
SLI | <img width=\"1183\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a3e083fa-df13-408b-b02d-e26695398225\">\r\n|
<img width=\"1158\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/a94cfe07-32b0-4367-95e8-ab10d232e98c\">","sha":"c2a204269af459fc05145d2977493ad975c8df62"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@mgiota mgiota mgiota approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shahzad31 @obltmachine @elasticmachine @kibana-ci @kibanamachine @markov00 @mgiota