Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Discover] Dismiss flyouts when opening another one (#193865) #194256

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

- Closes elastic#193452

## Summary

This PR makes sure that only one flyout is open at a time and
automatically dismisses all others.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

(cherry picked from commit 6fc017a)
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
canvas 1291 1292 +1
cloudSecurityPosture 651 652 +1
discover 997 998 +1
esqlDataGrid 363 364 +1
eventAnnotationListing 578 579 +1
lens 1461 1462 +1
logsExplorer 562 563 +1
observability 1058 1059 +1
searchPlayground 241 242 +1
securitySolution 5827 5828 +1
slo 844 845 +1
unifiedDocViewer 219 220 +1
unifiedHistogram 144 186 +42
total +54

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/discover-utils 140 146 +6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
discover 813.5KB 815.0KB +1.5KB
esql 177.0KB 177.1KB +49.0B
unifiedHistogram 67.2KB 67.9KB +640.0B
unifiedSearch 346.3KB 346.6KB +289.0B
total +2.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
unifiedSearch 38.5KB 38.6KB +70.0B
Unknown metric groups

API count

id before after diff
@kbn/discover-utils 174 180 +6

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jughosta

@kibanamachine kibanamachine merged commit a3b2bb2 into elastic:8.x Sep 27, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants