Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Roles] Fix bug with roles grid not sorting on clicking table header (#194196) #194283

Merged
merged 1 commit into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. [Roles] Fix bug with roles grid not sorting on clicking table header (e…

    …lastic#194196)
    
    Fixes elastic#193786
    
    ## Summary
    Reverts a few changes made when the Roles grid page was moved to a
    functional component. Fixes regression in table sorting.
    
    ### Notes
    
    When preparing for the Query Roles API, we had moved the roles grid page
    to be a functional component. In doing so, we also migrated away from
    the In Memory table in favor of the basic table. EUIBasicTable does not
    support sorting out of the box and is meant to be used for server-side
    sorting, etc (unless we implement custom sorting logic). I've made a few
    changes:
    -  Bring back the InMemoryTable but keep the Search Bar.
    - Remove few (now) unused functions which are to be brought back
    whenever the Query Roles API is ready.
    - Update tests
    
    ### Screen recording
    
    https://github.com/user-attachments/assets/4ac4f771-e7d1-4e17-807e-d6262767d100
    
    ### Release notes
    Fixes UI regression in Roles listing page where users could not sort
    table by using the headers.
    
    ---------
    
    Co-authored-by: Elastic Machine <[email protected]>
    (cherry picked from commit f4ca9e4)
    SiddharthMantri committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a9bd772 View commit details
    Browse the repository at this point in the history