Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Add tooltips to Discover button icons (#192963) #194344

Merged
merged 1 commit into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. Add tooltips to Discover button icons (elastic#192963)

    ## Summary
    
    When navigating through elements in Discover with a keyboard, icon-only
    buttons don't show their browser-native title attribute when focused,
    only when hovered.
    
    This makes it unclear when you "tab in to" an icon-only button what the
    button does.
    
    These changes add a tooltip on the filter in/out buttons on the field
    list values.
    
    |    Before    |    After     |
    | :----------: | :----------: |
    | ![CleanShot 2024-09-15 at 21 20
    36@2x](https://github.com/user-attachments/assets/ed915d78-fc66-4eb4-a4d7-d7c3395edfc6)
    |![CleanShot 2024-09-15 at 21 17
    23@2x](https://github.com/user-attachments/assets/0d7b9862-b8ab-4a2c-bc4b-8b790c393001)
    |
    
    ### Checklist
    
    - [x] [Unit or functional
    tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
    were updated or added to match the most common scenarios
    - [x] Any UI touched in this PR is usable by keyboard only (learn more
    about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
    - [x] Any UI touched in this PR does not create any new axe failures
    (run axe in browser:
    [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
    [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
    - [x] This renders correctly on smaller devices using a responsive
    layout. (You can test this [in your
    browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
    
    (cherry picked from commit c12c361)
    smith committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5871c8b View commit details
    Browse the repository at this point in the history