From df4b55a23caf3a631aff5a99a5a8917727c1350b Mon Sep 17 00:00:00 2001 From: Nathan Reese Date: Mon, 24 Sep 2018 07:50:46 -0600 Subject: [PATCH 1/3] display hits and total hits for courier inspector requests --- src/ui/public/courier/utils/courier_inspector_utils.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/ui/public/courier/utils/courier_inspector_utils.js b/src/ui/public/courier/utils/courier_inspector_utils.js index 30b845e27bc565..68cb8946bd99eb 100644 --- a/src/ui/public/courier/utils/courier_inspector_utils.js +++ b/src/ui/public/courier/utils/courier_inspector_utils.js @@ -54,10 +54,15 @@ function getResponseInspectorStats(searchSource, resp) { } if (resp && resp.hits) { - stats.Hits = { + stats['Hits (total)'] = { value: `${resp.hits.total}`, description: 'The number of documents that match the query.', }; + + stats.Hits = { + value: `${resp.hits.hits.length}`, + description: 'The number of documents that match the query.', + }; } if (lastRequest && (lastRequest.ms === 0 || lastRequest.ms)) { From 7680baf0212e696a3f7663e52c292ef91c802f36 Mon Sep 17 00:00:00 2001 From: Nathan Reese Date: Mon, 24 Sep 2018 07:55:35 -0600 Subject: [PATCH 2/3] update Hits help text to explain difference between total hits --- src/ui/public/courier/utils/courier_inspector_utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ui/public/courier/utils/courier_inspector_utils.js b/src/ui/public/courier/utils/courier_inspector_utils.js index 68cb8946bd99eb..55b52ad3a4cac5 100644 --- a/src/ui/public/courier/utils/courier_inspector_utils.js +++ b/src/ui/public/courier/utils/courier_inspector_utils.js @@ -61,7 +61,7 @@ function getResponseInspectorStats(searchSource, resp) { stats.Hits = { value: `${resp.hits.hits.length}`, - description: 'The number of documents that match the query.', + description: 'The number of documents returned by the query.', }; } From 52071bfbb7397826a58b99d8063bea125f0dcb3a Mon Sep 17 00:00:00 2001 From: Nathan Reese Date: Mon, 24 Sep 2018 10:01:19 -0600 Subject: [PATCH 3/3] fix functional test --- test/functional/apps/discover/_inspector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/functional/apps/discover/_inspector.js b/test/functional/apps/discover/_inspector.js index 5ca2497ef84e48..7f29e96a2f8e20 100644 --- a/test/functional/apps/discover/_inspector.js +++ b/test/functional/apps/discover/_inspector.js @@ -28,7 +28,7 @@ export default function ({ getService, getPageObjects }) { const STATS_ROW_VALUE_INDEX = 1; function getHitCount(requestStats) { const hitsCountStatsRow = requestStats.find((statsRow) => { - return statsRow[STATS_ROW_NAME_INDEX] === 'Hits'; + return statsRow[STATS_ROW_NAME_INDEX] === 'Hits (total)'; }); return hitsCountStatsRow[STATS_ROW_VALUE_INDEX]; }