From fdda3a3763b4cba71346e243d8ef84e0b6acff41 Mon Sep 17 00:00:00 2001 From: Tyler Smalley Date: Wed, 16 Oct 2019 13:17:54 -0700 Subject: [PATCH 1/2] Prevent scripts from loading as soon as downloaded We need to either disable async loading, or defer exection. In IE11, we're running into an issue where the logout page is executing before the vendors file. Signed-off-by: Tyler Smalley --- src/legacy/ui/ui_render/bootstrap/template.js.hbs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/legacy/ui/ui_render/bootstrap/template.js.hbs b/src/legacy/ui/ui_render/bootstrap/template.js.hbs index d305626057540f..61762817841c53 100644 --- a/src/legacy/ui/ui_render/bootstrap/template.js.hbs +++ b/src/legacy/ui/ui_render/bootstrap/template.js.hbs @@ -46,7 +46,7 @@ if (window.__kbnStrictCsp__ && window.__kbnCspNotEnforced__) { function createJavascriptElement(path) { var dom = document.createElement('script'); - dom.setAttribute('async', ''); + dom.setAttribute('defer', true); dom.addEventListener('error', failure); dom.setAttribute('src', file); dom.addEventListener('load', next); From d739dc941d5bfad5b3d3bb5dcae7a99a0e765031 Mon Sep 17 00:00:00 2001 From: Tyler Smalley Date: Wed, 16 Oct 2019 18:36:11 -0700 Subject: [PATCH 2/2] Use string value Signed-off-by: Tyler Smalley --- src/legacy/ui/ui_render/bootstrap/template.js.hbs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/legacy/ui/ui_render/bootstrap/template.js.hbs b/src/legacy/ui/ui_render/bootstrap/template.js.hbs index 61762817841c53..d8a55935b705a0 100644 --- a/src/legacy/ui/ui_render/bootstrap/template.js.hbs +++ b/src/legacy/ui/ui_render/bootstrap/template.js.hbs @@ -46,7 +46,7 @@ if (window.__kbnStrictCsp__ && window.__kbnCspNotEnforced__) { function createJavascriptElement(path) { var dom = document.createElement('script'); - dom.setAttribute('defer', true); + dom.setAttribute('defer', 'defer'); dom.addEventListener('error', failure); dom.setAttribute('src', file); dom.addEventListener('load', next);