diff --git a/examples/demo_search/public/demo_search_strategy.ts b/examples/demo_search/public/demo_search_strategy.ts index d2854151e14c85..cb2480c8a5f194 100644 --- a/examples/demo_search/public/demo_search_strategy.ts +++ b/examples/demo_search/public/demo_search_strategy.ts @@ -18,11 +18,7 @@ */ import { Observable } from 'rxjs'; -import { - ISearchContext, - SYNC_SEARCH_STRATEGY, - ISearchGeneric, -} from '../../../src/plugins/data/public'; +import { ISearchContext, SYNC_SEARCH_STRATEGY } from '../../../src/plugins/data/public'; import { TSearchStrategyProvider, ISearchStrategy } from '../../../src/plugins/data/public'; import { DEMO_SEARCH_STRATEGY, IDemoResponse } from '../common'; @@ -54,15 +50,15 @@ import { DEMO_SEARCH_STRATEGY, IDemoResponse } from '../common'; * @param search - a search function to access other strategies that have already been registered. */ export const demoClientSearchStrategyProvider: TSearchStrategyProvider = ( - context: ISearchContext, - search: ISearchGeneric + context: ISearchContext ): ISearchStrategy => { + const syncStrategyProvider = context.getSearchStrategy(SYNC_SEARCH_STRATEGY); + const { search } = syncStrategyProvider(context); return { - search: (request, options) => - search( - { ...request, serverStrategy: DEMO_SEARCH_STRATEGY }, - options, - SYNC_SEARCH_STRATEGY - ) as Observable, + search: (request, options) => { + return search({ ...request, serverStrategy: DEMO_SEARCH_STRATEGY }, options) as Observable< + IDemoResponse + >; + }, }; }; diff --git a/examples/demo_search/public/index.ts b/examples/demo_search/public/index.ts index 7790c2950ac22c..0a97ac6b72ea7f 100644 --- a/examples/demo_search/public/index.ts +++ b/examples/demo_search/public/index.ts @@ -17,12 +17,10 @@ * under the License. */ -import { PluginInitializer, PluginInitializerContext } from 'kibana/public'; +import { PluginInitializer } from 'kibana/public'; import { DemoDataPlugin } from './plugin'; export { DEMO_SEARCH_STRATEGY } from '../common'; -export const plugin: PluginInitializer = ( - initializerContext: PluginInitializerContext -) => new DemoDataPlugin(initializerContext); +export const plugin: PluginInitializer = () => new DemoDataPlugin(); diff --git a/examples/demo_search/public/plugin.ts b/examples/demo_search/public/plugin.ts index 81ba585b991902..62c912716e627c 100644 --- a/examples/demo_search/public/plugin.ts +++ b/examples/demo_search/public/plugin.ts @@ -18,7 +18,7 @@ */ import { DataPublicPluginSetup } from '../../../src/plugins/data/public'; -import { Plugin, CoreSetup, PluginInitializerContext } from '../../../src/core/public'; +import { Plugin, CoreSetup } from '../../../src/core/public'; import { DEMO_SEARCH_STRATEGY } from '../common'; import { demoClientSearchStrategyProvider } from './demo_search_strategy'; import { IDemoRequest, IDemoResponse } from '../common'; @@ -47,10 +47,8 @@ declare module '../../../src/plugins/data/public' { } export class DemoDataPlugin implements Plugin { - constructor(private initializerContext: PluginInitializerContext) {} public setup(core: CoreSetup, deps: DemoDataSearchSetupDependencies) { deps.data.search.registerSearchStrategyProvider( - this.initializerContext.opaqueId, DEMO_SEARCH_STRATEGY, demoClientSearchStrategyProvider ); diff --git a/examples/search_explorer/public/application.tsx b/examples/search_explorer/public/application.tsx index 801a3c615ac613..7d921adc1d29bf 100644 --- a/examples/search_explorer/public/application.tsx +++ b/examples/search_explorer/public/application.tsx @@ -28,12 +28,13 @@ import { EuiSideNav, } from '@elastic/eui'; -import { AppMountContext, AppMountParameters } from '../../../src/core/public'; +import { AppMountParameters, CoreStart } from '../../../src/core/public'; import { EsSearchTest } from './es_strategy'; import { Page } from './page'; import { DemoStrategy } from './demo_strategy'; import { DocumentationPage } from './documentation'; import { SearchApiPage } from './search_api'; +import { AppPluginStartDependencies, SearchBarComponentParams } from './types'; const Home = () => ; @@ -44,7 +45,7 @@ interface PageDef { } type NavProps = RouteComponentProps & { - navigateToApp: AppMountContext['core']['application']['navigateToApp']; + navigateToApp: CoreStart['application']['navigateToApp']; pages: PageDef[]; }; @@ -71,7 +72,7 @@ const Nav = withRouter(({ history, navigateToApp, pages }: NavProps) => { const buildPage = (page: PageDef) => {page.component}; -const SearchApp = ({ basename, context }: { basename: string; context: AppMountContext }) => { +const SearchApp = ({ basename, data, application }: SearchBarComponentParams) => { const pages: PageDef[] = [ { id: 'home', @@ -86,12 +87,12 @@ const SearchApp = ({ basename, context }: { basename: string; context: AppMountC { title: 'ES search strategy', id: 'esSearch', - component: , + component: , }, { title: 'Demo search strategy', id: 'demoSearch', - component: , + component: , }, ]; @@ -103,7 +104,7 @@ const SearchApp = ({ basename, context }: { basename: string; context: AppMountC -