Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make discover sidebar UI more consistent #7958

Merged
merged 2 commits into from
Dec 27, 2016
Merged

Make discover sidebar UI more consistent #7958

merged 2 commits into from
Dec 27, 2016

Conversation

jimmyjones2
Copy link
Contributor

Fixes #3296

kbn-sidebar

@elasticmachine
Copy link
Contributor

Can one of the admins verify this patch?

@epixa epixa added the review label Aug 20, 2016
@epixa
Copy link
Contributor

epixa commented Aug 20, 2016

jenkins, test this

@epixa
Copy link
Contributor

epixa commented Aug 20, 2016

I'm not sure what the test failure is here. Can you rebase to make sure this is on the latest?

@jimmyjones2
Copy link
Contributor Author

@epixa Rebased, can you test again please?

@epixa
Copy link
Contributor

epixa commented Sep 7, 2016

jenkins, test this

@cjcenizal
Copy link
Contributor

@jimmyjones2 Sorry it's taken so long for us to get to this! It looks really great. I have two requests before we can merge this:

  1. In kibana/src/core_plugins/kibana/public/discover/styles/main.less, on line 164, the .discover-field-details-close class can be deleted since it's no longer used.
  2. In kibana/src/ui/public/styles/variables/for-theme.less, on lines 53-56, the variables @discover-field-details-close-border, @discover-field-details-close-bg, @discover-field-details-close-hover-bg, and @discover-field-details-close-hover-color can also be deleted because they're no longer used.

Once these are address I'll merge this PR. Thanks!

@cjcenizal cjcenizal added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Dec 26, 2016
@jimmyjones2
Copy link
Contributor Author

@cjcenizal Done!

@cjcenizal
Copy link
Contributor

Beautiful! Thanks man.

@cjcenizal cjcenizal merged commit 6014a07 into elastic:master Dec 27, 2016
elastic-jasper added a commit that referenced this pull request Dec 27, 2016
@elastic-jasper
Make discover sidebar UI more consistent
084f1ad 
Backports PR #7958

**Commit 1:**
Make discover sidebar UI more consistent

* Original sha: c2ec7b0
* Authored by Jimmy Jones <[email protected]> on 2016-08-08T21:00:06Z

**Commit 2:**
Remove unused code

* Original sha: 7b996e9
* Authored by Jimmy Jones <[email protected]> on 2016-12-27T14:37:38Z
@elastic-jasper elastic-jasper mentioned this pull request Dec 27, 2016
Merged
cjcenizal pushed a commit that referenced this pull request Dec 27, 2016
@elastic-jasper @cjcenizal
Make discover sidebar UI more consistent (#9655)
90a9f67 
Backports PR #7958

**Commit 1:**
Make discover sidebar UI more consistent

* Original sha: c2ec7b0
* Authored by Jimmy Jones <[email protected]> on 2016-08-08T21:00:06Z

**Commit 2:**
Remove unused code

* Original sha: 7b996e9
* Authored by Jimmy Jones <[email protected]> on 2016-12-27T14:37:38Z
jbudz pushed a commit that referenced this pull request Sep 10, 2024
@cee-chen @mgadewoll
Upgrade EUI to v95.10.1 (#192026)
20566d0 
`v95.9.0`⏩`v95.10.1`

> [!note]
> **EuiDataGrid**'s header cells have received a major UX change in
order to support interactive children within header content. Column
header actions now must be hovered and then clicked directly, or opened
with the Enter key, as opposed to being able to click the entire header
cell to see the actions popover.

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.10.0`](https://github.com/elastic/eui/releases/v95.10.0)

- Updated `EuiDataGrid` to support interactive header cell content
([#7898](elastic/eui#7898))
- Updated `EuiSearchBar`'s `field_value_selection` filter type with a
new `autoSortOptions` config, allowing consumers to configure whether or
not selected options are automatically sorted to the top of the filter
list ([#7958](elastic/eui#7958))
- Updated `getDefaultEuiMarkdownPlugins` to support the following new
default plugin configurations:
([#7985](elastic/eui#7985))
- `parsingConfig.linkValidator`, which allows configuring
`allowRelative` and `allowProtocols`
  - `parsingConfig.emoji`, which allows configuring emoticon parsing
- `processingConfig.linkProps`, which allows configuring rendered links
with any props that `EuiLink` accepts
- See our **Markdown plugins** documentation for example
`EuiMarkdownFormat` and `EuiMarkdownEditor` usage
- Updated `EuiDatePicker` to support `append` and `prepend` nodes in its
form control layout ([#7987](elastic/eui#7987))

**Bug fixes**

- Fixed border rendering bug with inline `EuiDatePicker`s with
`shadow={false}` ([#7987](elastic/eui#7987))
- Fixed `EuiSuperSelect`'s placeholder text color to match other form
controls ([#7995](elastic/eui#7995))

**Accessibility**

- Improved the keyboard navigation and screen reader output for
`EuiDataGrid` header cells
([#7898](elastic/eui#7898))

## [`v95.10.1`](https://github.com/elastic/eui/releases/v95.10.1)

**Bug fixes**

- Fixed a visual bug in compact density `EuiDataGrid`s, where the header
cell height would increase when the actions button became visible
([#7999](elastic/eui#7999))

---------

Co-authored-by: Lene Gadewoll <[email protected]>
gergoabraham pushed a commit to gergoabraham/kibana that referenced this pull request Sep 13, 2024
@cee-chen @mgadewoll @gergoabraham
Upgrade EUI to v95.10.1 (elastic#192026)
58fd8c1 
`v95.9.0`⏩`v95.10.1`

> [!note]
> **EuiDataGrid**'s header cells have received a major UX change in
order to support interactive children within header content. Column
header actions now must be hovered and then clicked directly, or opened
with the Enter key, as opposed to being able to click the entire header
cell to see the actions popover.

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.10.0`](https://github.com/elastic/eui/releases/v95.10.0)

- Updated `EuiDataGrid` to support interactive header cell content
([elastic#7898](elastic/eui#7898))
- Updated `EuiSearchBar`'s `field_value_selection` filter type with a
new `autoSortOptions` config, allowing consumers to configure whether or
not selected options are automatically sorted to the top of the filter
list ([elastic#7958](elastic/eui#7958))
- Updated `getDefaultEuiMarkdownPlugins` to support the following new
default plugin configurations:
([elastic#7985](elastic/eui#7985))
- `parsingConfig.linkValidator`, which allows configuring
`allowRelative` and `allowProtocols`
  - `parsingConfig.emoji`, which allows configuring emoticon parsing
- `processingConfig.linkProps`, which allows configuring rendered links
with any props that `EuiLink` accepts
- See our **Markdown plugins** documentation for example
`EuiMarkdownFormat` and `EuiMarkdownEditor` usage
- Updated `EuiDatePicker` to support `append` and `prepend` nodes in its
form control layout ([elastic#7987](elastic/eui#7987))

**Bug fixes**

- Fixed border rendering bug with inline `EuiDatePicker`s with
`shadow={false}` ([elastic#7987](elastic/eui#7987))
- Fixed `EuiSuperSelect`'s placeholder text color to match other form
controls ([elastic#7995](elastic/eui#7995))

**Accessibility**

- Improved the keyboard navigation and screen reader output for
`EuiDataGrid` header cells
([elastic#7898](elastic/eui#7898))

## [`v95.10.1`](https://github.com/elastic/eui/releases/v95.10.1)

**Bug fixes**

- Fixed a visual bug in compact density `EuiDataGrid`s, where the header
cell height would increase when the actions button became visible
([elastic#7999](elastic/eui#7999))

---------

Co-authored-by: Lene Gadewoll <[email protected]>
markov00 pushed a commit to markov00/kibana that referenced this pull request Sep 18, 2024
@cee-chen @mgadewoll @markov00
Upgrade EUI to v95.10.1 (elastic#192026)
2f8036e 
`v95.9.0`⏩`v95.10.1`

> [!note]
> **EuiDataGrid**'s header cells have received a major UX change in
order to support interactive children within header content. Column
header actions now must be hovered and then clicked directly, or opened
with the Enter key, as opposed to being able to click the entire header
cell to see the actions popover.

_[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_

---

## [`v95.10.0`](https://github.com/elastic/eui/releases/v95.10.0)

- Updated `EuiDataGrid` to support interactive header cell content
([elastic#7898](elastic/eui#7898))
- Updated `EuiSearchBar`'s `field_value_selection` filter type with a
new `autoSortOptions` config, allowing consumers to configure whether or
not selected options are automatically sorted to the top of the filter
list ([elastic#7958](elastic/eui#7958))
- Updated `getDefaultEuiMarkdownPlugins` to support the following new
default plugin configurations:
([elastic#7985](elastic/eui#7985))
- `parsingConfig.linkValidator`, which allows configuring
`allowRelative` and `allowProtocols`
  - `parsingConfig.emoji`, which allows configuring emoticon parsing
- `processingConfig.linkProps`, which allows configuring rendered links
with any props that `EuiLink` accepts
- See our **Markdown plugins** documentation for example
`EuiMarkdownFormat` and `EuiMarkdownEditor` usage
- Updated `EuiDatePicker` to support `append` and `prepend` nodes in its
form control layout ([elastic#7987](elastic/eui#7987))

**Bug fixes**

- Fixed border rendering bug with inline `EuiDatePicker`s with
`shadow={false}` ([elastic#7987](elastic/eui#7987))
- Fixed `EuiSuperSelect`'s placeholder text color to match other form
controls ([elastic#7995](elastic/eui#7995))

**Accessibility**

- Improved the keyboard navigation and screen reader output for
`EuiDataGrid` header cells
([elastic#7898](elastic/eui#7898))

## [`v95.10.1`](https://github.com/elastic/eui/releases/v95.10.1)

**Bug fixes**

- Fixed a visual bug in compact density `EuiDataGrid`s, where the header
cell height would increase when the actions button became visible
([elastic#7999](elastic/eui#7999))

---------

Co-authored-by: Lene Gadewoll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cjcenizal cjcenizal

Labels
review Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. v5.2.0 v6.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimmyjones2 @elasticmachine @epixa @cjcenizal