You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
as proposed/discussed in elastic/logstash-devutils#32 and #3812 (now #3895) I am moving here the discussion about potentially introducing a new ready? method which would mainly help for testing to know when the plugin is ready and we can call the stop method on it.
there are a few things we should consider:
it seems this new ready? method would only be used for tests/specs, in which case, is it really needed in a public api?
it is hard de define the exact semantic of ready, is it ready once register has been called? or when the run method has been called? or when run has completed some internal initialization?
in any cases, the stop method should always be callable after register has been called
would the equivalent of the stop / stop? be sufficient? instead of a ready? we could just have a threadsaferun? method that just returns true when the run method has been called?
thoughts?
The text was updated successfully, but these errors were encountered:
as proposed/discussed in elastic/logstash-devutils#32 and #3812 (now #3895) I am moving here the discussion about potentially introducing a new
ready?
method which would mainly help for testing to know when the plugin is ready and we can call thestop
method on it.there are a few things we should consider:
ready?
method would only be used for tests/specs, in which case, is it really needed in a public api?register
has been called? or when therun
method has been called? or whenrun
has completed some internal initialization?stop
method should always be callable afterregister
has been calledstop
/stop?
be sufficient? instead of aready?
we could just have a threadsaferun?
method that just returnstrue
when therun
method has been called?thoughts?
The text was updated successfully, but these errors were encountered: